Skip to content

Home-Unable to paste image in home search box - #99562

Merged
inimaga merged 1 commit into
Expensify:mainfrom
software-mansion-labs:99554-concierge-prompt-box-paste-image
Aug 27, 2026
Merged

inimaga merged 1 commit into
Expensify:mainfrom
software-mansion-labs:99554-concierge-prompt-box-paste-image

Conversation

@WojtekBoman

@WojtekBoman WojtekBoman commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

The Home Concierge prompt box reuses the shared Composer but never passed onPasteFile, so a pasted image was silently dropped (on web the paste was even preventDefaulted first). ConciergePromptBox now passes onPasteFile, routing pasted files into the existing validation + preview + send flow used by the "+" button, and useConciergeAttachmentPicker accepts the single-file shape that paste emits.

This also fixes a rebase-only gap in jest/setup.ts: main recently added clearInput -> forceClearInput (src/libs/ComponentUtils), which dispatches a UI-thread worklet via dispatchCommand. react-native-reanimated/mock doesn't export dispatchCommand (it has its own // dispatchCommand: ADD ME IF NEEDED comment), and that worklet runs on a real setTimeout(0) that isn't tied to the test that queued it - it can fire during a later test's await/waitFor, wherever that lands. Our new async paste test happened to be the first thing in this suite to await anything after a message send, so it's what surfaced the crash, but the gap belongs to main's change, not to this test. Added dispatchCommand: jest.fn() to the global reanimated mock so any test in the app touching a cleared composer is covered, not just this file.

The app behaviour after being fixed:

Screen.Recording.2026-08-26.at.14.45.59.mov

Fixed Issues

$ #99554
PROPOSAL:

Tests

  1. Copy an image to the clipboard (e.g. take a screenshot).

  2. Sign in and stay on the Home page.

  3. Click the Concierge prompt box under the greeting to focus it.

  4. Paste with Ctrl/Cmd+V (on Android: long-press the input and choose Paste).

  5. Verify that the attachment preview modal opens with the pasted image, and that on Android the keyboard is dismissed.

  6. Press Send in the modal.

  7. Verify that the image is posted to the Concierge chat.

  8. Back on Home, type Here is my receipt into the prompt box.

  9. Paste the image again and press Send in the preview modal.

  10. Verify that the image is posted to Concierge together with the typed message, and that the prompt box is left empty.

  11. Copy plain text to the clipboard, focus the Home prompt box and paste.

  12. Verify that the text is inserted into the input and no attachment preview modal opens.

  13. Copy an image to the clipboard, focus the search input at the top of Home and paste there.

  14. Verify that no attachment preview modal opens - the Concierge prompt box must not capture pastes aimed at another input.

  15. Copy an image out of Google Docs/Sheets (this uses a different clipboard path), paste it into the Home prompt box.

  16. Verify that the attachment preview modal opens with that image.

  • Verify that no errors appear in the JS console

Offline tests

  1. Turn off the network connection.
  2. Paste an image into the Home Concierge prompt box.
  3. Verify that the attachment preview modal still opens and Send is available.
  4. Press Send.
  5. Verify that the attachment appears in the Concierge chat in a pending (greyed out) state.
  6. Restore the network connection.
  7. Verify that the attachment finishes uploading and loses the pending state, with no duplicate message.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@WojtekBoman WojtekBoman changed the title Fix pasting an image into the Home Concierge prompt box Home-Unable to paste image in home search box Aug 26, 2026
@WojtekBoman
WojtekBoman marked this pull request as ready for review August 26, 2026 12:53
@WojtekBoman
WojtekBoman requested review from a team as code owners August 26, 2026 12:53
@melvin-bot
melvin-bot Bot requested review from ZhenjaHorbach and joekaufmanexpensify and removed request for a team August 26, 2026 12:53
@melvin-bot

melvin-bot Bot commented Aug 26, 2026

Copy link
Copy Markdown

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team August 26, 2026 12:53

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 95ec64629f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@WojtekBoman
WojtekBoman force-pushed the 99554-concierge-prompt-box-paste-image branch from 95ec646 to f37e18c Compare August 26, 2026 13:02
@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

@WojtekBoman
Can you please sync the changes with this PR?
#99552
I mean, I suppose we need to add interceptAnonymousUser guard here also

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

And we have conflicts 😅

@joekaufmanexpensify joekaufmanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for product.

@WojtekBoman
WojtekBoman force-pushed the 99554-concierge-prompt-box-paste-image branch from 511a4f3 to 4ec98ba Compare August 27, 2026 06:34
@WojtekBoman

Copy link
Copy Markdown
Contributor Author

@ZhenjaHorbach I've adjusted the PR, it should be ready now! :)

@ZhenjaHorbach

ZhenjaHorbach commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
2026-08-27.12.08.23.mov
Android: mWeb Chrome
2026-08-27.12.08.23.mov
iOS: HybridApp
2026-08-27.12.03.33.mov
iOS: mWeb Safari

Uploading Запись экрана — 2026-08-27 в 12.01.41.mov…

MacOS: Chrome / Safari
2026-08-27.12.00.35.mov

@melvin-bot
melvin-bot Bot requested review from inimaga and puneetlath August 27, 2026 10:15
@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

Changes work good!

@inimaga
inimaga merged commit 0f10686 into Expensify:main Aug 27, 2026
35 of 37 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 inimaga has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Aug 27, 2026
65 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/inimaga in version: 9.4.63-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 No help site changes required.

This PR is a bug fix that restores expected behavior — it makes a pasted image in the Home Concierge prompt box route into the existing attachment validation → preview → send flow (previously the paste was silently dropped), plus a test-mock fix in jest/setup.ts. It doesn't add or change any user-facing feature, label, or flow that the help site documents.

Why no docs update is needed
  • The change is entirely internal wiring: ConciergePromptBox now passes onPasteFile, and useConciergeAttachmentPicker accepts the single-file shape that paste emits. No new UI, buttons, or copy.
  • I searched App/docs/articles for the affected surface — concierge, paste, attach, prompt box, ask concierge, home page, receipt. The Concierge articles (Concierge-Basics.md, What-Concierge-Can-Do.md) already describe the capability generically ("upload a receipt", "send receipts directly in the chat") without enumerating input methods (paste vs. the + button vs. drag-and-drop).
  • No article documents the paste mechanic specifically, so there is nothing to correct or add. The generic "upload/send a receipt to Concierge" guidance remains accurate.

Since no changes are required, I did not create a docs PR.


view run

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #99736 was identified to be related to this PR.

@jponikarchuk

Copy link
Copy Markdown

This PR failing because of the issue #99736
This issue is reproducible in: Android app

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.63-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants