Repository navigation
Conversation
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95ec64629f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
95ec646 to
f37e18c
Compare
|
@WojtekBoman |
|
And we have conflicts 😅 |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product.
f37e18c to
511a4f3
Compare
511a4f3 to
4ec98ba
Compare
|
@ZhenjaHorbach I've adjusted the PR, it should be ready now! :) |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2026-08-27.12.08.23.movAndroid: mWeb Chrome2026-08-27.12.08.23.moviOS: HybridApp2026-08-27.12.03.33.moviOS: mWeb SafariUploading Запись экрана — 2026-08-27 в 12.01.41.mov… MacOS: Chrome / Safari2026-08-27.12.00.35.mov |
|
Changes work good! |
|
🚧 inimaga has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/inimaga in version: 9.4.63-0 🚀
|
|
🤖 No help site changes required. This PR is a bug fix that restores expected behavior — it makes a pasted image in the Home Concierge prompt box route into the existing attachment validation → preview → send flow (previously the paste was silently dropped), plus a test-mock fix in Why no docs update is needed
Since no changes are required, I did not create a docs PR. |
|
Deploy Blocker #99736 was identified to be related to this PR. |
|
This PR failing because of the issue #99736 |
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.63-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
The Home Concierge prompt box reuses the shared
Composerbut never passedonPasteFile, so a pasted image was silently dropped (on web the paste was evenpreventDefaulted first).ConciergePromptBoxnow passesonPasteFile, routing pasted files into the existing validation + preview + send flow used by the "+" button, anduseConciergeAttachmentPickeraccepts the single-file shape that paste emits.This also fixes a rebase-only gap in
jest/setup.ts:mainrecently addedclearInput->forceClearInput(src/libs/ComponentUtils), which dispatches a UI-thread worklet viadispatchCommand.react-native-reanimated/mockdoesn't exportdispatchCommand(it has its own// dispatchCommand: ADD ME IF NEEDEDcomment), and that worklet runs on a realsetTimeout(0)that isn't tied to the test that queued it - it can fire during a later test'sawait/waitFor, wherever that lands. Our new async paste test happened to be the first thing in this suite to await anything after a message send, so it's what surfaced the crash, but the gap belongs tomain's change, not to this test. AddeddispatchCommand: jest.fn()to the global reanimated mock so any test in the app touching a cleared composer is covered, not just this file.The app behaviour after being fixed:
Screen.Recording.2026-08-26.at.14.45.59.mov
Fixed Issues
$ #99554
PROPOSAL:
Tests
Copy an image to the clipboard (e.g. take a screenshot).
Sign in and stay on the Home page.
Click the Concierge prompt box under the greeting to focus it.
Paste with Ctrl/Cmd+V (on Android: long-press the input and choose Paste).
Verify that the attachment preview modal opens with the pasted image, and that on Android the keyboard is dismissed.
Press Send in the modal.
Verify that the image is posted to the Concierge chat.
Back on Home, type
Here is my receiptinto the prompt box.Paste the image again and press Send in the preview modal.
Verify that the image is posted to Concierge together with the typed message, and that the prompt box is left empty.
Copy plain text to the clipboard, focus the Home prompt box and paste.
Verify that the text is inserted into the input and no attachment preview modal opens.
Copy an image to the clipboard, focus the search input at the top of Home and paste there.
Verify that no attachment preview modal opens - the Concierge prompt box must not capture pastes aimed at another input.
Copy an image out of Google Docs/Sheets (this uses a different clipboard path), paste it into the Home prompt box.
Verify that the attachment preview modal opens with that image.
Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari