Repository navigation
Implement Mark all as read for all Inbox tab - #99830
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-09-03.at.11.19.11.movAndroid: mWeb ChromeScreen.Recording.2026-09-03.at.11.14.28.moviOS: HybridAppScreen.Recording.2026-09-03.at.11.15.07.moviOS: mWeb SafariScreen.Recording.2026-09-03.at.11.05.58.movMacOS: Chrome / SafariScreen.Recording.2026-09-03.at.11.01.46.mov |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #99809 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
🚧 danieldoglas has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.4.75-0 🚀
|
|
Yes — a help site change was required. Draft PR: #100746 This PR extends Mark all as read from the Unread tab to the All and To-dos tabs, and adds a To-dos-specific confirmation prompt ( What the docs PR changes — one file,
No other How the UI labels were verifiedI checked the live web build and confirmed the tab labels are exactly All, Unread, and To-dos. The web test harness has no right-click or long-press support, so I could not open the menu or the confirmation modal live. The menu item (Mark all as read), the modal title, and the buttons (Mark all as read / Cancel) come from the @hungvu193, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.75-3 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.75-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Add
Mark as readto all Inbox tabs.Fixed Issues
$ #99809
PROPOSAL: N/A
Tests
Offline tests
Same as Test steps.
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-08-30.at.14.18.53.mov
Android: mWeb Chrome
Screen.Recording.2026-08-30.at.14.18.53.mov
iOS: Native
Screen.Recording.2026-08-30.at.14.15.26.mov
iOS: mWeb Safari
Screen.Recording.2026-08-30.at.14.14.51.mov
MacOS: Chrome / Safari
Screen.Recording.2026-08-30.at.12.53.48.mov