Skip to content

Run engine preset burns outside the configuration critical section - #834

Merged
mck1117 merged 1 commit into
FOME-Tech:masterfrom
gdiciocco:fix/burn-preset-lock
Oct 5, 2026
Merged

mck1117 merged 1 commit into
FOME-Tech:masterfrom
gdiciocco:fix/burn-preset-lock

Conversation

@gdiciocco

@gdiciocco gdiciocco commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Extracted from closed #825.

Release the configuration critical section before setEngineType() calls writeToFlashNow(). Keep configuration and sniffer changes protected, and preserve the configuration version increment after the burn.

  • Severity assessment: High — the H7 flash driver can sleep while the caller holds the system lock, violating the RTOS execution contract.
  • Dependencies: none.
  • Validation: all direct-burn call sites audited; host suite and Core8 firmware/OpenBLT builds pass. Runtime lock behaviour still requires H7 hardware validation.

Change size

Git diff line counts (added/removed), including comments and blank lines, grouped by file role.

Area Added Removed
Production firmware (sources/headers) +4 −2
Tests, mocks and harness +0 −0
Changelog / documentation +1 −0
Total +5 −2

@mck1117
mck1117 merged commit 4121937 into FOME-Tech:master Oct 5, 2026
20 checks passed
mck1117 added a commit that referenced this pull request Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants