Skip to content

Keep DC actuators inhibited across blocking calibration burns - #838

Draft
gdiciocco wants to merge 9 commits into
FOME-Tech:masterfrom
gdiciocco:fix/burn-actuator-guard
Draft

gdiciocco wants to merge 9 commits into
FOME-Tech:masterfrom
gdiciocco:fix/burn-actuator-guard

Conversation

@gdiciocco

@gdiciocco gdiciocco commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Extracted from closed #825.

Addresses the actuator behaviour reported in #726.

Inhibit attached ETB/DC motors for the complete blocking-burn lifecycle, including failure reporting and teardown. Reject control calculations started before the burn. Resume through a valid control cycle using sensor samples published after completion; reset PID state and abort calibration/tuning sequences.

  • Severity assessment: Critical — blocking flash operations could retain an active motor command or restore stale output during recovery.
  • Dependencies: actuator protection requires #834, #835 and #836. Independent of #837.
  • Validation: 804 host tests pass; Core8 and simulator builds pass. Physical output timing remains to be validated on a bench.

Draft integration note: the current branch includes the foundation from #833, #834, #835, #836, so the current diff also contains those prerequisite changes. This PR will be rebased/updated against master according to their adoption, leaving only blocking-burn actuator protection and its tests; validation will be rerun before marking it ready for review.

Change size

Git diff line counts (added/removed), including comments and blank lines, grouped by file role.

Own change is measured against the shared foundation b1c8d13577. The current PR diff also includes #833–#836.

Area Own change (+/−) Current PR (+/−)
Production firmware (sources/headers) +222 / −18 +607 / −113
Tests, mocks and harness +644 / −4 +1638 / −13
Simulator +0 / −0 +8 / −0
Build files / test registration +1 / −0 +5 / −0
Changelog / documentation +1 / −0 +5 / −0
Total +868 / −22 +2263 / −126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant