clang-tidy: resolve readability-isolate-declaration

[knoepfel]

Resolve readability-isolate-declaration clang-tidy warnings.

• Code quality: Resolved readability-isolate-declaration clang-tidy warnings by splitting combined local variable declarations in Python error handling, module wrappers, and checksum parsing.
• Tests: Updated test/form/reader.cpp declarations without changing checksum parsing or verification behavior.
• Documentation: Recorded the clang-tidy fix in docs/dev/clang-tidy-fixes-2026-04.md.

[coderabbitai]

Important

Review skipped

No new commits to review since the last review.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: cf48e097-1da0-4264-90aa-7c655d9ffde9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Walkthrough

This change splits grouped local declarations in Python wrapper and form-reader code, preserving behavior, and adds the corresponding readability-isolate-declaration entry to the clang-tidy fixes document.

Changes

Declaration cleanup

Layer / File(s)	Summary
Separate local declarations plugins/python/src/errorwrap.cpp, plugins/python/src/modulewrap.cpp, test/form/reader.cpp	Grouped pointer, vector, and integer declarations are split into individual declarations without changing control flow, initialization, or parsing behavior.
Clang-tidy checklist update docs/dev/clang-tidy-fixes-2026-04.md	Adds the readability-isolate-declaration checklist item and PR link.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: greenc-fnal

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: fixing clang-tidy readability-isolate-declaration warnings.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##             main     #756   +/-   ##
=======================================
  Coverage        ?   83.98%           
=======================================
  Files           ?      172           
  Lines           ?     7270           
  Branches        ?      845           
=======================================
  Hits            ?     6106           
  Misses          ?      885           
  Partials        ?      279           

Flag	Coverage Δ
scripts	80.55% <ø> (?)
unittests	85.76% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
plugins/python/src/errorwrap.cpp	80.43% <100.00%> (ø)
plugins/python/src/modulewrap.cpp	75.39% <100.00%> (ø)

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b7fd8d...de89d4f. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[knoepfel]

@CodeRabbit review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[gemmeren]

OK for FORM, thanks