Conversation
HandSonic
force-pushed
the
fix/ai-history-delete-rollback
branch
3 times, most recently
from
September 3, 2026 21:07
03d04a0 to
2e542ba
Compare
…emon-threads fix(tools): harden asynchronous JDBC downloads
…ution-isolation fix(result-set): isolate table edits from query execution options
…orizontal-scroll fix(ui): enable horizontal scrolling in filter popovers
…rmation-identifiers fix(table): confirm copy names and quote identifiers once
…alog-metadata fix(kingbase): export table DDL from catalog metadata
…-alignment fix(ui): align short filters and hide inactive scrollbars
…vel-order-by fix(sqlserver): detect top-level pagination ordering
…llback fix(cache): recover from corrupt scalar entries
…omic-mutations fix(storage): publish small mutations after persistence
…orkflow feat(release): support parameterized Community Beta prereleases
…ach-rowid # Conflicts: # chat2db-community-server/chat2db-community-plugins/chat2db-community-cockroachdb/src/main/java/ai/chat2db/plugin/cockroachdb/CockroachDBMetaData.java # chat2db-community-server/chat2db-community-plugins/chat2db-community-cockroachdb/src/main/java/ai/chat2db/plugin/cockroachdb/builder/CockroachDBSqlBuilder.java
feat(workspace): display table update time
…primary-key fix(sql): resolve primary keys through single-table subqueries
…ingle-row-2483 fix(cockroachdb): limit no-key row updates and deletes natively
…rt-batch1-fast-mode feat(import): add optional parallel CSV import
…ap-beta feat(desktop): unify package layout and enable beta updates
fix(storage): publish ER position after persistence
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (!target.getParent().equals(stagingDirectory)) { | ||
| throw new IOException("invalid staging target"); | ||
| } | ||
| Files.copy(source, target, StandardCopyOption.REPLACE_EXISTING); |
| if (!target.getParent().equals(stagingDirectory)) { | ||
| throw new IOException("invalid staging target"); | ||
| } | ||
| Files.copy(source, target, StandardCopyOption.REPLACE_EXISTING); |
| } | ||
|
|
||
| private static void validateSource(File file, String originalFileName) { | ||
| if (file == null || !file.isFile() || !file.canRead() || file.length() > MAX_SIZE_BYTES |
| } | ||
|
|
||
| private static void validateSource(File file, String originalFileName) { | ||
| if (file == null || !file.isFile() || !file.canRead() || file.length() > MAX_SIZE_BYTES |
|
|
||
| private static void deleteQuietly(Path path) { | ||
| try { | ||
| Files.deleteIfExists(path); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A - no matching issue was found.
Summary
AI history deletion persisted removal from the owner session index before deleting the message file. If message deletion failed, the owner record was lost; a retry then saw no owned session and silently left the orphaned message path forever. This change restores the original session snapshot on deletion failure and preserves rollback failures as suppressed diagnostics.
Affected surfaces
Verification
Risk and compatibility
Reviewer map
AiChatHistoryServiceImpl.deleteSessionLocalandAiChatHistoryDeleteRollbackTest.2e542ba26d30ebcf3ffdbf1b5d5ab2f9f9604bd9; no migration is required.Contributor declaration
AI assistance: OpenAI Codex assisted with diagnosis, implementation, deterministic tests, verification, and adversarial review.
Latest-main revalidation (2026-09-04)