Conversation
HandSonic
force-pushed
the
fix/namespace-position-atomic
branch
3 times, most recently
from
September 3, 2026 21:07
c264c4e to
25ada3b
Compare
…-alignment fix(ui): align short filters and hide inactive scrollbars
…vel-order-by fix(sqlserver): detect top-level pagination ordering
…-post-only fix(datasource): require POST to close connections
…nstance-startup fix(desktop): claim the instance before application startup
* fix(result): lazy-load large text values * chore(result): use English JSON diagnostics
…river-download fix(frontend): restore driver download and copy icon
# Conflicts: # chat2db-community-client/package.json
…primary-key fix(sql): resolve primary keys through single-table subqueries
…ingle-row-2483 fix(cockroachdb): limit no-key row updates and deletes natively
…rt-batch1-fast-mode feat(import): add optional parallel CSV import
…ap-beta feat(desktop): unify package layout and enable beta updates
fix(storage): publish ER position after persistence
…e-rollback fix(ai): roll back failed history deletion
…nc-position-2479 fix(storage): synchronize NamespaceStorage position mutations
…c-write fix(ai): write chat history atomically
…s-signing-argv fix(ci): preserve quoted Windows signing commands
…entials-2472 chore(ipc): redact credentials in debug IPC request/response logs
…single-flight fix(mcp): serialize token resets
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (!target.getParent().equals(stagingDirectory)) { | ||
| throw new IOException("invalid staging target"); | ||
| } | ||
| Files.copy(source, target, StandardCopyOption.REPLACE_EXISTING); |
| if (!target.getParent().equals(stagingDirectory)) { | ||
| throw new IOException("invalid staging target"); | ||
| } | ||
| Files.copy(source, target, StandardCopyOption.REPLACE_EXISTING); |
| } | ||
|
|
||
| private static void validateSource(File file, String originalFileName) { | ||
| if (file == null || !file.isFile() || !file.canRead() || file.length() > MAX_SIZE_BYTES |
| } | ||
|
|
||
| private static void validateSource(File file, String originalFileName) { | ||
| if (file == null || !file.isFile() || !file.canRead() || file.length() > MAX_SIZE_BYTES |
|
|
||
| private static void deleteQuietly(Path path) { | ||
| try { | ||
| Files.deleteIfExists(path); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A - no matching issue was found.
Summary
Namespace datasource-position operations mutated live
datasourceIdslists before persistence. A write failure left memory moved/deleted while disk and reload state remained old. This change deep-copies the complete namespace map, persists the candidate first, publishes one volatile map reference, and preserves null namespace as move-to-root.Affected surfaces
Verification
Risk and compatibility
Reviewer map
NamespaceStorage.copyDataMap/persistPositionsand atomic-write tests.25ada3b790c0649857cb733aa4caa792f4ccb2ef; no migration is required.Contributor declaration
AI assistance: OpenAI Codex assisted with diagnosis, implementation, deterministic tests, verification, and adversarial review.
Latest-main revalidation (2026-09-04)