Skip to content

chore(deps): Update rocksdb-js to 2.8.0 - #2324

Closed
harperfastbot[bot] wants to merge 1 commit into
mainfrom
update-rocksdb-js
Closed

harperfastbot[bot] wants to merge 1 commit into
mainfrom
update-rocksdb-js

Conversation

@harperfastbot

@harperfastbot harperfastbot Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​harperfast/​rocksdb-js@​2.7.1 ⏵ 2.8.095 +1910010099100

View full report

Comment thread package.json
"@fastify/static": "^9.1.3",
"@harperfast/extended-iterable": "1.0.3",
"@harperfast/rocksdb-js": "2.7.1",
"@harperfast/rocksdb-js": "2.8.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical: this bump breaks the msgpackr/rocksdb-js single-module-instance invariant — and CI is already red because of it

@harperfast/rocksdb-js 2.8.0 bumped its own msgpackr dependency from 2.0.5 to 2.0.6 (rocksdb-js#796). This PR bumps only the rocksdb-js side; the root msgpackr pin (package.json line 226) stays at 2.0.5. Since both are exact pins, npm can no longer dedupe them — npm ci now installs a second, separate copy at node_modules/@harperfast/rocksdb-js/node_modules/msgpackr@2.0.6 (confirmed locally).

This is exactly the failure mode 058ba377b ("Pin the load-bearing native and encoder dependencies", #2179) made these pins exact to prevent: "msgpackr has the same shape [as the extended-iterable phantom-SKIP bug] via its extension registry, where the nested copy never saw addExtension for Blob." resources/blob.ts calls addExtension() on the root-resolved msgpackr module to register Blob's extension type; a second, independently-required msgpackr instance inside rocksdb-js never sees that registration — silently, with "no exception and no log line" per that commit's own description.

The Docker smoke test is the guardrail built specifically for this and is currently failing on this PR:

##[error]the root msgpackr pin 2.0.5 does not match rocksdb-js 2.0.6 -- update these pins together to preserve one module instance

(smoke (linux/amd64, ubuntu-latest), currently FAILURE on this PR)

Suggested fix: bump the root msgpackr pin to 2.0.6 alongside the rocksdb-js bump (package.json:226), then regenerate package-lock.json so the nested copy collapses back into the single deduped root instance.

—
Generated by Barber AI

@kriszyp kriszyp closed this Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants