Skip to content

chore(deps): Update rocksdb-js to 2.8.0 #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
harperfastbot wants to merge 1 commit into from
Closed

chore(deps): Update rocksdb-js to 2.8.0 #2324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 46 additions & 37 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@
"@fastify/cors": "^11.2.0",
"@fastify/static": "^9.1.3",
"@harperfast/extended-iterable": "1.0.3",
"@harperfast/rocksdb-js": "2.7.1",
"@harperfast/rocksdb-js": "2.8.0",

@cb1kenobi cb1kenobi Aug 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical: this bump breaks the msgpackr/rocksdb-js single-module-instance invariant — and CI is already red because of it

@harperfast/rocksdb-js 2.8.0 bumped its own msgpackr dependency from 2.0.5 to 2.0.6 (rocksdb-js#796). This PR bumps only the rocksdb-js side; the root msgpackr pin (package.json line 226) stays at 2.0.5. Since both are exact pins, npm can no longer dedupe them — npm ci now installs a second, separate copy at node_modules/@harperfast/rocksdb-js/node_modules/msgpackr@2.0.6 (confirmed locally).

This is exactly the failure mode 058ba377b ("Pin the load-bearing native and encoder dependencies", #2179) made these pins exact to prevent: "msgpackr has the same shape [as the extended-iterable phantom-SKIP bug] via its extension registry, where the nested copy never saw addExtension for Blob." resources/blob.ts calls addExtension() on the root-resolved msgpackr module to register Blob's extension type; a second, independently-required msgpackr instance inside rocksdb-js never sees that registration — silently, with "no exception and no log line" per that commit's own description.

The Docker smoke test is the guardrail built specifically for this and is currently failing on this PR:

##[error]the root msgpackr pin 2.0.5 does not match rocksdb-js 2.0.6 -- update these pins together to preserve one module instance

(smoke (linux/amd64, ubuntu-latest), currently FAILURE on this PR)

Suggested fix: bump the root msgpackr pin to 2.0.6 alongside the rocksdb-js bump (package.json:226), then regenerate package-lock.json so the nested copy collapses back into the single deduped root instance.

—
Generated by Barber AI

"@harperfast/skills": "^1.10.8",
"@turf/area": "6.5.0",
"@turf/boolean-contains": "6.5.0",
Expand Down
Loading