Adopt promoted quadraui helpers: driver tab geometry + SidebarSystem reveal

[JDonaghy]

What

Delete vimcode's private tab_center / tab_close_center test helpers and consume the promoted
quadraui versions (quadraui #594). Likewise re-express explorer_reveal_path on top of
SidebarSystem::reveal / TreeController::reveal (quadraui #595).

Why now

Both helpers were written here first and were promoted into quadraui because they are generic —
src/gtk/testing.rs:130-160 is the literal source for quadraui #594, and
src/core/engine/explorer_ops.rs:75-91 is the reference composition for quadraui #595.

Promotion without migration is the worst outcome: the logic now exists twice, and the copy that
gets fixed is whichever one the next bug happens to land in. coord-tui will consume the quadraui
versions from day one, so leaving vimcode on its originals guarantees divergence between the two
apps this framework exists to unify.

Design

Test harness (quadraui #594):

• Remove tab_center and tab_close_center from src/gtk/testing.rs.
• Point callers at the driver-provided versions, keyed by the tab bar's WidgetId rather than
  vimcode's GroupId — a mechanical translation at each call site.
• The None-when-no-close-button case (#448-F: GTK tab click (activate/close) dead when only ONE tab group exists #553) is preserved by the quadraui version; assert it still
  holds.

Reveal (quadraui #595):

• explorer_reveal_path keeps its vimcode-specific half — resolving a filesystem path to ancestors
  and expanding them — and delegates the select-and-scroll half to the shared reveal.
• Its existing behaviour is the contract: expand ancestors, rebuild rows, select, scroll into view.

Acceptance criteria

• src/gtk/testing.rs contains no tab-geometry arithmetic of its own.
• Every test that previously called the local helpers passes unchanged in its assertions.
• explorer_reveal_path no longer calls TreeController::scroll_to_visible directly.
• Revealing a file below the fold still scrolls it into view (existing behaviour, existing tests).
• cargo build && cargo test EXIT=0.

Files

• src/gtk/testing.rs
• src/core/engine/explorer_ops.rs
• Cargo.toml (quadraui pin bump, separate commit)

Depends on

quadraui #594 (driver tab geometry) and quadraui #595 (SidebarSystem::reveal).

Out of scope

• Behaviour changes to reveal or to the harness.
• The preview-tier migration, filed separately.

[JDonaghy]

Coordinator Assignment

Machine: dellserver
Repo: vimcode
Files: (unspecified)
Do not touch: (nothing else in flight)

Briefing

Issue #659: Adopt promoted quadraui helpers: driver tab geometry + SidebarSystem reveal

What

Delete vimcode's private tab_center / tab_close_center test helpers and consume the promoted
quadraui versions (quadraui #594). Likewise re-express explorer_reveal_path on top of
SidebarSystem::reveal / TreeController::reveal (quadraui #595).

Why now

Both helpers were written here first and were promoted into quadraui because they are generic —
src/gtk/testing.rs:130-160 is the literal source for quadraui #594, and
src/core/engine/explorer_ops.rs:75-91 is the reference composition for quadraui #595.

Promotion without migration is the worst outcome: the logic now exists twice, and the copy that
gets fixed is whichever one the next bug happens to land in. coord-tui will consume the quadraui
versions from day one, so leaving vimcode on its originals guarantees divergence between the two
apps this framework exists to unify.

Design

Test harness (quadraui #594):

• Remove tab_center and tab_close_center from src/gtk/testing.rs.
• Point callers at the driver-provided versions, keyed by the tab bar's WidgetId rather than
  vimcode's GroupId — a mechanical translation at each call site.
• The None-when-no-close-button case (#448-F: GTK tab click (activate/close) dead when only ONE tab group exists #553) is preserved by the quadraui version; assert it still
  holds.

Reveal (quadraui #595):

• explorer_reveal_path keeps its vimcode-specific half — resolving a filesystem path to ancestors
  and expanding them — and delegates the select-and-scroll half to the shared reveal.
• Its existing behaviour is the contract: expand ancestors, rebuild rows, select, scroll into view.

Acceptance criteria

• src/gtk/testing.rs contains no tab-geometry arithmetic of its own.
• Every test that previously called the local helpers passes unchanged in its assertions.
• explorer_reveal_path no longer calls TreeController::scroll_to_visible directly.
• Revealing a file below the fold still scrolls it into view (existing behaviour, existing tests).
• cargo build && cargo test EXIT=0.

Files

• src/gtk/testing.rs
• src/core/engine/explorer_ops.rs
• Cargo.toml (quadraui pin bump, separate commit)

Depends on

quadraui #594 (driver tab geometry) and quadraui #595 (SidebarSystem::reveal).

Out of scope

• Behaviour changes to reveal or to the harness.
• The preview-tier migration, filed separately.

[JDonaghy]

Coordinator: Assignment Failed

Machine: dellserver
Status: failed
Exit code: —
Duration: —
Log: /home/john/.coord/logs/4e89e96a8b6f.log

Error

pull failed for quadraui: git pull --ff-only failed: You are not currently on a branch.
Please specify which branch you want to merge with.
See git-pull(1) for details.

git pull <remote> <branch>

[JDonaghy]

Coordinator: Assignment Complete

Machine: precision
Status: done
Exit code: 0
Duration: 18m 54s
Log: /home/john/.coord/logs/e5667ccbe2a7.log

[JDonaghy]

Coordinator: Assignment Complete

Machine: precision
Status: done
Exit code: 0
Duration: 2m 11s
Log: /home/john/.coord/logs/12c64a12fa7c.log

[JDonaghy]

Coordinator Assignment

Machine: precision
Repo: vimcode
Files: (unspecified)
Do not touch: (nothing else in flight)

Briefing

You are fixing a failed smoke test for issue #659: [retry] Adopt promoted quadraui helpers: driver tab geometry + SidebarSystem reveal

The previous worker created branch issue-659-adopt-promoted-quadraui-helpers-driver-t. You are already on that branch.
Do NOT start over — work from the existing code.

What was done

The previous worker's changes are already committed on this branch.
Run git fetch origin && git log --oneline origin/develop..HEAD to see what was done.
Run git diff origin/develop...HEAD to see the full diff.

Test failure

…(truncated)…
etry-adopt-promoted-quadraui-help/target/debug/build/vimcode-9b71b45e50474003/build-script-build` (exit status: 101)
--- stdout
OUT_DIR = Some(/home/john/.coord/confirm-worktrees/vimcode-issue-659-smoke-retry-adopt-promoted-quadraui-help/target/debug/build/vimcode-e5fe5ce32734b9d7/out)
OPT_LEVEL = Some(0)
TARGET = Some(x86_64-unknown-linux-gnu)
CARGO_ENCODED_RUSTFLAGS = Some()
HOST = Some(x86_64-unknown-linux-gnu)
cargo:rerun-if-env-changed=CC_x86_64-unknown-linux-gnu
CC_x86_64-unknown-linux-gnu = None
cargo:rerun-if-env-changed=CC_x86_64_unknown_linux_gnu
CC_x86_64_unknown_linux_gnu = None
cargo:rerun-if-env-changed=HOST_CC
HOST_CC = None
cargo:rerun-if-env-changed=CC
CC = None
cargo:rerun-if-env-changed=CC_ENABLE_DEBUG_OUTPUT
RUSTC_WRAPPER = None
cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
CRATE_CC_NO_DEFAULTS = None
DEBUG = Some(true)
CARGO_CFG_TARGET_FEATURE = Some(fxsr,sse,sse2)
cargo:rerun-if-env-changed=CFLAGS
CFLAGS = None
cargo:rerun-if-env-changed=HOST_CFLAGS
HOST_CFLAGS = None
cargo:rerun-if-env-changed=CFLAGS_x86_64_unknown_linux_gnu
CFLAGS_x86_64_unknown_linux_gnu = None
cargo:rerun-if-env-changed=CFLAGS_x86_64-unknown-linux-gnu
CFLAGS_x86_64-unknown-linux-gnu = None
cargo:rerun-if-env-changed=AR_x86_64-unknown-linux-gnu
AR_x86_64-unknown-linux-gnu = None
cargo:rerun-if-env-changed=AR_x86_64_unknown_linux_gnu
AR_x86_64_unknown_linux_gnu = None
cargo:rerun-if-env-changed=HOST_AR
HOST_AR = None
cargo:rerun-if-env-changed=AR
AR = None
cargo:rerun-if-env-changed=ARFLAGS
ARFLAGS = None
cargo:rerun-if-env-changed=HOST_ARFLAGS
HOST_ARFLAGS = None
cargo:rerun-if-env-changed=ARFLAGS_x86_64_unknown_linux_gnu
ARFLAGS_x86_64_unknown_linux_gnu = None
cargo:rerun-if-env-changed=ARFLAGS_x86_64-unknown-linux-gnu
ARFLAGS_x86_64-unknown-linux-gnu = None
cargo:rustc-link-lib=static=tree_sitter_latex
cargo:rustc-link-search=native=/home/john/.coord/confirm-worktrees/vimcode-issue-659-smoke-retry-adopt-promoted-quadraui-help/target/debug/build/vimcode-e5fe5ce32734b9d7/out
cargo:rerun-if-changed=/home/john/.coord/confirm-worktrees/vimcode-issue-659-smoke-retry-adopt-promoted-quadraui-help/quadraui-pin.txt
cargo:rerun-if-env-changed=VIMCODE_QUADRAUI_UNPINNED
cargo:rustc-env=VIMCODE_QUADRAUI_PINNED_REV=3ad869a89f10bf324f6b9ead33f4ad6ce7d203b8
cargo:rerun-if-changed=/home/john/src/quadraui/.git/HEAD
cargo:rerun-if-changed=/home/john/src/quadraui/.git/packed-refs
cargo:rustc-env=VIMCODE_QUADRAUI_REV=f6d27c239203e28525ac1798d07a31a9dbe9729a

--- stderr

thread 'main' (1288068) panicked at build.rs:227:5:

┌─ QUADRAUI PIN MISMATCH (issue #638) ───────────────────────────────
│ vimcode is pinned to a specific quadraui commit, but the sibling
│ checkout is on a different one. quadraui is a path dependency, so
│ Cargo.lock cannot pin it and this difference would otherwise change
│ vimcode's behaviour with no vimcode commit to explain it (#625).
│
│ pinned (quadraui-pin.txt): 3ad869a89f10bf324f6b9ead33f4ad6ce7d203b8
│ checkout HEAD: f6d27c239203e28525ac1798d07a31a9dbe9729a
│ checkout path: /home/john/src/quadraui/quadraui
│
│ Pick one:
│
│ 1. Build against the pin (normal case):
│ git -C ../quadraui fetch origin
│ git -C ../quadraui checkout 3ad869a89f10bf324f6b9ead33f4ad6ce7d203b8
│
│ 2. Bump the pin deliberately, then run the tests so any rendering
│ change lands as a reviewable, attributable commit:
│ # put the new sha in quadraui-pin.txt
│ cargo test
│
│ 3. Co-developing quadraui? Opt out for this build only:
│ VIMCODE_QUADRAUI_UNPINNED=1 cargo build
│ (Uncommitted edits at the pinned rev need no opt-out.)
└────────────────────────────────────────────────────────────────────

note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...

Guidance

Fix the failing tests and push.

Rules

• Do NOT start over or rewrite from scratch
• Fix the specific test failures
• Commit your fixes and push with git push origin HEAD