Repository navigation
fix(triage): make main's CI green again after the triage gate - #964
Merged
Merged
Conversation
Two things #960 left behind that only CI saw: - `IncidentTriageUnauthorizedError` is a 4xx error, so it belongs in the generated anticipated-error list; the drift test caught the stale output. Regenerated. - `typecheck-api` sees a `fetch` type with `preconnect` on it, so a binding fetch annotated as `typeof globalThis.fetch` does not typecheck there. The classifier now builds its HttpClient straight over the service binding with alchemy's `fromCloudflareFetcher` + `toHttpClient`, the same adapter the api Worker forwards to maple-ai with, and drops the Fetch-service detour.
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Makisuo
added a commit
that referenced
this pull request
Sep 21, 2026
…tics-integration Takes main's #964 fixes for the triage gate: its binding transport replaces the fetch shim this branch had typed, and its regenerated error identifiers match ours. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#960 merged with CI red, so the deployment gate has refused every deploy since (
Nothing was deployed: CI did not pass). Prod is still on the commit before it: the Jev triage gate, #959 and #962 are all undeployed.What
IncidentTriageUnauthorizedErroris 4xx-annotated, soanticipated-errors.test.tsexpected it ingenerated/anticipated-error-identifiers.ts. Regenerated withgen:anticipated-errors.typecheck-apiresolvestypeof globalThis.fetchto a type that carriespreconnect, so the classifier'sfetchOverBindingfailed TS2741 there.IncidentClassifiernow builds itsHttpClientdirectly over theAI_WORKERbinding withfromCloudflareFetcher+toHttpClient, the adapterapps/apialready uses to forward to maple-ai. TheFetchHttpClient.Fetchdetour and the layer'sFetchHttpClient.layerdependency go away.Verified
IncidentClassifier.test.tsandanticipated-errors.test.tspass.typecheckgreen forpackages/backend,apps/api(the failing job) andapps/alerting.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.