Skip to content

feat(ramps-controller): migrate NeoBankService to BaseDataService - #10882

Merged
cryptodev-2s merged 11 commits into
mainfrom
feat/neo-bank-service-base-data-service
Nov 3, 2026
Merged

cryptodev-2s merged 11 commits into
mainfrom
feat/neo-bank-service-base-data-service

Conversation

@cryptodev-2s

@cryptodev-2s cryptodev-2s commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Explanation

Moves NeoBankService onto BaseDataService; reads and writes now share one circuit breaker.
Reads always refetch (staleTime of 0), and only concurrent identical calls share one request.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

High Risk
Breaking API and resilience behavior (removed policy hooks, unified circuit breaker that can block writes after read failures, new error strings) affects all NeoBank ramp flows and hosts that wired messengers or error handling to the old service.

Overview
NeoBankService is rebuilt on BaseDataService, so reads and writes share one circuit breaker and retry policy instead of separate read vs no-retry POST policies. Hosts gain messenger NeoBankService:invalidateQueries and cacheUpdated / granular cache events; onRetry, onBreak, and onDegraded are removed.

Neo-bank GETs and idempotent-style reads go through fetchQuery with staleTime/gcTime of 0 (every sequential call hits the API) while concurrent identical calls are deduplicated; getAutoramps paginates with one query key per cursor page. POST-style methods use executeMutation without automatic retries on 5xx. Responses are validated with @metamask/superstruct structs, and malformed bodies now throw Query function for "NeoBankService:…" / Mutation function for "NeoBankService:createAutoramp" errors instead of the old neo-bank malformed messages. Several quote/customer helpers now return Promise<Json> instead of Promise<unknown>.

Package adds @metamask/base-data-service and @metamask/superstruct, exports the new messenger types, and expands tests for deduplication, cache events, and mutation/query behavior.

Reviewed by Cursor Bugbot for commit 0e1860a. Bugbot is set up for automated code reviews on this repo. Configure here.

@cryptodev-2s cryptodev-2s self-assigned this Oct 19, 2026
@cryptodev-2s
cryptodev-2s force-pushed the feat/neo-bank-service-base-data-service branch from f52b860 to 2e2eed4 Compare October 19, 2026 12:34
@cryptodev-2s
cryptodev-2s marked this pull request as ready for review October 28, 2026 13:39
@cryptodev-2s
cryptodev-2s requested review from a team as code owners October 28, 2026 13:39
@cryptodev-2s

Copy link
Copy Markdown
Contributor Author

@metamaskbot publish-preview

@amitabh94

Copy link
Copy Markdown
Contributor

Can we please trigger a RC mobile build based on this PR since this is high risk change and we are very close to launching to users?

Would be great if you can add the video of the VBA feature or reach out to someone from the money movement team to help test this?

@cryptodev-2s

Copy link
Copy Markdown
Contributor Author

Can we please trigger a RC mobile build based on this PR since this is high risk change and we are very close to launching to users?

Would be great if you can add the video of the VBA feature or reach out to someone from the money movement team to help test this?

Yes in progress thats why I have generated the preview build above your comment will keep you posted.

@github-actions

Copy link
Copy Markdown
Contributor

Preview builds have been published. Learn how to use preview builds in other projects.

Expand for full list of packages and versions.
@metamask-previews/account-tree-controller@11.2.0-preview-bc2a298b8
@metamask-previews/accounts-controller@40.1.0-preview-bc2a298b8
@metamask-previews/address-book-controller@8.0.0-preview-bc2a298b8
@metamask-previews/advanced-chart-core@1.0.0-preview-bc2a298b8
@metamask-previews/ai-controllers@2.0.0-preview-bc2a298b8
@metamask-previews/analytics-controller@4.1.0-preview-bc2a298b8
@metamask-previews/analytics-data-regulation-controller@0.0.0-preview-bc2a298b8
@metamask-previews/announcement-controller@9.0.0-preview-bc2a298b8
@metamask-previews/app-metadata-controller@3.0.0-preview-bc2a298b8
@metamask-previews/approval-controller@10.0.0-preview-bc2a298b8
@metamask-previews/assets-controller@20.0.1-preview-bc2a298b8
@metamask-previews/assets-controllers@113.0.0-preview-bc2a298b8
@metamask-previews/authenticated-user-storage@4.1.0-preview-bc2a298b8
@metamask-previews/base-controller@10.1.0-preview-bc2a298b8
@metamask-previews/base-data-service@2.1.0-preview-bc2a298b8
@metamask-previews/bitcoin-regtest-up@2.0.0-preview-bc2a298b8
@metamask-previews/bridge-controller@83.1.2-preview-bc2a298b8
@metamask-previews/bridge-status-controller@78.0.0-preview-bc2a298b8
@metamask-previews/build-utils@4.0.0-preview-bc2a298b8
@metamask-previews/byte-utils@0.1.0-preview-bc2a298b8
@metamask-previews/chain-agnostic-permission@2.1.0-preview-bc2a298b8
@metamask-previews/chomp-api-service@7.0.0-preview-bc2a298b8
@metamask-previews/claims-controller@1.1.0-preview-bc2a298b8
@metamask-previews/client-controller@2.0.0-preview-bc2a298b8
@metamask-previews/client-utils@3.0.4-preview-bc2a298b8
@metamask-previews/compliance-controller@3.0.0-preview-bc2a298b8
@metamask-previews/composable-controller@13.0.0-preview-bc2a298b8
@metamask-previews/config-registry-controller@5.0.0-preview-bc2a298b8
@metamask-previews/connectivity-controller@1.0.0-preview-bc2a298b8
@metamask-previews/controller-utils@13.0.0-preview-bc2a298b8
@metamask-previews/core-backend@12.3.0-preview-bc2a298b8
@metamask-previews/cryptography@1.1.2-preview-bc2a298b8
@metamask-previews/delegation-controller@4.0.0-preview-bc2a298b8
@metamask-previews/earn-controller@13.0.2-preview-bc2a298b8
@metamask-previews/eip-5792-middleware@4.0.1-preview-bc2a298b8
@metamask-previews/eip-7702-internal-rpc-middleware@1.0.0-preview-bc2a298b8
@metamask-previews/eip1193-permission-middleware@3.0.0-preview-bc2a298b8
@metamask-previews/error-utils@0.1.0-preview-bc2a298b8
@metamask-previews/eth-block-tracker@16.0.0-preview-bc2a298b8
@metamask-previews/eth-json-rpc-middleware@26.0.0-preview-bc2a298b8
@metamask-previews/eth-json-rpc-provider@7.0.0-preview-bc2a298b8
@metamask-previews/foundryup@2.0.0-preview-bc2a298b8
@metamask-previews/gas-fee-controller@27.0.0-preview-bc2a298b8
@metamask-previews/gator-permissions-controller@6.0.1-preview-bc2a298b8
@metamask-previews/geolocation-controller@2.0.0-preview-bc2a298b8
@metamask-previews/java-tron-up@2.0.0-preview-bc2a298b8
@metamask-previews/json-rpc-engine@11.0.0-preview-bc2a298b8
@metamask-previews/json-rpc-middleware-stream@9.0.0-preview-bc2a298b8
@metamask-previews/keyring-controller@28.2.0-preview-bc2a298b8
@metamask-previews/kyc-controller@0.13.0-preview-bc2a298b8
@metamask-previews/local-node-utils@2.0.0-preview-bc2a298b8
@metamask-previews/logging-controller@10.0.0-preview-bc2a298b8
@metamask-previews/marketing-consent-controller@1.1.0-preview-bc2a298b8
@metamask-previews/message-manager@15.0.0-preview-bc2a298b8
@metamask-previews/messenger@3.0.0-preview-bc2a298b8
@metamask-previews/messenger-cli@1.0.0-preview-bc2a298b8
@metamask-previews/mfa-recovery-controller@0.0.0-preview-bc2a298b8
@metamask-previews/money-account-api-data-service@2.3.1-preview-bc2a298b8
@metamask-previews/money-account-balance-service@3.1.2-preview-bc2a298b8
@metamask-previews/money-account-controller@3.0.0-preview-bc2a298b8
@metamask-previews/money-account-mfa-whitelist@0.1.0-preview-bc2a298b8
@metamask-previews/money-account-upgrade-controller@6.0.0-preview-bc2a298b8
@metamask-previews/money-account-utils@2.1.0-preview-bc2a298b8
@metamask-previews/multichain-account-service@14.1.0-preview-bc2a298b8
@metamask-previews/multichain-api-middleware@5.0.0-preview-bc2a298b8
@metamask-previews/multichain-network-controller@4.0.0-preview-bc2a298b8
@metamask-previews/multichain-transactions-controller@8.0.0-preview-bc2a298b8
@metamask-previews/name-controller@10.0.0-preview-bc2a298b8
@metamask-previews/network-connection-banner-controller@1.0.0-preview-bc2a298b8
@metamask-previews/network-controller@37.1.1-preview-bc2a298b8
@metamask-previews/network-enablement-controller@7.0.2-preview-bc2a298b8
@metamask-previews/node-utils@0.1.0-preview-bc2a298b8
@metamask-previews/notification-services-controller@30.1.0-preview-bc2a298b8
@metamask-previews/passkey-controller@4.1.0-preview-bc2a298b8
@metamask-previews/permission-controller@14.1.0-preview-bc2a298b8
@metamask-previews/permission-log-controller@6.0.0-preview-bc2a298b8
@metamask-previews/perps-controller@22.0.0-preview-bc2a298b8
@metamask-previews/phishing-controller@18.2.1-preview-bc2a298b8
@metamask-previews/platform-api-docs@0.2.1-preview-bc2a298b8
@metamask-previews/polling-controller@17.0.0-preview-bc2a298b8
@metamask-previews/preferences-controller@24.0.0-preview-bc2a298b8
@metamask-previews/profile-controller@1.2.0-preview-bc2a298b8
@metamask-previews/profile-metrics-controller@5.2.0-preview-bc2a298b8
@metamask-previews/profile-sync-controller@36.0.0-preview-bc2a298b8
@metamask-previews/ramps-controller@28.0.0-preview-bc2a298b8
@metamask-previews/rate-limit-controller@8.0.0-preview-bc2a298b8
@metamask-previews/react-data-query@2.0.0-preview-bc2a298b8
@metamask-previews/remote-feature-flag-controller@7.0.0-preview-bc2a298b8
@metamask-previews/sample-controllers@6.0.0-preview-bc2a298b8
@metamask-previews/seedless-onboarding-controller@12.0.0-preview-bc2a298b8
@metamask-previews/selected-network-controller@27.0.0-preview-bc2a298b8
@metamask-previews/sentinel-api-service@2.1.0-preview-bc2a298b8
@metamask-previews/shield-controller@7.1.0-preview-bc2a298b8
@metamask-previews/signature-controller@40.0.0-preview-bc2a298b8
@metamask-previews/smart-transactions-controller@27.2.0-preview-bc2a298b8
@metamask-previews/snap-account-service@4.0.0-preview-bc2a298b8
@metamask-previews/social-controllers@3.13.0-preview-bc2a298b8
@metamask-previews/solana-test-validator-up@2.0.0-preview-bc2a298b8
@metamask-previews/stellar-quickstart-up@0.0.0-preview-bc2a298b8
@metamask-previews/storage-service@2.0.0-preview-bc2a298b8
@metamask-previews/subscription-controller@15.1.1-preview-bc2a298b8
@metamask-previews/transaction-controller@72.3.0-preview-bc2a298b8
@metamask-previews/transaction-pay-controller@30.3.1-preview-bc2a298b8
@metamask-previews/transaction-pay-middleware@2.0.0-preview-bc2a298b8
@metamask-previews/type-utils@0.1.0-preview-bc2a298b8
@metamask-previews/user-operation-controller@42.0.1-preview-bc2a298b8
@metamask-previews/utils@12.0.1-preview-bc2a298b8
@metamask-previews/wallet@20.0.0-preview-bc2a298b8
@metamask-previews/watch-only-account-service@0.1.0-preview-bc2a298b8

Comment thread packages/ramps-controller/CHANGELOG.md Resolved
Comment thread packages/ramps-controller/CHANGELOG.md Resolved
Comment thread packages/ramps-controller/CHANGELOG.md Resolved
Comment thread packages/ramps-controller/CHANGELOG.md Resolved
@cryptodev-2s

Copy link
Copy Markdown
Contributor Author

@metamaskbot publish-preview

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Preview builds have been published. Learn how to use preview builds in other projects.

Expand for full list of packages and versions.
@metamask-previews/account-tree-controller@11.2.0-preview-437c75983
@metamask-previews/accounts-controller@40.1.0-preview-437c75983
@metamask-previews/address-book-controller@8.0.0-preview-437c75983
@metamask-previews/advanced-chart-core@1.0.0-preview-437c75983
@metamask-previews/ai-controllers@2.0.0-preview-437c75983
@metamask-previews/analytics-controller@4.1.0-preview-437c75983
@metamask-previews/analytics-data-regulation-controller@0.0.0-preview-437c75983
@metamask-previews/announcement-controller@9.0.0-preview-437c75983
@metamask-previews/app-metadata-controller@3.0.0-preview-437c75983
@metamask-previews/approval-controller@10.0.0-preview-437c75983
@metamask-previews/assets-controller@20.1.0-preview-437c75983
@metamask-previews/assets-controllers@113.0.1-preview-437c75983
@metamask-previews/authenticated-user-storage@4.1.0-preview-437c75983
@metamask-previews/base-controller@10.1.0-preview-437c75983
@metamask-previews/base-data-service@2.1.0-preview-437c75983
@metamask-previews/bitcoin-regtest-up@2.0.0-preview-437c75983
@metamask-previews/bridge-controller@83.1.3-preview-437c75983
@metamask-previews/bridge-status-controller@78.0.1-preview-437c75983
@metamask-previews/build-utils@4.0.0-preview-437c75983
@metamask-previews/byte-utils@0.1.0-preview-437c75983
@metamask-previews/chain-agnostic-permission@2.1.0-preview-437c75983
@metamask-previews/chomp-api-service@7.0.0-preview-437c75983
@metamask-previews/claims-controller@1.1.0-preview-437c75983
@metamask-previews/client-controller@2.0.0-preview-437c75983
@metamask-previews/client-utils@3.1.0-preview-437c75983
@metamask-previews/compliance-controller@3.0.0-preview-437c75983
@metamask-previews/composable-controller@13.0.0-preview-437c75983
@metamask-previews/config-registry-controller@5.0.0-preview-437c75983
@metamask-previews/connectivity-controller@1.0.0-preview-437c75983
@metamask-previews/controller-utils@13.0.0-preview-437c75983
@metamask-previews/core-backend@13.0.0-preview-437c75983
@metamask-previews/cryptography@1.1.2-preview-437c75983
@metamask-previews/delegation-controller@4.0.0-preview-437c75983
@metamask-previews/earn-controller@13.0.2-preview-437c75983
@metamask-previews/eip-5792-middleware@4.1.0-preview-437c75983
@metamask-previews/eip-7702-internal-rpc-middleware@1.0.0-preview-437c75983
@metamask-previews/eip1193-permission-middleware@3.0.0-preview-437c75983
@metamask-previews/error-utils@0.1.0-preview-437c75983
@metamask-previews/eth-block-tracker@16.0.0-preview-437c75983
@metamask-previews/eth-json-rpc-middleware@26.0.0-preview-437c75983
@metamask-previews/eth-json-rpc-provider@7.0.0-preview-437c75983
@metamask-previews/foundryup@2.0.0-preview-437c75983
@metamask-previews/gas-fee-controller@27.0.0-preview-437c75983
@metamask-previews/gator-permissions-controller@6.1.0-preview-437c75983
@metamask-previews/geolocation-controller@2.0.0-preview-437c75983
@metamask-previews/java-tron-up@2.0.0-preview-437c75983
@metamask-previews/json-rpc-engine@11.0.0-preview-437c75983
@metamask-previews/json-rpc-middleware-stream@9.0.0-preview-437c75983
@metamask-previews/keyring-controller@28.2.0-preview-437c75983
@metamask-previews/kyc-controller@0.14.0-preview-437c75983
@metamask-previews/local-node-utils@2.0.0-preview-437c75983
@metamask-previews/logging-controller@10.0.0-preview-437c75983
@metamask-previews/marketing-consent-controller@1.1.0-preview-437c75983
@metamask-previews/message-manager@15.0.0-preview-437c75983
@metamask-previews/messenger@3.0.0-preview-437c75983
@metamask-previews/messenger-cli@1.0.0-preview-437c75983
@metamask-previews/mfa-recovery-controller@0.0.0-preview-437c75983
@metamask-previews/money-account-api-data-service@2.3.1-preview-437c75983
@metamask-previews/money-account-balance-service@3.1.2-preview-437c75983
@metamask-previews/money-account-controller@3.0.0-preview-437c75983
@metamask-previews/money-account-lifecycle-controller@0.0.0-preview-437c75983
@metamask-previews/money-account-mfa-whitelist@0.1.0-preview-437c75983
@metamask-previews/money-account-upgrade-controller@6.0.0-preview-437c75983
@metamask-previews/money-account-utils@2.2.0-preview-437c75983
@metamask-previews/multichain-account-service@14.1.0-preview-437c75983
@metamask-previews/multichain-api-middleware@5.0.0-preview-437c75983
@metamask-previews/multichain-network-controller@4.0.0-preview-437c75983
@metamask-previews/multichain-transactions-controller@8.0.0-preview-437c75983
@metamask-previews/name-controller@10.0.0-preview-437c75983
@metamask-previews/network-connection-banner-controller@1.0.0-preview-437c75983
@metamask-previews/network-controller@37.1.1-preview-437c75983
@metamask-previews/network-enablement-controller@7.1.0-preview-437c75983
@metamask-previews/node-utils@0.1.0-preview-437c75983
@metamask-previews/notification-services-controller@30.1.0-preview-437c75983
@metamask-previews/passkey-controller@4.1.0-preview-437c75983
@metamask-previews/permission-controller@14.1.0-preview-437c75983
@metamask-previews/permission-log-controller@6.0.0-preview-437c75983
@metamask-previews/perps-controller@22.1.0-preview-437c75983
@metamask-previews/phishing-controller@18.3.0-preview-437c75983
@metamask-previews/platform-api-docs@0.2.1-preview-437c75983
@metamask-previews/polling-controller@17.0.0-preview-437c75983
@metamask-previews/preferences-controller@24.0.0-preview-437c75983
@metamask-previews/profile-controller@1.2.1-preview-437c75983
@metamask-previews/profile-metrics-controller@5.2.1-preview-437c75983
@metamask-previews/profile-sync-controller@36.0.0-preview-437c75983
@metamask-previews/ramps-controller@28.1.0-preview-437c75983
@metamask-previews/rate-limit-controller@8.0.0-preview-437c75983
@metamask-previews/react-data-query@2.0.0-preview-437c75983
@metamask-previews/remote-feature-flag-controller@7.0.0-preview-437c75983
@metamask-previews/sample-controllers@6.0.0-preview-437c75983
@metamask-previews/seedless-onboarding-controller@12.0.0-preview-437c75983
@metamask-previews/selected-network-controller@27.0.0-preview-437c75983
@metamask-previews/sentinel-api-service@2.1.0-preview-437c75983
@metamask-previews/shield-controller@7.1.1-preview-437c75983
@metamask-previews/signature-controller@40.0.0-preview-437c75983
@metamask-previews/smart-transactions-controller@27.2.1-preview-437c75983
@metamask-previews/snap-account-service@4.0.0-preview-437c75983
@metamask-previews/social-controllers@3.15.0-preview-437c75983
@metamask-previews/solana-test-validator-up@2.0.0-preview-437c75983
@metamask-previews/stellar-quickstart-up@0.0.0-preview-437c75983
@metamask-previews/storage-service@2.0.0-preview-437c75983
@metamask-previews/subscription-controller@15.1.2-preview-437c75983
@metamask-previews/transaction-controller@73.0.0-preview-437c75983
@metamask-previews/transaction-pay-controller@30.3.2-preview-437c75983
@metamask-previews/transaction-pay-middleware@2.0.1-preview-437c75983
@metamask-previews/type-utils@0.1.0-preview-437c75983
@metamask-previews/user-operation-controller@42.1.0-preview-437c75983
@metamask-previews/utils@12.0.1-preview-437c75983
@metamask-previews/wallet@21.0.0-preview-437c75983
@metamask-previews/watch-only-account-service@0.1.0-preview-437c75983

@cryptodev-2s
cryptodev-2s added this pull request to the merge queue Nov 2, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 2, 2026
@cryptodev-2s
cryptodev-2s added this pull request to the merge queue Nov 3, 2026
@cryptodev-2s
cryptodev-2s removed this pull request from the merge queue due to a manual request Nov 3, 2026
@cryptodev-2s
cryptodev-2s added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit e56f9fe Nov 3, 2026
154 of 155 checks passed
@cryptodev-2s
cryptodev-2s deleted the feat/neo-bank-service-base-data-service branch November 3, 2026 09:53
Naz-Ovh pushed a commit to 0x-fork/metamask-core that referenced this pull request Nov 4, 2026
…eased (MetaMask#11257)

## Explanation

MetaMask#10882 (migrate `NeoBankService` to `BaseDataService`) merged right
after Release 1381.0.0 (MetaMask#11248), which had already cut
`@metamask/ramps-controller` 29.0.0. Because of how the changelog
merged, the MetaMask#10882 entries ended up in the released `[29.0.0]` section,
while `[Unreleased]` was left empty.

## References

- Follow-up to MetaMask#10882
- Related to MetaMask#11248

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md)
- [ ] I've introduced [breaking
changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md)
in this PR and have prepared draft pull requests for clients and
consumer packages to resolve them

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Documentation-only changelog reorganization with no runtime or API
changes.
> 
> **Overview**
> Corrects a **Keep a Changelog** mix-up in
`packages/ramps-controller/CHANGELOG.md` after Release 1381.0.0 cut
`29.0.0` while MetaMask#10882 merged: **NeoBankService → `BaseDataService`**
notes (MetaMask#10882) were listed under **`[29.0.0]`** even though they had not
shipped yet.
> 
> This PR **moves** those MetaMask#10882 bullets (Added / Changed / Removed,
including breaking `NeoBankService` and
`RAMPS_CONTROLLER_REQUIRED_SERVICE_ACTIONS` items that belonged to that
work) back into **`[Unreleased]`**, and **leaves `[29.0.0]`** with only
what actually released there (MetaMask#11225 customer abilities /
`refreshCustomerAbilities` / deposit rail readiness, MetaMask#11243 KYC
`finalStatus`, and related fixes). **Wording is unchanged**—only section
placement.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
a2e1a1a. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: Salah-Eddine Saakoun <salah-eddinesaakoun@Salah-Eddines-MacBook-Pro-2.local>
@wenfix wenfix mentioned this pull request Nov 16, 2026
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants