Repository navigation
fix(ramps-controller): wait for final KYC approval - #11243
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
8 of 10 tasks
roz0n
force-pushed
the
fix/TRAM-4392-moonpay-limbo
branch
from
November 2, 2026 21:36
4cc1967 to
015df72
Compare
roz0n
marked this pull request as ready for review
November 2, 2026 21:37
Contributor
Author
|
@metamaskbot publish-preview |
amitabh94
approved these changes
Nov 2, 2026
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
georgeweiler
approved these changes
Nov 2, 2026
3 of 4 tasks
Naz-Ovh
pushed a commit
to 0x-fork/metamask-core
that referenced
this pull request
Nov 4, 2026
## Explanation Releases: - `@metamask/ramps-controller` @ `29.0.0` - `@metamask/transaction-pay-controller` @ `30.3.3` This release includes the VBA KYC final-status fix from MetaMask#11243 and customer rail abilities from MetaMask#11225. The major bump reflects the new required `NeoBankService:getCustomerAbilities` messenger action. ## References - MetaMask#11243 - MetaMask#11225 - Consumer update: MetaMask/metamask-mobile#38688 ## Checklist - [x] I’ve updated the test suite for new or updated code as appropriate - [x] I’ve updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I’ve communicated my changes to consumers by updating changelogs for packages I’ve changed - [x] I’ve introduced breaking changes in this PR and have prepared a draft pull request for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > The diff is low-risk versioning, but it publishes ramps-controller 29.0.0 with a breaking messenger delegation requirement that downstream clients must adopt before upgrading. > > **Overview** > This PR **cuts release 1381.0.0** by bumping versions and lockfile entries only—no application source changes in the diff. > > **`@metamask/ramps-controller`** goes **28.1.0 → 29.0.0** (major). The changelog section for **29.0.0** is finalized from `[Unreleased]`, documenting what ships with this tag: customer rail abilities APIs/state, deposit-rail readiness helpers, a **breaking** requirement to delegate **`NeoBankService:getCustomerAbilities`**, plus VBA KYC **`finalStatus`** and microdeposits session-profile fixes from earlier PRs. > > **`@metamask/transaction-pay-controller`** is patched to **30.3.3** with **`@metamask/ramps-controller` ^29.0.0** and a matching changelog entry. Root **`package.json`** moves to **1381.0.0**; **`yarn.lock`** reflects the ramps-controller resolution bump. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 1272c95. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Naz-Ovh
pushed a commit
to 0x-fork/metamask-core
that referenced
this pull request
Nov 4, 2026
…eased (MetaMask#11257) ## Explanation MetaMask#10882 (migrate `NeoBankService` to `BaseDataService`) merged right after Release 1381.0.0 (MetaMask#11248), which had already cut `@metamask/ramps-controller` 29.0.0. Because of how the changelog merged, the MetaMask#10882 entries ended up in the released `[29.0.0]` section, while `[Unreleased]` was left empty. ## References - Follow-up to MetaMask#10882 - Related to MetaMask#11248 ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Documentation-only changelog reorganization with no runtime or API changes. > > **Overview** > Corrects a **Keep a Changelog** mix-up in `packages/ramps-controller/CHANGELOG.md` after Release 1381.0.0 cut `29.0.0` while MetaMask#10882 merged: **NeoBankService → `BaseDataService`** notes (MetaMask#10882) were listed under **`[29.0.0]`** even though they had not shipped yet. > > This PR **moves** those MetaMask#10882 bullets (Added / Changed / Removed, including breaking `NeoBankService` and `RAMPS_CONTROLLER_REQUIRED_SERVICE_ACTIONS` items that belonged to that work) back into **`[Unreleased]`**, and **leaves `[29.0.0]`** with only what actually released there (MetaMask#11225 customer abilities / `refreshCustomerAbilities` / deposit rail readiness, MetaMask#11243 KYC `finalStatus`, and related fixes). **Wording is unchanged**—only section placement. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit a2e1a1a. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Salah-Eddine Saakoun <salah-eddinesaakoun@Salah-Eddines-MacBook-Pro-2.local>
weitingsun
pushed a commit
to Poovarasan-Sandhanam/metamask-mobile
that referenced
this pull request
Nov 6, 2026
…38688) ## **Description** MoonPay relay approval means document processing completed, but the provider can still be reviewing the customer. Mobile previously treated relay-side `kycStatus: approved` as terminal even when provider-side `finalStatus` remained pending, - This change keeps the KYC pending screen and Money home card active until `finalStatus` becomes terminal. - The pending card now uses the animated design-system spinner and opens the already-known pending destination immediately, without flashing a standalone loading screen. > [!NOTE] > - This PR consumes the corrected onboarding snapshot semantics from [MetaMask/core#11243](MetaMask/core#11243). > - Upgrades `@metamask/ramps-controller` to `29.0.0` and `@metamask/transaction-pay-controller` to `30.3.3` to consume the Core fix and maintain compatible dependencies. ## **Changelog** CHANGELOG entry: Fixed Money Account identity verification advancing before provider approval ## **Related issues** Refs: https://consensyssoftware.atlassian.net/browse/TRAM-4392 ## **Manual testing steps** ```gherkin Feature: Money Account provider-final KYC approval Scenario: relay approval remains pending while the provider reviews the customer Given I have submitted Money Account identity verification And the relay KYC status is approved And the provider final status is pending When I open Money Then I should see the "Verifying your identity" card And its "Verifying" indicator should animate When I tap "Verifying" Then the "Verifying your identity" screen should open immediately And I should not see an intermediate full-screen loader And status polling should continue Scenario: provider-final approval completes identity verification Given I am on the "Verifying your identity" screen When the provider final status becomes approved Then onboarding should advance from the pending state ``` ## **Screenshots/Recordings** ### **Before** N/A ### **After** https://github.com/user-attachments/assets/2d641ae3-59c4-472d-9932-18f1f1923c86 ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [x] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [x] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [x] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- Generated with the help of the pr-description AI skill --> Made with [Cursor](https://cursor.com) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Changes Money Account KYC gating and onboarding routing, which are compliance-sensitive, though behavior is narrowed to wait for provider finalization with broad test coverage. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 02c055c. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
RampsController.hydrateVbaOnboardingcurrently treats either the relay-sidekycStatusor the provider-sidefinalStatusas final KYC approval.MoonPay/Iron clarified that relay approval only represents document processing; it does not confirm that the provider has accepted the customer.
This change makes
finalStatus === 'approved'the only approval gate. A session withkycStatus: 'approved'andfinalStatus: 'pending'now stays pending and does not begin customer or autoramp setup.This intentionally supersedes the behavior introduced in #10497.
Demo with mobile changes applied:
Screen.Recording.iPhone.17.Pro.11-02-2026.at.5.23.11.PM.mp4
References
Verification
yarn workspace @metamask/ramps-controller test --run(1,128 tests)yarn workspace @metamask/ramps-controller buildyarn lint:oxlint packages/ramps-controller/src/RampsController.ts packages/ramps-controller/src/RampsController.test.tsyarn lint:misc --check packages/ramps-controller/src/RampsController.ts packages/ramps-controller/src/RampsController.test.tsChecklist
Note
Medium Risk
Changes when VBA onboarding reports KYC approved and unlocks wallet/autoramp steps, which affects money-account UX and reverses prior relay-first behavior.
Overview
VBA onboarding now treats only provider
finalStatus: 'approved'as KYC approved, reversing the behavior from #10497 where relaykycStatus: 'approved'could advance users while the vendor was still pending.resolveVbaKycStatusno longer ORs in relay approval; relay-approved sessions with a pendingfinalStatusstaykycStatus: 'pending', sohydrateVbaOnboardingreturns early and does not surfaceneeds_wallet_registrationor other post-approval autoramp states. When the provider has approved but relaykycStatusstill lags,finalStatusstill wins and onboarding can proceed.Tests and the changelog document the relay/vendor divergence cases.
Reviewed by Cursor Bugbot for commit 015df72. Bugbot is set up for automated code reviews on this repo. Configure here.