Repository navigation
fix(money-account-mfa-whitelist): stop 2FA prompts on Money deposits and MPC migration - #11310
Open
tylerc-consensys wants to merge 4 commits into
Open
tylerc-consensys wants to merge 4 commits into
tylerc-consensys wants to merge 4 commits into
Conversation
tylerc-consensys
temporarily deployed
to
default-branch
November 5, 2026 02:38 — with
GitHub Actions
Inactive
5 of 10 tasks
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7a57e44. Configure here.
…se deposit delegations Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ciation message Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…MfaWhitelistRule Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tylerc-consensys
force-pushed
the
fix/mfa-whitelist-redeemer-caveat
branch
from
November 16, 2026 09:18
7a57e44 to
6937b3a
Compare
Contributor
🛑 Files requiring codeowner reviewTo merge this PR, you'll need to get approvals from the following owners. @MetaMask/earn (7 files)
@MetaMask/core-platform (expand for more) |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
Currently the MPC Money Account flow has 2 steps prompting 2FA where we could skip it (for better UX).
1. Money deposit
Redeemercaveat, which Mobile adds for gasless relays (metamask-mobile#37041). It only narrows who can redeem; the executions are checked as before.2. Turning on 2-step verification (migration to the MPC Money Account)
ASSOCIATE_SUCCESSOR).chompSignInDomainconfig field. It only links the two addresses; moving funds still needs the old account's signature.Message signed during migration on dev:
After this is released
chompSignInDomaintoMPC_MFA_WHITELIST_CONFIG.va-mmcx-mpc-service-api): bump@metamask/money-account-mfa-whitelist(pinned at0.2.0). It runs the same check and answersmfa_requiredotherwise.va-mmcx-mpc-service-api-workload): add"chompSignInDomain": "chomp.dev-api.cx.metamask.io"toMPC_MFA_WHITELIST_CONFIG.References
Checklist
Note
Medium Risk
Changes which Money Account signatures bypass MFA; rules are narrow and fail closed, but misconfigured
chompSignInDomainor overly permissive redeemer handling could weaken protection.Overview
Reduces unnecessary 2FA during MPC Money Account migration and vault deposits by widening the MFA whitelist with tighter, config-bound checks.
Adds whitelist rule
chomp-successor-associationfor CHOMP’sASSOCIATE_SUCCESSORSIWE personal message whenchompSignInDomainis set—validates domain/URI, Money Account as signer and successor, matching predecessor in statement vs resources, chain, and freshness—so linking accounts during migration does not require MFA (funds still need the predecessor’s signature).Single-use
vault-deposit-delegationnow tolerates an optionalRedeemercaveat alongsideLimitedCalls(1), exact vault deposit execution, and an optionalTimestampdeadline (caveats in any order), matching Mobile gasless relay delegations; non-deposit executions still require MFA.Introduces shared
isFreshSignInfor SIWE expiry checks, extends config/types/docs/tests accordingly.Reviewed by Cursor Bugbot for commit 6937b3a. Bugbot is set up for automated code reviews on this repo. Configure here.