Repository navigation
test(money): check the publish hook's deposit delegation against the MPC 2FA whitelist - #38944
Closed
tylerc-consensys wants to merge 1 commit into
Closed
tylerc-consensys wants to merge 1 commit into
tylerc-consensys wants to merge 1 commit into
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…MPC 2FA whitelist Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tylerc-consensys
force-pushed
the
test/money-mfa-whitelist-ci
branch
from
November 5, 2026 08:49
c64d497 to
8e2543f
Compare
tylerc-consensys
changed the base branch from
feat/money-mfa-mpc-account
to
main
November 5, 2026 08:49
Contributor
PR template — items to address before "Ready for review"Warnings — informational, address before merging:
See docs/readme/ready-for-review.md for the full Definition of Ready for Review. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a unit test that builds the vault deposit delegation with mobile's own caveat code (
getDelegationCaveats, as the gasless 7702 publish hook does) and checks it against the Money MPC 2-step verification whitelist withgetMfaRequirement. A caveat change on mobile that the whitelist doesn't accept now fails CI instead of showing up as an unexpected 2FA prompt.MPC_MFA_WHITELIST_CONFIGlives inapp/core/MpcMoneyKeyring/mpc-mfa-whitelist-config.ts, so the MPC keyring builder and this test share it.@metamask/money-account-mfa-whitelistand transpiles it in Jest (ESM-only).The case with the Sentinel relay
Redeemercaveat fails on whitelist 0.2.0 and passes with core#11310. Merge after the version with that fix is released and pinned here.Changelog
CHANGELOG entry: null
Related issues
Refs: MetaMask/core#11310
Manual testing steps
N/A: unit test only.
Screenshots/Recordings
N/A: unit test only.
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist