Skip to content

Commit 7392fdf

Browse files
chore: bump assets-controller to ^20.2.3 (#47697)
## **Description** Bumps `@metamask/assets-controller` from `^20.2.2` to `^20.2.3`, published from the core release MetaMask/core#11326. The mobile app already took this version in MetaMask/metamask-mobile#39028. `20.2.3` is a patch release. Verified by diffing the published tarballs (20.2.2 vs 20.2.3): the only `dist/` change flips six state-metadata flags — `assetsInfo`, `assetsBalance`, `assetsPrice`, `customAssets`, `assetPreferences` and `selectedCurrency` go from `includeInStateLogs: false` to `true` ([core#11319](MetaMask/core#11319)), so asset state is included in state logs and support can investigate asset issues. Confirmed in the installed package: `node_modules/@metamask/assets-controller/dist/AssetsController.js` sets `includeInStateLogs: true` on all six fields. The `persist`, `includeInDebugSnapshot` and `usedInUi` flags are unchanged. No extension source change is needed. The extension's state logs are built from the flat background state (`memStore.getFlatState()` → UI redux `state.metamask` → downloaded state logs), and these six fields already flow through that path — UI selectors read them from `state.metamask` today — so the extension already surfaces this asset state in its logs, and the metadata flip does not change what the extension logs. The flag matters for metadata-driven clients such as mobile, which started honoring `includeInStateLogs` in MetaMask/metamask-mobile#38227 and can now drop its temporary yarn patch. Core notes this restores the pre-8.18 state-log contents and exposes nothing new. The only other change in the release is the package's `@metamask/assets-controllers` range moving from `^113.1.1` to `^113.2.0`. Extension main already depends on `@metamask/assets-controllers` `^113.2.0` directly (resolved to 113.2.0 in the lockfile), so `package.json` needs only this one bump, and Yarn resolves a single `@metamask/assets-controller@20.2.3` entry in `yarn.lock` (deduped per `yarn lint:lockfile:dedupe`). LavaMoat policies were regenerated with `yarn lavamoat:auto`: no drift, since the bump adds no new packages to the resolution. `attribution.txt` is untouched (the attributions check runs on release branches only). ## **Changelog** CHANGELOG entry: null ## **Related issues** Refs: N/A — dependency bump with no linked issue. Core release: MetaMask/core#11326. Sibling mobile bump: MetaMask/metamask-mobile#39028. Follow-up to #47609. ## **Manual testing steps** 1. Build and load this branch, then unlock a wallet that holds tokens on Ethereum Mainnet. 2. Open the home asset list and confirm symbols, balances, and fiat prices still appear. 3. In Settings → Privacy → Download state logs, confirm the downloaded JSON still includes asset state (e.g. `assetsInfo`, `assetsPrice`) and the wallet works normally. <!-- ## **Screenshots/Recordings** ### **Before** ### **After** --> ## **Adversarial review (adverse)** Final verdict (round 1/3): SHIP-WITH-CAVEATS (3/3 ship, 0/3 block) Findings: 0 critical · 2 warning · 4 info. Fixed: none (no code changes). Declined: - Balances entering shareable state logs: no change in extension state-log contents — the six fields already flow into the extension's flat-state logs today, and core#11319 states this exposes nothing new (it restores pre-8.18 mobile contents). - State-log redaction ignoring controller metadata / `includeInStateLogs` having no runtime consumer in the extension: accurate but pre-existing architecture (marked TODO in `state-utils.ts`), out of scope for a patch dependency bump; honoring the flag would be a feature change that alters state-log contents. - LavaMoat policies not regenerated: false premise — `yarn lavamoat:auto` was run and produced no diff (no new packages). - `bump:` commit type instead of `chore:`: kept `chore:` per the direct precedents #47609/#47489. ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Lockfile and patch-version dependency bump only; no extension logic changes, typical supply-chain exposure for any npm upgrade. > > **Overview** > **Bumps** `@metamask/assets-controller` from `^20.2.2` to **`^20.2.3`** in `package.json` and refreshes **`yarn.lock`**. > > The lockfile now resolves **`@metamask/assets-controller@20.2.3`** and aligns that package’s **`@metamask/assets-controllers`** dependency with **`^113.2.0`** (matching what the extension already declared), with updated checksums and a tidier dedupe entry for `assets-controllers`. > > No application source changes: this is a dependency-only patch bump (published change is mainly controller metadata such as `includeInStateLogs` for asset-related state fields). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 4640fa7. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 27e67db commit 7392fdf

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@
416416
"@metamask/analytics-controller": "^4.1.0",
417417
"@metamask/announcement-controller": "^8.0.0",
418418
"@metamask/approval-controller": "^9.0.0",
419-
"@metamask/assets-controller": "^20.2.2",
419+
"@metamask/assets-controller": "^20.2.3",
420420
"@metamask/assets-controllers": "^113.2.0",
421421
"@metamask/authenticated-user-storage": "^4.0.0",
422422
"@metamask/base-controller": "^10.0.0",

‎yarn.lock‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7390,16 +7390,16 @@ __metadata:
73907390
languageName: node
73917391
linkType: hard
73927392

7393-
"@metamask/assets-controller@npm:^20.0.1, @metamask/assets-controller@npm:^20.2.2":
7394-
version: 20.2.2
7395-
resolution: "@metamask/assets-controller@npm:20.2.2"
7393+
"@metamask/assets-controller@npm:^20.0.1, @metamask/assets-controller@npm:^20.2.2, @metamask/assets-controller@npm:^20.2.3":
7394+
version: 20.2.3
7395+
resolution: "@metamask/assets-controller@npm:20.2.3"
73967396
dependencies:
73977397
"@ethereumjs/util": "npm:^9.1.0"
73987398
"@ethersproject/abi": "npm:^5.7.0"
73997399
"@ethersproject/providers": "npm:^5.8.0"
74007400
"@metamask/account-tree-controller": "npm:^11.2.0"
74017401
"@metamask/accounts-controller": "npm:^40.1.0"
7402-
"@metamask/assets-controllers": "npm:^113.1.1"
7402+
"@metamask/assets-controllers": "npm:^113.2.0"
74037403
"@metamask/base-controller": "npm:^10.1.0"
74047404
"@metamask/client-controller": "npm:^2.0.0"
74057405
"@metamask/config-registry-controller": "npm:^5.0.0"
@@ -7425,11 +7425,11 @@ __metadata:
74257425
async-mutex: "npm:^0.5.0"
74267426
bignumber.js: "npm:^9.1.2"
74277427
lodash-es: "npm:^4.18.1"
7428-
checksum: 10/878b94d85a8b3cec8ccbe9fc8decccaaecc66702c07a6a903c8d8492524ca55345c89b28dbbf306b6995ec1fbdeae6dbb798ead33f20311113502f020e2b0746
7428+
checksum: 10/9c083b848d17b37a2c831fd56466407a90bd3c7c418742de76d8f1b6bafc5e2e9ba5b7e05f326455559b0c1f01da4a8115e072290ffe9fdb706160ed09c781a8
74297429
languageName: node
74307430
linkType: hard
74317431

7432-
"@metamask/assets-controllers@npm:^113.0.0, @metamask/assets-controllers@npm:^113.1.1, @metamask/assets-controllers@npm:^113.2.0":
7432+
"@metamask/assets-controllers@npm:^113.0.0, @metamask/assets-controllers@npm:^113.2.0":
74337433
version: 113.2.0
74347434
resolution: "@metamask/assets-controllers@npm:113.2.0"
74357435
dependencies:
@@ -35492,7 +35492,7 @@ __metadata:
3549235492
"@metamask/announcement-controller": "npm:^8.0.0"
3549335493
"@metamask/api-specs": "npm:^0.13.0"
3549435494
"@metamask/approval-controller": "npm:^9.0.0"
35495-
"@metamask/assets-controller": "npm:^20.2.2"
35495+
"@metamask/assets-controller": "npm:^20.2.3"
3549635496
"@metamask/assets-controllers": "npm:^113.2.0"
3549735497
"@metamask/authenticated-user-storage": "npm:^4.0.0"
3549835498
"@metamask/auto-changelog": "npm:^6.2.0"

0 commit comments

Comments
 (0)