Repository navigation
Commit 7392fdf
authored
chore: bump assets-controller to ^20.2.3 (#47697)
## **Description**
Bumps `@metamask/assets-controller` from `^20.2.2` to `^20.2.3`,
published from the core release
MetaMask/core#11326. The mobile app already took
this version in MetaMask/metamask-mobile#39028.
`20.2.3` is a patch release. Verified by diffing the published tarballs
(20.2.2 vs 20.2.3): the only `dist/` change flips six state-metadata
flags — `assetsInfo`, `assetsBalance`, `assetsPrice`, `customAssets`,
`assetPreferences` and `selectedCurrency` go from `includeInStateLogs:
false` to `true`
([core#11319](MetaMask/core#11319)), so asset
state is included in state logs and support can investigate asset
issues. Confirmed in the installed package:
`node_modules/@metamask/assets-controller/dist/AssetsController.js` sets
`includeInStateLogs: true` on all six fields. The `persist`,
`includeInDebugSnapshot` and `usedInUi` flags are unchanged.
No extension source change is needed. The extension's state logs are
built from the flat background state (`memStore.getFlatState()` → UI
redux `state.metamask` → downloaded state logs), and these six fields
already flow through that path — UI selectors read them from
`state.metamask` today — so the extension already surfaces this asset
state in its logs, and the metadata flip does not change what the
extension logs. The flag matters for metadata-driven clients such as
mobile, which started honoring `includeInStateLogs` in
MetaMask/metamask-mobile#38227 and can now drop
its temporary yarn patch. Core notes this restores the pre-8.18
state-log contents and exposes nothing new.
The only other change in the release is the package's
`@metamask/assets-controllers` range moving from `^113.1.1` to
`^113.2.0`. Extension main already depends on
`@metamask/assets-controllers` `^113.2.0` directly (resolved to 113.2.0
in the lockfile), so `package.json` needs only this one bump, and Yarn
resolves a single `@metamask/assets-controller@20.2.3` entry in
`yarn.lock` (deduped per `yarn lint:lockfile:dedupe`).
LavaMoat policies were regenerated with `yarn lavamoat:auto`: no drift,
since the bump adds no new packages to the resolution. `attribution.txt`
is untouched (the attributions check runs on release branches only).
## **Changelog**
CHANGELOG entry: null
## **Related issues**
Refs: N/A — dependency bump with no linked issue. Core release:
MetaMask/core#11326. Sibling mobile bump:
MetaMask/metamask-mobile#39028. Follow-up to
#47609.
## **Manual testing steps**
1. Build and load this branch, then unlock a wallet that holds tokens on
Ethereum Mainnet.
2. Open the home asset list and confirm symbols, balances, and fiat
prices still appear.
3. In Settings → Privacy → Download state logs, confirm the downloaded
JSON still includes asset state (e.g. `assetsInfo`, `assetsPrice`) and
the wallet works normally.
<!--
## **Screenshots/Recordings**
### **Before**
### **After**
-->
## **Adversarial review (adverse)**
Final verdict (round 1/3): SHIP-WITH-CAVEATS (3/3 ship, 0/3 block)
Findings: 0 critical · 2 warning · 4 info. Fixed: none (no code
changes). Declined:
- Balances entering shareable state logs: no change in extension
state-log contents — the six fields already flow into the extension's
flat-state logs today, and core#11319 states this exposes nothing new
(it restores pre-8.18 mobile contents).
- State-log redaction ignoring controller metadata /
`includeInStateLogs` having no runtime consumer in the extension:
accurate but pre-existing architecture (marked TODO in
`state-utils.ts`), out of scope for a patch dependency bump; honoring
the flag would be a feature change that alters state-log contents.
- LavaMoat policies not regenerated: false premise — `yarn
lavamoat:auto` was run and produced no diff (no new packages).
- `bump:` commit type instead of `chore:`: kept `chore:` per the direct
precedents #47609/#47489.
## **Pre-merge author checklist**
- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Low Risk**
> Lockfile and patch-version dependency bump only; no extension logic
changes, typical supply-chain exposure for any npm upgrade.
>
> **Overview**
> **Bumps** `@metamask/assets-controller` from `^20.2.2` to
**`^20.2.3`** in `package.json` and refreshes **`yarn.lock`**.
>
> The lockfile now resolves **`@metamask/assets-controller@20.2.3`** and
aligns that package’s **`@metamask/assets-controllers`** dependency with
**`^113.2.0`** (matching what the extension already declared), with
updated checksums and a tidier dedupe entry for `assets-controllers`.
>
> No application source changes: this is a dependency-only patch bump
(published change is mainly controller metadata such as
`includeInStateLogs` for asset-related state fields).
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
4640fa7. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent 27e67db commit 7392fdf
2 files changed
Lines changed: 8 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
416 | 416 | | |
417 | 417 | | |
418 | 418 | | |
419 | | - | |
| 419 | + | |
420 | 420 | | |
421 | 421 | | |
422 | 422 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7390 | 7390 | | |
7391 | 7391 | | |
7392 | 7392 | | |
7393 | | - | |
7394 | | - | |
7395 | | - | |
| 7393 | + | |
| 7394 | + | |
| 7395 | + | |
7396 | 7396 | | |
7397 | 7397 | | |
7398 | 7398 | | |
7399 | 7399 | | |
7400 | 7400 | | |
7401 | 7401 | | |
7402 | | - | |
| 7402 | + | |
7403 | 7403 | | |
7404 | 7404 | | |
7405 | 7405 | | |
| |||
7425 | 7425 | | |
7426 | 7426 | | |
7427 | 7427 | | |
7428 | | - | |
| 7428 | + | |
7429 | 7429 | | |
7430 | 7430 | | |
7431 | 7431 | | |
7432 | | - | |
| 7432 | + | |
7433 | 7433 | | |
7434 | 7434 | | |
7435 | 7435 | | |
| |||
35492 | 35492 | | |
35493 | 35493 | | |
35494 | 35494 | | |
35495 | | - | |
| 35495 | + | |
35496 | 35496 | | |
35497 | 35497 | | |
35498 | 35498 | | |
| |||
0 commit comments