Repository navigation
Integrate TokensController - #11552
Merged
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
adonesky1
force-pushed
the
token-rates-controller
branch
8 times, most recently
from
July 22, 2021 22:08
6d0e1c7 to
e2dd8a8
Compare
adonesky1
force-pushed
the
token-rates-controller
branch
from
July 26, 2021 18:18
e2dd8a8 to
b11646d
Compare
adonesky1
force-pushed
the
token-rates-controller
branch
2 times, most recently
from
July 28, 2021 21:31
1d12cb6 to
78c1477
Compare
Collaborator
Builds ready [78c1477]
Page Load Metrics (679 ± 25 ms)
|
Collaborator
Builds ready [94c588d]
Page Load Metrics (685 ± 45 ms)
|
Collaborator
Builds ready [95c3b22]
Page Load Metrics (662 ± 14 ms)
|
adonesky1
force-pushed
the
token-rates-controller
branch
from
August 2, 2021 15:14
95c3b22 to
6883442
Compare
Collaborator
Builds ready [6883442]
Page Load Metrics (656 ± 18 ms)
|
adonesky1
force-pushed
the
token-rates-controller
branch
from
August 6, 2021 18:00
6883442 to
00cbdb5
Compare
Collaborator
Builds ready [00cbdb5]
Page Load Metrics (654 ± 34 ms)
|
adonesky1
force-pushed
the
token-rates-controller
branch
from
August 10, 2021 14:28
00cbdb5 to
906fc84
Compare
Collaborator
Builds ready [906fc84]
Page Load Metrics (648 ± 36 ms)
|
danjm
reviewed
Aug 11, 2021
danjm
reviewed
Aug 11, 2021
danjm
reviewed
Aug 11, 2021
brad-decker
reviewed
Sep 9, 2021
| .then(() => history.push(mostRecentOverviewPage)); | ||
| disabled={suggestedAssets.length === 0} | ||
| onClick={async () => { | ||
| await suggestedAssets.forEach(async ({ asset, id }) => { |
Collaborator
Builds ready [c19ec7f]
Page Load Metrics (617 ± 10 ms)
|
adonesky1
requested review from
NiranjanaBinoy,
brad-decker,
danjm and
ryanml
September 9, 2021 18:09
adonesky1
force-pushed
the
token-rates-controller
branch
from
September 9, 2021 22:15
c19ec7f to
afc5a76
Compare
Contributor
Author
|
Resolved conflicts with @NiranjanaBinoy's PR. Obviously needed to rebase so sorry for breaking review tracking flows. Tests failing because gas API is down. Please review (or re-review) as soon as you can! cc @danjm, @darkwing, @brad-decker, @ryanml. 🙏 🙏 🙏 |
adonesky1
force-pushed
the
token-rates-controller
branch
from
September 10, 2021 14:20
44f9a45 to
5abc887
Compare
Collaborator
Builds ready [5abc887]
Page Load Metrics (301 ± 28 ms)
|
brad-decker
suggested changes
Sep 10, 2021
brad-decker
left a comment
Contributor
There was a problem hiding this comment.
some code style/improvement things, but all good after that.
darkwing
reviewed
Sep 10, 2021
darkwing
reviewed
Sep 10, 2021
darkwing
reviewed
Sep 10, 2021
darkwing
reviewed
Sep 10, 2021
brad-decker
approved these changes
Sep 10, 2021
darkwing
approved these changes
Sep 10, 2021
Collaborator
Builds ready [c7f0af9]
Page Load Metrics (269 ± 9 ms)
|
danjm
approved these changes
Sep 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required changes to land the controllers repo TokensController. This is pre-requisite work to next land the TokenRatesController in the extension and have access to token exchange rates for other custom networks.
Manual testing steps: