Skip to content

Integrate TokensController - #11552

Merged
adonesky1 merged 5 commits into
developfrom
token-rates-controller
Sep 10, 2021
Merged

adonesky1 merged 5 commits into
developfrom
token-rates-controller

Conversation

@adonesky1

@adonesky1 adonesky1 commented Jul 16, 2021 •

Copy link
Copy Markdown
Contributor

Required changes to land the controllers repo TokensController. This is pre-requisite work to next land the TokenRatesController in the extension and have access to token exchange rates for other custom networks.

Manual testing steps:

  • Broad regression testing for all token related actions.
  • Testing migration scenario from old Preference Controller based token state to the new TokensController based token state.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@adonesky1
adonesky1 force-pushed the token-rates-controller branch 8 times, most recently from 6d0e1c7 to e2dd8a8 Compare July 22, 2021 22:08
@adonesky1
adonesky1 force-pushed the token-rates-controller branch from e2dd8a8 to b11646d Compare July 26, 2021 18:18
@adonesky1 adonesky1 changed the title [WIP] - Integrate Tokenscontroller Integrate Tokenscontroller Jul 26, 2021
@adonesky1
adonesky1 force-pushed the token-rates-controller branch 2 times, most recently from 1d12cb6 to 78c1477 Compare July 28, 2021 21:31
@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [78c1477]
Page Load Metrics (679 ± 25 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint58846884
domContentLoaded5847926785225
load5857936795225
domInteractive5847926775225

@adonesky1
adonesky1 marked this pull request as ready for review July 28, 2021 22:12
@adonesky1
adonesky1 requested a review from a team as a code owner July 28, 2021 22:12
@adonesky1
adonesky1 requested a review from darkwing July 28, 2021 22:12
@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [94c588d]
Page Load Metrics (685 ± 45 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint519165115
domContentLoaded5558896849445
load5558906859445
domInteractive5548896839445

@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [95c3b22]
Page Load Metrics (662 ± 14 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint56866684
domContentLoaded5907196612914
load5917206622914
domInteractive5897186612914

@adonesky1
adonesky1 force-pushed the token-rates-controller branch from 95c3b22 to 6883442 Compare August 2, 2021 15:14
@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [6883442]
Page Load Metrics (656 ± 18 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint5610770136
domContentLoaded5587226553818
load5597236563818
domInteractive5587226553818

@adonesky1
adonesky1 force-pushed the token-rates-controller branch from 6883442 to 00cbdb5 Compare August 6, 2021 18:00
@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [00cbdb5]
Page Load Metrics (654 ± 34 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint5310263105
domContentLoaded4757906537134
load4767916547134
domInteractive4757906537134

@adonesky1
adonesky1 force-pushed the token-rates-controller branch from 00cbdb5 to 906fc84 Compare August 10, 2021 14:28
@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [906fc84]
Page Load Metrics (648 ± 36 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint50856394
domContentLoaded4978536477536
load4988576487636
domInteractive4978536477536

Comment thread ui/helpers/utils/util.js Resolved
.then(() => history.push(mostRecentOverviewPage));
disabled={suggestedAssets.length === 0}
onClick={async () => {
await suggestedAssets.forEach(async ({ asset, id }) => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here as @darkwing 's initial comment.

@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [c19ec7f]
Page Load Metrics (617 ± 10 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint52846484
domContentLoaded5916676152210
load5936716172210
domInteractive5916666152210

@adonesky1
adonesky1 force-pushed the token-rates-controller branch from c19ec7f to afc5a76 Compare September 9, 2021 22:15
@adonesky1

Copy link
Copy Markdown
Contributor Author

Resolved conflicts with @NiranjanaBinoy's PR. Obviously needed to rebase so sorry for breaking review tracking flows. Tests failing because gas API is down. Please review (or re-review) as soon as you can! cc @danjm, @darkwing, @brad-decker, @ryanml. 🙏 🙏 🙏

@adonesky1
adonesky1 force-pushed the token-rates-controller branch from 44f9a45 to 5abc887 Compare September 10, 2021 14:20
@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [5abc887]
Page Load Metrics (301 ± 28 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint875232847536
domContentLoaded2375072835828
load2545223015928
domInteractive2375072835828

@brad-decker brad-decker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some code style/improvement things, but all good after that.

Comment thread ui/store/actions.js Resolved
@adonesky1
adonesky1 requested a review from darkwing September 10, 2021 17:10
@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [c7f0af9]
Page Load Metrics (269 ± 9 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint603092534823
domContentLoaded2202982522010
load236316269209
domInteractive2202982522010

@adonesky1
adonesky1 merged commit 490d3b8 into develop Sep 10, 2021
@adonesky1
adonesky1 deleted the token-rates-controller branch September 10, 2021 17:37
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants