Repository navigation
Split out TokensController and CollectiblesController from AssetsController - #518
Merged
Merged
Conversation
adonesky1
force-pushed
the
split-assets-controller
branch
2 times, most recently
from
July 9, 2021 14:58
a4f2221 to
ac06752
Compare
adonesky1
force-pushed
the
split-assets-controller
branch
from
July 9, 2021 15:28
ac06752 to
d87b0fa
Compare
Gudahtt
requested changes
Jul 12, 2021
Gudahtt
left a comment
Member
There was a problem hiding this comment.
This looks great! Very clean and easy to review - I'm glad to see the split was as easy as I had hoped. The only thing I found was a leftover comment.
|
|
||
| import type { NetworkState } from '../network/NetworkController'; | ||
| import type { AssetsState } from './AssetsController'; | ||
| import { TokensState } from './TokensController'; |
Member
There was a problem hiding this comment.
Nit: the type keyword can be preserved here, since we're just importing this to use it as a type
Suggested change
| import { TokensState } from './TokensController'; | |
| import type { TokensState } from './TokensController'; |
| import { createSandbox, stub } from 'sinon'; | ||
| import { BN } from 'ethereumjs-util'; | ||
| import HttpProvider from 'ethjs-provider-http'; | ||
| // import HttpProvider from 'ethjs-provider-http'; |
Member
There was a problem hiding this comment.
This comment can be removed. I see that it was only used for the MAINNET_PROVIDER, which was itself removed.
Suggested change
| // import HttpProvider from 'ethjs-provider-http'; |
Contributor
Author
|
@Gudahtt thanks for the quick review! Pushed requested changes! |
Merged
This was referenced Oct 22, 2021
Merged
amitabh94
pushed a commit
to amitabh94/core
that referenced
this pull request
Jun 16, 2026
* 16.5.0 * Update CHANGELOG.md --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Daniel <80175477+dan437@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses part 1 of #516
Objective
Split AssetsController into two new controllers (Tokens and Collectibles) that manage state these separate asset classes without introducing any functional changes.
Tested in mobile for regressions with changes in metamask-mobile #2881