Skip to content

chore: Migrate Perps-involved legacy API method calls to messengers - #47254

Merged
mcmire merged 6 commits into
mainfrom
migrate-perps-srtb-calls-to-messengers
Nov 9, 2026
Merged

mcmire merged 6 commits into
mainfrom
migrate-perps-srtb-calls-to-messengers

Conversation

@mcmire

@mcmire mcmire commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Description

Currently, the background process aggregates methods from various controllers and services into an API object, and the UI calls a method on this object by passing its name and arguments to submitRequestToBackground.

The "root" messenger — the messenger for MetamaskController — is meant to replace this API, and we want to transition to it by replacing submitRequestToBackground calls so that they pass action type strings (e.g. NetworkController:addNetwork) instead of method names (e.g. addNetwork). Then, eventually, we want to remove the original methods from the legacy API object. This PR is one of a series of PRs which aims to unlock this refactor.

The tactic used to create this PR was to look for submitRequestToBackground calls in controllers, services, and files owned by the Perps team (although the changes may have affected other files as well).

Calls for the following API methods defined within the PerpsController init object were migrated to use messenger action type strings (and the methods were removed):

  • perpsClearDepositResult
  • perpsClearPendingTradeConfiguration
  • perpsClearPendingTransactionRequests
  • perpsClearWithdrawResult
  • perpsGetBlockExplorerUrl
  • perpsGetConnectionState
  • perpsGetCurrentNetwork
  • perpsGetMarketFilterPreferences
  • perpsGetMaxSlippage
  • perpsGetOrderBookGrouping
  • perpsGetOrderBookPreferences
  • perpsGetPendingTradeConfiguration
  • perpsGetProLayoutPreferences
  • perpsGetSelectedOrderType
  • perpsGetTradeConfiguration
  • perpsGetVisibleCandleCount
  • perpsGetWatchlistMarkets
  • perpsGetWithdrawalProgress
  • perpsGetWithdrawalRoutes
  • perpsIsFirstTimeUserOnCurrentNetwork
  • perpsIsWatchlistMarket
  • perpsMarkFirstOrderCompleted
  • perpsMarkTutorialCompleted
  • perpsReconnect
  • perpsRefreshEligibility
  • perpsResetFirstTimeUserState
  • perpsResetSelectedPaymentToken
  • perpsSaveMarketFilterPreferences
  • perpsSaveOrderBookGrouping
  • perpsSavePendingTradeConfiguration
  • perpsSaveTradeConfiguration
  • perpsSetAttributionContext
  • perpsSetMaxSlippage
  • perpsSetOrderBookPreferences
  • perpsSetProLayoutPreferences
  • perpsSetSelectedOrderType
  • perpsSetSelectedPaymentToken
  • perpsSetVisibleCandleCount
  • perpsToggleWatchlistMarket

Calls for the following API methods defined within MetamaskController.getApi were migrated to use messenger action type strings:

  • rewardsGetPerpsDiscountForAccount
    (-> RewardsController:getPerpsDiscountForAccount)
  • setLastPerpsDepositEntryPoint
    (-> AppStateController:setLastPerpsDepositEntryPoint)

Calls for the following API methods were not migrated because they include behavior that would have to be moved into the controller:

  • perpsCalculateFees
  • perpsCalculateFees
  • perpsCalculateLiquidationPrice
  • perpsCancelOrder
  • perpsCancelOrders
  • perpsClosePosition
  • perpsClosePositions
  • perpsDepositWithConfirmation
  • perpsDisconnect
  • perpsFetchHistoricalCandles
  • perpsFlipPosition
  • perpsGetAccountState
  • perpsGetFunding
  • perpsGetLifecycleContext
  • perpsGetMarketDataWithPrices
  • perpsGetMarkets
  • perpsGetOpenOrders
  • perpsGetOrderFills
  • perpsGetOrders
  • perpsGetPositions
  • perpsGetUserHistory
  • perpsInit
  • perpsMarkForegroundSettled
  • perpsStartEligibilityMonitoring
  • perpsStopEligibilityMonitoring
  • perpsToggleTestnet
  • perpsUpdateMargin
  • perpsUpdatePositionTPSL
  • perpsViewActive

Calls for the following API methods were not migrated because they come from PerpsStreamBridge, which needs special attention:

  • perpsActivateCandleStream
  • perpsActivateOrderBookAggregatedStream
  • perpsActivateOrderBookStream
  • perpsActivatePriceStream
  • perpsCheckHealth
  • perpsDeactivateCandleStream
  • perpsDeactivateOrderBookAggregatedStream
  • perpsDeactivateOrderBookStream
  • perpsDeactivatePriceStream
  • perpsInitForAccount
  • perpsRegisterPreload
  • perpsStopPreload

Changelog

CHANGELOG entry: null

Related issues

https://consensyssoftware.atlassian.net/browse/WPC-1422

Manual testing steps

This PR should have no functional changes. All flows should work like they do today, and the changes here should be covered by tests.

Screenshots/Recordings

(N/A)

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Wide Perps UI and background wiring changes (prefs, withdrawals, disconnect) with no intended behavior change, but a missed call site could break flows at runtime.

Overview
This PR continues the move off the aggregated background API by switching Perps-related submitRequestToBackground calls to messenger action strings (e.g. PerpsController:saveTradeConfiguration, RewardsController:getPerpsDiscountForAccount, PreferencesController:setPreference, AppStateController:setLastPerpsDepositEntryPoint).

The Perps controller init layer drops a large set of thin perps* wrappers from getApi (preferences, withdrawal routes/progress, connection/attribution helpers, watchlist, tutorials, etc.) so those capabilities are invoked via the root messenger instead of the legacy API object. MetaMaskController now reads WebSocket disconnect state with PerpsController:getWebSocketConnectionState rather than perpsGetConnectionState. getPerpsControllerMessenger widens allowed actions to the package’s PerpsControllerActions union. Tests across init, UI, and hooks were updated to match the new action names and slimmer API surface.

Reviewed by Cursor Bugbot for commit d1b6c73. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci

metamask-ci Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

🫰 @MetaMask/core-platform (1 files, +3 -1)
  • 📁 app/
    • 📁 scripts/
      • 📄 metamask-controller.js +3 -1

👨‍🔧 @MetaMask/extension-platform (1 files, +3 -1)
  • 📁 app/
    • 📁 scripts/
      • 📄 metamask-controller.js +3 -1

👨‍🔧 @MetaMask/perps (22 files, +221 -168)
  • 📁 ui/
    • 📁 components/
      • 📁 app/
        • 📁 perps/
          • 📁 close-position/
            • 📄 close-all-positions-modal.test.tsx +2 -2
          • 📁 order-book/
            • 📄 order-book.test.tsx +4 -4
            • 📄 order-book.tsx +3 -3
          • 📁 perps-tutorial-modal/
            • 📄 PerpsTutorialModal.test.tsx +17 -0
            • 📄 PerpsTutorialModal.tsx +3 -3
            • 📄 perps-deposit-toast.test.tsx +3 -3
            • 📄 perps-deposit-toast.tsx +5 -4
            • 📄 perps-withdraw-toast.test.tsx +5 -2
            • 📄 perps-withdraw-toast.tsx +6 -4
    • 📁 hooks/
      • 📁 perps/
        • 📄 usePerpsMaxSlippage.test.ts +3 -3
        • 📄 usePerpsMaxSlippage.ts +3 -3
        • 📄 usePerpsMetamaskFeeDiscountBips.test.ts +9 -9
        • 📄 usePerpsMetamaskFeeDiscountBips.ts +4 -4
        • 📄 usePerpsOrderFees.test.ts +10 -8
    • 📁 pages/
      • 📁 perps/
        • 📄 perps-market-detail-page.test.tsx +4 -4
        • 📄 perps-market-detail-page.tsx +7 -7
        • 📄 perps-order-entry-page.test.tsx +15 -15
        • 📄 perps-order-entry-page.tsx +50 -42
        • 📄 perps-withdraw-page.test.tsx +48 -34
        • 📄 perps-withdraw-page.tsx +9 -3
    • 📁 providers/
      • 📁 perps/
        • 📄 PerpsAttributionContext.test.tsx +6 -6
        • 📄 PerpsAttributionContext.tsx +5 -5

@metamask-ci metamask-ci Bot added the team-core-platform Core Platform team label Oct 21, 2026
@metamask-ci

metamask-ci Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor
Builds ready [a114083]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 2 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 39677811918 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +414%
  • ↑ loadNewAccount/total: +414%
  • ↓ loadNewAccount/fcp: -27%
  • ↓ loadNewAccount/lcp: -17%
  • ↑ confirmTx/longTaskMaxDuration: +32%
  • ↑ confirmTx/tbt: +17%
  • ↓ confirmTx/inp: -39%
  • ↓ confirmTx/fcp: -25%
  • ↑ bridgeUserActions/bridge_load_page: +15%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +76%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +50%
  • ↓ bridgeUserActions/longTaskMaxDuration: -14%
  • ↑ bridgeUserActions/tbt: +18%
  • ↓ bridgeUserActions/fcp: -26%
  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↑ loadNewAccount/lcp: +1024%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/inp: +14%
  • ↓ confirmTx/fcp: -64%
  • ↑ confirmTx/lcp: +1044%
  • ↑ bridgeUserActions/bridge_load_page: +221%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +59%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +17%
  • ↑ bridgeUserActions/inp: +131%
  • ↓ bridgeUserActions/fcp: -67%
  • ↑ bridgeUserActions/lcp: +1046%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 bridgeUserActions/INP: p75 240ms
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/domInteractive: +17%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +150%
  • ↓ startupStandardHome/domInteractive: -39%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +126%
  • ↓ startupStandardHome/fcp: -34%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -20%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -95%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -81%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -78%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -67%
  • ↓ dappPageLoad/domContentLoaded: -24%
  • ↓ dappPageLoad/firstPaint: -55%
  • ↓ dappPageLoad/firstContentfulPaint: -55%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.43 MiB -28.16 KiB -0.18%
🚨 ui 19.32 MiB +6.79 KiB +0.03%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +7 Bytes 0.00%
✅ content scripts 3.24 MiB +14 Bytes 0.00%
✅ zip 23.99 MiB -4.27 KiB -0.02%

@mcmire
mcmire marked this pull request as ready for review October 21, 2026 21:52
@mcmire
mcmire requested review from a team as code owners October 21, 2026 21:52
@mcmire mcmire changed the title chore: Migrate SRTB calls to messengers within Perps-owned files chore: Migrate most SRTB calls to messengers within Perps-owned files Oct 22, 2026
@metamask-ci

metamask-ci Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor
Builds ready [cc1dfd7]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 5 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40021750580 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↑ loadNewAccount/fcp: +11%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +70%
  • ↑ confirmTx/longTaskMaxDuration: +86%
  • ↑ confirmTx/tbt: +103%
  • ↑ confirmTx/fcp: +11%
  • ↑ bridgeUserActions/bridge_load_page: +103%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +102%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +112%
  • ↑ bridgeUserActions/longTaskMaxDuration: +22%
  • ↑ bridgeUserActions/tbt: +186%
  • ↑ bridgeUserActions/total: +25%
  • ↑ bridgeUserActions/inp: +23%
  • ↑ loadNewAccount/load_new_account: +423%
  • ↑ loadNewAccount/total: +423%
  • ↑ loadNewAccount/fcp: +26%
  • ↑ loadNewAccount/lcp: +1319%
  • ↑ confirmTx/confirm_tx: +11%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/total: +11%
  • ↑ confirmTx/fcp: +29%
  • ↑ confirmTx/lcp: +1403%
  • ↑ bridgeUserActions/bridge_load_page: +296%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +354%
  • ↑ bridgeUserActions/bridge_search_token: +29%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +81%
  • ↑ bridgeUserActions/inp: +69%
  • ↑ bridgeUserActions/fcp: +30%
  • ↑ bridgeUserActions/lcp: +1400%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 loadNewAccount/FCP: p75 2.2s
  • 🟡 confirmTx/FCP: p75 2.2s
  • 🟡 confirmTx/LCP: p75 2.5s
  • 🟡 bridgeUserActions/FCP: p75 2.3s
  • 🟡 bridgeUserActions/LCP: p75 2.6s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ startupStandardHome/uiStartup: -12%
  • ↓ startupStandardHome/load: -14%
  • ↓ startupStandardHome/domContentLoaded: -14%
  • ↓ startupStandardHome/backgroundConnect: -18%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↓ startupStandardHome/loadScripts: -14%
  • ↑ startupStandardHome/setupStore: +120%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/longTaskTotalDuration: -22%
  • ↓ startupStandardHome/longTaskMaxDuration: -19%
  • ↓ startupStandardHome/tbt: -19%
  • ↓ startupStandardHome/inp: -11%
  • ↓ startupStandardHome/fcp: -15%
  • ↓ startupStandardHome/domInteractive: -34%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +126%
  • ↓ startupStandardHome/fcp: -27%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -95%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +40%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +30%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +16%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +12%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -85%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -72%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -38%
  • ↓ onboardingNewWallet/tbt: -83%
  • ↓ onboardingNewWallet/total: -81%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -67%
  • ↓ dappPageLoad/domContentLoaded: -23%
  • ↓ dappPageLoad/firstPaint: -55%
  • ↓ dappPageLoad/firstContentfulPaint: -55%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.44 MiB -28.16 KiB -0.18%
🚨 ui 19.35 MiB +6.8 KiB +0.03%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +7 Bytes 0.00%
✅ content scripts 3.24 MiB +14 Bytes 0.00%
✅ zip 24 MiB -4.19 KiB -0.02%

@metamask-ci

metamask-ci Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor
Builds ready [0de3799]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 3 warn · 🔴 2 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40024472730 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +419%
  • ↑ loadNewAccount/total: +419%
  • ↑ loadNewAccount/fcp: +11%
  • ↑ confirmTx/longTaskTotalDuration: +57%
  • ↑ confirmTx/longTaskMaxDuration: +86%
  • ↑ confirmTx/tbt: +100%
  • ↓ confirmTx/inp: -24%
  • ↑ confirmTx/fcp: +10%
  • ↑ bridgeUserActions/bridge_load_page: +117%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +114%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +133%
  • ↑ bridgeUserActions/longTaskMaxDuration: +56%
  • ↑ bridgeUserActions/tbt: +273%
  • ↑ bridgeUserActions/total: +22%
  • ↑ loadNewAccount/load_new_account: +418%
  • ↑ loadNewAccount/total: +418%
  • ↓ loadNewAccount/inp: -55%
  • ↓ loadNewAccount/fcp: -71%
  • ↑ loadNewAccount/lcp: +1142%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -32%
  • ↓ confirmTx/fcp: -72%
  • ↑ confirmTx/lcp: +1044%
  • ↑ bridgeUserActions/bridge_load_page: +139%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +45%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +16%
  • ↑ bridgeUserActions/inp: +92%
  • ↓ bridgeUserActions/fcp: -72%
  • ↑ bridgeUserActions/lcp: +858%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/domInteractive: +15%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +203%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/uiStartup: -31%
  • ↓ startupStandardHome/load: -25%
  • ↓ startupStandardHome/domContentLoaded: -25%
  • ↓ startupStandardHome/domInteractive: -44%
  • ↓ startupStandardHome/backgroundConnect: -12%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -26%
  • ↑ startupStandardHome/setupStore: +61%
  • ↓ startupStandardHome/fcp: -34%
  • ↓ startupStandardHome/lcp: -23%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +47%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +44%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +38%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +35%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +19%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -83%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -79%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -58%
  • ↓ dappPageLoad/firstPaint: -41%
  • ↓ dappPageLoad/firstContentfulPaint: -41%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.44 MiB -28.16 KiB -0.18%
🚨 ui 19.35 MiB +6.8 KiB +0.03%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB +7 Bytes 0.00%
✅ content scripts 3.24 MiB +14 Bytes 0.00%
✅ zip 24 MiB -4.19 KiB -0.02%

@mcmire mcmire changed the title chore: Migrate most SRTB calls to messengers within Perps-owned files chore: Use messenger syntax for bg calls to Perps-owned components Oct 27, 2026
@mcmire
mcmire force-pushed the migrate-unowned-srtb-to-messengers branch from c538b69 to dbd3d3d Compare October 27, 2026 15:07
@mcmire
mcmire requested review from a team as code owners October 27, 2026 15:07
@mcmire
mcmire force-pushed the migrate-unowned-srtb-to-messengers branch from dbd3d3d to 4cb0379 Compare October 27, 2026 17:05
@mcmire
mcmire force-pushed the migrate-perps-srtb-calls-to-messengers branch from 0de3799 to ca9220d Compare October 27, 2026 17:19

@MajorLift MajorLift left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One breaking change: the calls this PR migrates lose their Sentry span names. The diff below names their spans after the action they call.

Comment on lines +29 to 32
const value = await submitRequestToBackground(
'PerpsController:getMaxSlippage',
[],
);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every call this PR migrates now reaches the background as messengerCall, and the rpc.handler span is named after that method (createMetaRPCHandler.ts L40-L43). The span names these calls have today stop appearing, such as Background RPC: PerpsController.perpsSetVisibleCandleCount and Background RPC: PerpsController.perpsGetMaxSlippage (project metamask, production, 2026-10-22 to 2026-10-29).

Actions that aren't read-only get a Messenger Call: PerpsController:<method> child span, but read-only actions like this one are skipped (messenger-tracing.ts L63-L71), so getMaxSlippage, getWithdrawalRoutes and getPerpsDiscountForAccount are not named in any span.

Could we name messengerCall spans after the action they dispatch? Here's a diff if it helps:

diff --git a/app/scripts/lib/createMetaRPCHandler.test.ts b/app/scripts/lib/createMetaRPCHandler.test.ts
index 31f798bd019..5eebcd1e8b1 100644
--- a/app/scripts/lib/createMetaRPCHandler.test.ts
+++ b/app/scripts/lib/createMetaRPCHandler.test.ts
@@ -214,6 +214,39 @@ describe('createMetaRPCHandler', () => {
       );
     });
 
+    it('names messengerCall spans after the action they dispatch', async () => {
+      const messengerCall = jest.fn().mockReturnValue('result');
+      const api = { messengerCall } as unknown as Api;
+      const streamTest = createStream();
+      const handler = createMetaRPCHandler(api, streamTest);
+
+      await handler({
+        jsonrpc: '2.0',
+        id: 1,
+        method: 'messengerCall',
+        params: [
+          'PerpsController:getMaxSlippage',
+          [],
+          { _traceContext: { _traceId: 'trace123', _spanId: 'span456' } },
+        ],
+      });
+
+      expect(trace).toHaveBeenCalledWith(
+        expect.objectContaining({
+          name: 'Background RPC: PerpsController:getMaxSlippage',
+          data: {
+            method: 'messengerCall',
+            action: 'PerpsController:getMaxSlippage',
+          },
+        }),
+        expect.any(Function),
+      );
+      expect(messengerCall).toHaveBeenCalledWith(
+        'PerpsController:getMaxSlippage',
+        [],
+      );
+    });
+
     it('continues trace context but skips rpc.handler span when shouldSampleWrappers rejects', async () => {
       jest.mocked(shouldSampleWrappers).mockReturnValue(false);
       const foo = jest.fn().mockReturnValue('result');
diff --git a/app/scripts/lib/createMetaRPCHandler.ts b/app/scripts/lib/createMetaRPCHandler.ts
index cd2360dcce9..0ee0b9cf69d 100644
--- a/app/scripts/lib/createMetaRPCHandler.ts
+++ b/app/scripts/lib/createMetaRPCHandler.ts
@@ -38,9 +38,17 @@ const createMetaRPCHandler = (api: MetaRpcApi, outStream: RpcStream) => {
     const { cleanParams, traceContext } = extractTraceContext(data.params);
     const handler = api[data.method];
     const controller = handler._controllerName;
+    // Root-messenger actions all arrive as `messengerCall(action, args)`, so
+    // the span is named after the action rather than the shared method.
+    const messengerAction =
+      data.method === 'messengerCall' &&
+      Array.isArray(cleanParams) &&
+      typeof cleanParams[0] === 'string'
+        ? cleanParams[0]
+        : undefined;
     const spanName: `Background RPC: ${string}` = controller
       ? `Background RPC: ${controller}.${data.method}`
-      : `Background RPC: ${data.method}`;
+      : `Background RPC: ${messengerAction ?? data.method}`;
 
     let result: unknown;
     let error: unknown;
@@ -59,7 +67,11 @@ const createMetaRPCHandler = (api: MetaRpcApi, outStream: RpcStream) => {
             name: spanName,
             parentContext: traceContext,
             op: 'rpc.handler',
-            data: { method: data.method, ...(controller && { controller }) },
+            data: {
+              method: data.method,
+              ...(controller && { controller }),
+              ...(messengerAction && { action: messengerAction }),
+            },
           },
           () => handler.call(api, ...cleanParams),
         );

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This is a good callout. I have created a new PR that aims to solve this problem, can you take a look at it? #47517

geositta
geositta previously approved these changes Oct 29, 2026

@geositta geositta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve. The migration preserves the saved slippage preference in the verified startup flow. Across four normal cold restarts the preference requests reach the background after handler registration, return the saved 50 bps, and order entry displayed and computed 0.5%. The baseline behaved identically. Static review found no remaining callers of the removed legacy perps methods, and trading operations retained their existing initialization and disconnect guards, no confirmed regressions remain from this review.

@mcmire
mcmire dismissed stale reviews from geositta and davidmurdoch via c1941ff October 30, 2026 14:31
@mcmire
mcmire deployed to segment-schema October 30, 2026 14:32 — with GitHub Actions Active
@metamask-ci

metamask-ci Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor
Builds ready [c1941ff]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41072384735 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +420%
  • ↑ loadNewAccount/total: +420%
  • ↑ loadNewAccount/fcp: +10%
  • ↑ loadNewAccount/lcp: +17%
  • ↑ confirmTx/longTaskTotalDuration: +51%
  • ↑ confirmTx/longTaskMaxDuration: +81%
  • ↑ confirmTx/tbt: +89%
  • ↑ confirmTx/lcp: +14%
  • ↑ bridgeUserActions/bridge_load_page: +79%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +85%
  • ↑ bridgeUserActions/longTaskCount: +67%
  • ↑ bridgeUserActions/longTaskTotalDuration: +86%
  • ↑ bridgeUserActions/tbt: +130%
  • ↑ bridgeUserActions/total: +11%
  • ↑ bridgeUserActions/lcp: +13%
  • ↑ loadNewAccount/load_new_account: +421%
  • ↑ loadNewAccount/total: +421%
  • ↓ loadNewAccount/inp: -24%
  • ↓ loadNewAccount/fcp: -27%
  • ↑ loadNewAccount/lcp: +1407%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -17%
  • ↑ confirmTx/fcp: +27%
  • ↑ confirmTx/lcp: +1441%
  • ↑ bridgeUserActions/bridge_load_page: +306%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +164%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +49%
  • ↑ bridgeUserActions/inp: +77%
  • ↑ bridgeUserActions/fcp: +29%
  • ↑ bridgeUserActions/lcp: +1389%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 loadNewAccount/LCP: p75 2.6s
  • 🟡 confirmTx/FCP: p75 2.2s
  • 🟡 confirmTx/LCP: p75 2.6s
  • 🟡 bridgeUserActions/FCP: p75 2.2s
  • 🟡 bridgeUserActions/LCP: p75 2.6s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/domInteractive: +17%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +120%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↓ startupStandardHome/uiStartup: -35%
  • ↓ startupStandardHome/load: -31%
  • ↓ startupStandardHome/domContentLoaded: -32%
  • ↓ startupStandardHome/domInteractive: -52%
  • ↓ startupStandardHome/backgroundConnect: -28%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -31%
  • ↑ startupStandardHome/setupStore: +40%
  • ↓ startupStandardHome/fcp: -43%
  • ↓ startupStandardHome/lcp: -28%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +57%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +48%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +41%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +29%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -86%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +11%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -83%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -79%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -55%
  • ↓ dappPageLoad/firstPaint: -37%
  • ↓ dappPageLoad/firstContentfulPaint: -37%
Bundle Size Diffs [🚀 Bundle size reduced!]
Status Bundle Total Diff Change
✅ background 15.26 MiB -2.14 KiB -0.01%
✅ ui 19.29 MiB +458 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.84 MiB -1.69 KiB 0.00%
✅ zip 24.06 MiB -344 Bytes 0.00%

@mcmire
mcmire marked this pull request as draft November 2, 2026 18:37
@mcmire

mcmire commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

Moving back to draft as this is now blocked by #47517.

@metamask-ci

metamask-ci Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor
Builds ready [d1b6c73]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42694484397 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/inp: -18%
  • ↓ loadNewAccount/fcp: -12%
  • ↑ loadNewAccount/lcp: +768%
  • ↑ loadNewAccount/cls: +297%
  • ↑ confirmTx/longTaskTotalDuration: +14%
  • ↑ confirmTx/longTaskMaxDuration: +29%
  • ↑ confirmTx/tbt: +24%
  • ↑ confirmTx/inp: +27%
  • ↑ confirmTx/lcp: +837%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +56%
  • ↓ bridgeUserActions/longTaskTotalDuration: -15%
  • ↓ bridgeUserActions/longTaskMaxDuration: -22%
  • ↓ bridgeUserActions/tbt: -24%
  • ↓ bridgeUserActions/inp: -19%
  • ↓ bridgeUserActions/fcp: -18%
  • ↑ bridgeUserActions/lcp: +706%
  • ↑ bridgeUserActions/cls: +634%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -25%
  • ↓ loadNewAccount/fcp: -35%
  • ↑ loadNewAccount/lcp: +1301%
  • ↑ confirmTx/confirm_tx: +10%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/total: +10%
  • ↓ confirmTx/inp: -13%
  • ↓ confirmTx/fcp: -29%
  • ↑ confirmTx/lcp: +1381%
  • ↑ bridgeUserActions/bridge_load_page: +185%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +139%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +46%
  • ↑ bridgeUserActions/inp: +62%
  • ↑ bridgeUserActions/fcp: +28%
  • ↑ bridgeUserActions/lcp: +1385%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 confirmTx/LCP: p75 2.5s
  • 🟡 bridgeUserActions/FCP: p75 2.2s
  • 🟡 bridgeUserActions/LCP: p75 2.6s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +44%
  • ↑ startupStandardHome/load: +69%
  • ↑ startupStandardHome/domContentLoaded: +70%
  • ↓ startupStandardHome/firstPaint: -58%
  • ↓ startupStandardHome/backgroundConnect: -17%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +68%
  • ↑ startupStandardHome/setupStore: +88%
  • ↑ startupStandardHome/numNetworkReqs: +11%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +65%
  • ↑ startupStandardHome/longTaskMaxDuration: +71%
  • ↑ startupStandardHome/tbt: +76%
  • ↓ startupStandardHome/inp: -24%
  • ↓ startupStandardHome/fcp: -61%
  • ↑ startupStandardHome/lcp: +73%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -28%
  • ↓ startupStandardHome/load: -22%
  • ↓ startupStandardHome/domContentLoaded: -24%
  • ↓ startupStandardHome/domInteractive: -43%
  • ↓ startupStandardHome/backgroundConnect: -15%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -22%
  • ↓ startupStandardHome/setupStore: -24%
  • ↓ startupStandardHome/fcp: -33%
  • ↓ startupStandardHome/lcp: -21%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +22%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +33%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +48%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +19%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -91%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -82%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -95%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -90%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +13%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +37%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +25%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -74%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -74%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -35%
  • ↓ onboardingNewWallet/tbt: -97%
  • ↓ onboardingNewWallet/total: -69%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -64%
  • ↓ dappPageLoad/domContentLoaded: -26%
  • ↓ dappPageLoad/firstPaint: -47%
  • ↓ dappPageLoad/firstContentfulPaint: -47%
Bundle Size Diffs [🚀 Bundle size reduced!]
Status Bundle Total Diff Change
✅ background 15.23 MiB -2.14 KiB -0.01%
✅ ui 19.44 MiB +458 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.87 MiB -1.69 KiB 0.00%
✅ zip 23.96 MiB -324 Bytes 0.00%

@sonarqubecloud

sonarqubecloud Bot commented Nov 9, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
4.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@mcmire
mcmire marked this pull request as ready for review November 9, 2026 21:55
@mcmire
mcmire enabled auto-merge November 9, 2026 22:22
@mcmire
mcmire added this pull request to the merge queue Nov 9, 2026
Merged via the queue into main with commit 854e9e7 Nov 9, 2026
141 of 142 checks passed
@mcmire
mcmire deleted the migrate-perps-srtb-calls-to-messengers branch November 9, 2026 23:08
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 9, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026

This branch was successfully deployed

1 active (outdated) and 1 inactive deployments
pr-comment — d1b6c73b Deployed Nov 9, 2026 by mcmire via identify-codeowners #89261
segment-schema — c1941ff4 Deployed Oct 30, 2026 by mcmire via propose #1965
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.58.0 Issue or pull request that will be included in release 13.58.0 size-L team-core-platform Core Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants