Skip to content

chore: Ensure Sentry traces for messenger action calls include action in name - #47517

Merged
mcmire merged 6 commits into
mainfrom
fix-sentry-tracing-with-messenger-call
Nov 9, 2026
Merged

mcmire merged 6 commits into
mainfrom
fix-sentry-tracing-with-messenger-call

Conversation

@mcmire

@mcmire mcmire commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Description

When submitRequestToBackground is passed a root messenger action type string, it correct includes a trace context in the request so that the handler on the background side can use it to create a Sentry span. However, the name assigned to the span does not reflect the action type string but rather messengerCall (which is the name of the RPC method in the background API that all messenger calls are routed through).

This commit fixes this issue, and adds an end-to-end test to ensure it isn't introduced again.

Changelog

CHANGELOG entry: null

Related issues

See #47254 (comment).

Manual testing steps

It's a bit difficult to test this manually, but you can try this:

  • Check out this branch (or the branch where this change occurs) locally.
  • Make sure SENTRY_DSN_DEV is set in .metamaskrc. (You can find a value for SENTRY_DSN_DEV from .metamaskrc.dist.)
  • Open shared/lib/wrapper-sampling.ts and change shouldSampleWrappers like this:
      export function shouldSampleWrappers(traceId: string | undefined): boolean {
        if (!traceId || traceId.length < 8) {
          return false;
        }
    -   const rate = getRemoteWrapperSampleRate() ?? WRAPPER_SAMPLE_RATE;
    -   const hashBucket = parseInt(traceId.slice(0, 8), 16) % 10000;
    -   return hashBucket < rate * 10000;
    +   return true;
      }
  • Run yarn start --sentry.
  • Load the extension and open the DevTools for the service worker.
  • Open MetaMask (open the home screen).
  • Switch back to DevTools, open the Network tab, and filter for "sentry".
  • Click through each request. You should eventually see a request that has a transaction which starts with "Background RPC:"
    Screenshot 2026-10-30 at 8 18 55 AM

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Observability-only RPC metadata and span naming; no auth or user-data paths, with backward-safe handling when _trace is missing or invalid.

Overview
Replaces the trailing _traceContext RPC payload with a structured _trace object (serialized UI context, spanName, and optional messengerAction) and renames extraction to extractTraceMetadata, with stricter validation so legitimate params are not stripped.

On the UI, submitRequestToBackground always attaches this metadata and sets span names like Background RPC: AppStateController:getState instead of generic messengerCall. The background createMetaRPCHandler consumes that metadata for Sentry rpc.handler spans (including action in span data) and no longer infers names from the RPC method or arguments.

Tests cover metadata extraction, handler behavior, UI wiring, and a new e2e check that Sentry envelopes include messenger-action-named background RPC spans. .metamaskrc.dist documents the kill switch appending _trace.

Reviewed by Cursor Bugbot for commit d7f62d5. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci

metamask-ci Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/extension-platform (1 files, +20 -13)
  • 📁 app/
    • 📁 scripts/
      • 📁 lib/
        • 📄 createMetaRPCHandler.ts +20 -13

@metamask-ci metamask-ci Bot added the team-core-platform Core Platform team label Oct 29, 2026
@metamask-ci

metamask-ci Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor
Builds ready [3220ae7]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 1 warn · 🔴 3 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 40961250403 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +409%
  • ↑ loadNewAccount/total: +409%
  • ↓ loadNewAccount/inp: -39%
  • ↓ loadNewAccount/fcp: -37%
  • ↓ loadNewAccount/lcp: -24%
  • ↓ confirmTx/longTaskCount: -33%
  • ↓ confirmTx/longTaskTotalDuration: -26%
  • ↓ confirmTx/tbt: -20%
  • ↓ confirmTx/inp: -55%
  • ↓ confirmTx/fcp: -35%
  • ↓ confirmTx/lcp: -20%
  • ↓ bridgeUserActions/bridge_load_asset_picker: -34%
  • ↓ bridgeUserActions/bridge_search_token: -11%
  • ↑ bridgeUserActions/longTaskCount: +11%
  • ↓ bridgeUserActions/longTaskTotalDuration: -24%
  • ↓ bridgeUserActions/longTaskMaxDuration: -38%
  • ↓ bridgeUserActions/tbt: -91%
  • ↓ bridgeUserActions/total: -15%
  • ↓ bridgeUserActions/inp: -23%
  • ↓ bridgeUserActions/fcp: -36%
  • ↓ bridgeUserActions/lcp: -24%
  • ↑ loadNewAccount/load_new_account: +420%
  • ↑ loadNewAccount/total: +420%
  • ↑ loadNewAccount/fcp: +18%
  • ↑ loadNewAccount/lcp: +1337%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -17%
  • ↓ confirmTx/fcp: -32%
  • ↑ confirmTx/lcp: +1331%
  • ↑ bridgeUserActions/bridge_load_page: +302%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +141%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +49%
  • ↑ bridgeUserActions/inp: +46%
  • ↓ bridgeUserActions/fcp: -39%
  • ↑ bridgeUserActions/lcp: +1281%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 loadNewAccount/LCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +11%
  • ↑ startupStandardHome/domInteractive: +21%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +120%
  • ↓ startupStandardHome/longTaskCount: -33%
  • ↑ startupStandardHome/tbt: +10%
  • ↓ startupStandardHome/domInteractive: -36%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/setupStore: +131%
  • ↓ startupStandardHome/fcp: -30%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +41%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +39%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +36%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +40%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +41%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +23%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +35%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +21%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -75%
  • ↓ onboardingNewWallet/longTaskCount: -69%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -78%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -48%
  • ↓ onboardingNewWallet/tbt: -95%
  • ↓ onboardingNewWallet/total: -72%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -71%
  • ↓ dappPageLoad/domContentLoaded: -33%
  • ↓ dappPageLoad/firstPaint: -55%
  • ↓ dappPageLoad/firstContentfulPaint: -55%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +399 Bytes 0.00%
✅ ui 19.28 MiB -844 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.84 MiB -277 Bytes 0.00%
✅ zip 24.06 MiB -166 Bytes 0.00%

When `submitRequestToBackground` is passed a root messenger action type
string, it correct includes a trace context in the request so that the
handler on the background side can use it to create a Sentry span.
However, the name assigned to the span does not reflect the action type
string but rather `messengerCall` (which is the name of the RPC method
in the background API that all messenger calls are routed through).

This commit fixes this issue, and adds an e2e test to ensure it isn't
introduced again.
@mcmire
mcmire force-pushed the fix-sentry-tracing-with-messenger-call branch from 3220ae7 to 8923a41 Compare October 30, 2026 14:12
@mcmire mcmire changed the title Ensure Sentry traces for messenger action calls include action in name chore: Ensure Sentry traces for messenger action calls include action in name Oct 30, 2026
@metamask-ci

metamask-ci Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor
Builds ready [8923a41]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 2 warn · 🔴 4 fail)

Baseline (latest main): 171ed20 | Date: 7/28/2026 | Pipeline: 41069834000 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +413%
  • ↑ loadNewAccount/total: +413%
  • ↓ loadNewAccount/fcp: -25%
  • ↓ loadNewAccount/lcp: -12%
  • ↑ confirmTx/longTaskMaxDuration: +32%
  • ↑ confirmTx/tbt: +16%
  • ↓ confirmTx/inp: -32%
  • ↓ confirmTx/fcp: -28%
  • ↓ confirmTx/lcp: -24%
  • ↑ bridgeUserActions/bridge_load_page: +11%
  • ↓ bridgeUserActions/bridge_load_asset_picker: -24%
  • ↑ bridgeUserActions/longTaskCount: +11%
  • ↓ bridgeUserActions/longTaskTotalDuration: -18%
  • ↓ bridgeUserActions/longTaskMaxDuration: -34%
  • ↓ bridgeUserActions/tbt: -75%
  • ↓ bridgeUserActions/total: -14%
  • ↓ bridgeUserActions/inp: -23%
  • ↓ bridgeUserActions/fcp: -32%
  • ↓ bridgeUserActions/lcp: -15%
  • ↑ loadNewAccount/load_new_account: +423%
  • ↑ loadNewAccount/total: +423%
  • ↑ loadNewAccount/fcp: +34%
  • ↑ loadNewAccount/lcp: +1455%
  • ↑ confirmTx/confirm_tx: +11%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/total: +11%
  • ↓ confirmTx/inp: -17%
  • ↓ confirmTx/fcp: -29%
  • ↑ confirmTx/lcp: +1481%
  • ↑ bridgeUserActions/bridge_load_page: +393%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +128%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +75%
  • ↑ bridgeUserActions/inp: +62%
  • ↓ bridgeUserActions/fcp: -29%
  • ↑ bridgeUserActions/lcp: +1399%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.3s
  • 🟡 loadNewAccount/LCP: p75 2.7s
  • 🟡 confirmTx/LCP: p75 2.7s
  • 🟡 bridgeUserActions/LCP: p75 2.6s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +13%
  • ↑ startupStandardHome/load: +11%
  • ↑ startupStandardHome/domContentLoaded: +10%
  • ↑ startupStandardHome/domInteractive: +22%
  • ↑ startupStandardHome/firstPaint: +11%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -33%
  • ↑ startupStandardHome/setupStore: +203%
  • ↑ startupStandardHome/tbt: +12%
  • ↑ startupStandardHome/fcp: +11%
  • ↑ startupStandardHome/lcp: +15%
  • ↓ startupStandardHome/uiStartup: -26%
  • ↓ startupStandardHome/load: -20%
  • ↓ startupStandardHome/domContentLoaded: -22%
  • ↓ startupStandardHome/domInteractive: -44%
  • ↓ startupStandardHome/backgroundConnect: -11%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -21%
  • ↑ startupStandardHome/setupStore: +72%
  • ↓ startupStandardHome/fcp: -37%
  • ↓ startupStandardHome/lcp: -19%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -27%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -94%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -75%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -89%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +33%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +14%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +24%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +36%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -79%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -75%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -68%
  • ↓ dappPageLoad/domContentLoaded: -26%
  • ↓ dappPageLoad/firstPaint: -46%
  • ↓ dappPageLoad/firstContentfulPaint: -46%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +398 Bytes 0.00%
✅ ui 19.28 MiB -915 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.84 MiB -349 Bytes 0.00%
✅ zip 24.06 MiB -174 Bytes 0.00%

@mcmire
mcmire marked this pull request as ready for review October 30, 2026 14:48
@mcmire
mcmire requested a review from a team as a code owner October 30, 2026 14:48
@mcmire
mcmire deployed to segment-schema October 30, 2026 14:48 — with GitHub Actions Active
GuillaumeRx
GuillaumeRx previously approved these changes Nov 4, 2026
Comment thread app/scripts/lib/createMetaRPCHandler.ts Outdated
Comment on lines +42 to +68
const { cleanParams, traceContext } = extractTraceContext(data.params);
let messengerAction;
let spanName: `Background RPC: ${string}`;

if (data.method === 'messengerCall') {
messengerAction =
Array.isArray(cleanParams) && typeof cleanParams[0] === 'string'
? cleanParams[0]
: undefined;

if (messengerAction) {
spanName = `Background RPC: ${messengerAction}`;
} else {
outStream.write({
jsonrpc: '2.0',
error: rpcErrors.invalidRequest({
message: 'messengerCall must be given an action type string',
}),
id: data.id,
});
return;
}
} else if (controller) {
spanName = `Background RPC: ${controller}.${data.method}`;
} else {
spanName = `Background RPC: ${data.method}`;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a solution that doesn't leak the messenger call abstraction into this unrelated module? 🤔

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we were already allowing lots of leakage here, which I fought against originally as well :-).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good point. I was just expanding on the code that was already here around assigning names to traces. But considering that the trace context always come from the submitRequestToBackground call, maybe we could move a lot of this logic there instead. I'll take a closer look at it.

@mcmire mcmire Nov 4, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@metamask-ci

metamask-ci Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor
Builds ready [eea9a69]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 3 warn · 🔴 4 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 41931624944 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/inp: -10%
  • ↑ loadNewAccount/fcp: +11%
  • ↑ loadNewAccount/lcp: +10%
  • ↑ loadNewAccount/cls: +282%
  • ↑ confirmTx/longTaskTotalDuration: +49%
  • ↑ confirmTx/longTaskMaxDuration: +72%
  • ↑ confirmTx/tbt: +83%
  • ↓ confirmTx/inp: -13%
  • ↑ confirmTx/fcp: +11%
  • ↑ bridgeUserActions/bridge_load_page: +60%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +102%
  • ↑ bridgeUserActions/longTaskCount: +82%
  • ↑ bridgeUserActions/longTaskTotalDuration: +79%
  • ↑ bridgeUserActions/tbt: +83%
  • ↑ bridgeUserActions/total: +17%
  • ↑ bridgeUserActions/fcp: +11%
  • ↑ bridgeUserActions/lcp: +16%
  • ↑ bridgeUserActions/cls: +281%
  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↓ loadNewAccount/inp: -10%
  • ↓ loadNewAccount/fcp: -28%
  • ↑ loadNewAccount/lcp: +1326%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -13%
  • ↑ confirmTx/fcp: +18%
  • ↑ confirmTx/lcp: +1388%
  • ↑ bridgeUserActions/bridge_load_page: +289%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +136%
  • ↑ bridgeUserActions/bridge_search_token: +22%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +63%
  • ↑ bridgeUserActions/inp: +54%
  • ↓ bridgeUserActions/fcp: -35%
  • ↑ bridgeUserActions/lcp: +1278%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 loadNewAccount/LCP: p75 2.5s
  • 🟡 confirmTx/FCP: p75 2.0s
  • 🟡 confirmTx/LCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +14%
  • ↑ startupStandardHome/load: +12%
  • ↑ startupStandardHome/domContentLoaded: +12%
  • ↑ startupStandardHome/domInteractive: +24%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +11%
  • ↑ startupStandardHome/setupStore: +121%
  • ↓ startupStandardHome/longTaskCount: -29%
  • ↑ startupStandardHome/longTaskMaxDuration: +10%
  • ↑ startupStandardHome/tbt: +14%
  • ↑ startupStandardHome/fcp: +11%
  • ↑ startupStandardHome/lcp: +12%
  • ↑ startupStandardHome/cls: +400%
  • ↓ startupStandardHome/uiStartup: -20%
  • ↓ startupStandardHome/load: -13%
  • ↓ startupStandardHome/domContentLoaded: -15%
  • ↑ startupStandardHome/domInteractive: +13%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -13%
  • ↓ startupStandardHome/setupStore: -19%
  • ↑ startupStandardHome/fcp: +18%
  • ↓ startupStandardHome/lcp: -12%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +37%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +42%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +30%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +41%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -21%
  • ↓ onboardingNewWallet/createPwToRecoveryScreen: -16%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -43%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -75%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -72%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -61%
  • ↓ dappPageLoad/domContentLoaded: -20%
  • ↓ dappPageLoad/firstPaint: -47%
  • ↓ dappPageLoad/firstContentfulPaint: -47%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.24 MiB -15.18 KiB -0.10%
🚨 ui 19.33 MiB +50.28 KiB +0.25%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB -432 Bytes -0.01%
✅ content scripts 3.22 MiB -913 Bytes -0.03%
✅ unzipped 79.65 MiB -199.83 KiB -0.24%
✅ zip 23.81 MiB -251.12 KiB -1.02%

@metamask-ci

metamask-ci Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor
Builds ready [f3fdda9]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 5 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42077381299 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/inp: -18%
  • ↑ loadNewAccount/lcp: +958%
  • ↑ loadNewAccount/cls: +241%
  • ↑ confirmTx/longTaskTotalDuration: +36%
  • ↑ confirmTx/longTaskMaxDuration: +48%
  • ↑ confirmTx/tbt: +61%
  • ↓ confirmTx/inp: -21%
  • ↑ confirmTx/fcp: +11%
  • ↑ confirmTx/lcp: +1020%
  • ↓ confirmTx/cls: -12%
  • ↑ bridgeUserActions/bridge_load_page: +89%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +157%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +45%
  • ↑ bridgeUserActions/longTaskMaxDuration: +52%
  • ↑ bridgeUserActions/tbt: +101%
  • ↑ bridgeUserActions/total: +27%
  • ↑ bridgeUserActions/inp: +47%
  • ↑ bridgeUserActions/fcp: +13%
  • ↑ bridgeUserActions/lcp: +1018%
  • ↑ bridgeUserActions/cls: +594%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -10%
  • ↓ loadNewAccount/fcp: -37%
  • ↑ loadNewAccount/lcp: +1300%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -13%
  • ↓ confirmTx/fcp: -34%
  • ↑ confirmTx/lcp: +1359%
  • ↑ bridgeUserActions/bridge_load_page: +280%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +123%
  • ↑ bridgeUserActions/bridge_search_token: +28%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +73%
  • ↑ bridgeUserActions/inp: +62%
  • ↑ bridgeUserActions/fcp: +22%
  • ↑ bridgeUserActions/lcp: +1259%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 2.0s
  • 🟡 bridgeUserActions/FCP: p75 2.1s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +91%
  • ↑ startupStandardHome/load: +126%
  • ↑ startupStandardHome/domContentLoaded: +127%
  • ↑ startupStandardHome/domInteractive: +23%
  • ↓ startupStandardHome/firstPaint: -58%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +126%
  • ↑ startupStandardHome/setupStore: +134%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +125%
  • ↑ startupStandardHome/longTaskMaxDuration: +133%
  • ↑ startupStandardHome/tbt: +146%
  • ↓ startupStandardHome/inp: -11%
  • ↓ startupStandardHome/fcp: -48%
  • ↑ startupStandardHome/lcp: +134%
  • ↓ startupStandardHome/cls: -72%
  • ↑ startupStandardHome/domInteractive: +41%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/fcp: +46%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/confirmSrpToPwForm: +13%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +18%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -12%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -32%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -79%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -75%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -49%
  • ↓ dappPageLoad/firstPaint: -33%
  • ↓ dappPageLoad/firstContentfulPaint: -33%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +580 Bytes 0.00%
✅ ui 19.39 MiB +207 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.44 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.73 MiB +792 Bytes 0.00%
✅ zip 23.83 MiB +248 Bytes 0.00%

davidmurdoch
davidmurdoch previously approved these changes Nov 5, 2026
@mcmire
mcmire enabled auto-merge November 5, 2026 19:43
@metamask-ci

metamask-ci Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor
Builds ready [c7890ec]
⚡ Performance Benchmarks (Total: 🟢 10 pass · 🟡 1 warn · 🔴 2 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42240108604 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -10%
  • ↑ loadNewAccount/lcp: +866%
  • ↑ loadNewAccount/cls: +294%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +50%
  • ↑ confirmTx/longTaskMaxDuration: +44%
  • ↑ confirmTx/tbt: +64%
  • ↓ confirmTx/inp: -29%
  • ↑ confirmTx/lcp: +889%
  • ↑ bridgeUserActions/bridge_load_page: +81%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +23%
  • ↑ bridgeUserActions/tbt: +20%
  • ↑ bridgeUserActions/lcp: +882%
  • ↑ bridgeUserActions/cls: +636%
  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/inp: -48%
  • ↓ loadNewAccount/fcp: -57%
  • ↑ loadNewAccount/lcp: +1025%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -29%
  • ↑ confirmTx/lcp: +1047%
  • ↑ bridgeUserActions/bridge_load_page: +198%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +199%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +51%
  • ↑ bridgeUserActions/inp: +25%
  • ↓ bridgeUserActions/fcp: -50%
  • ↑ bridgeUserActions/lcp: +1013%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +20%
  • ↑ startupStandardHome/load: +40%
  • ↑ startupStandardHome/domContentLoaded: +41%
  • ↓ startupStandardHome/firstPaint: -48%
  • ↓ startupStandardHome/backgroundConnect: -25%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -64%
  • ↑ startupStandardHome/loadScripts: +39%
  • ↑ startupStandardHome/setupStore: +30%
  • ↑ startupStandardHome/numNetworkReqs: +11%
  • ↑ startupStandardHome/longTaskTotalDuration: +35%
  • ↑ startupStandardHome/longTaskMaxDuration: +60%
  • ↑ startupStandardHome/tbt: +46%
  • ↓ startupStandardHome/inp: -37%
  • ↑ startupStandardHome/fcp: +35%
  • ↑ startupStandardHome/lcp: +508%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/domInteractive: -34%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/fcp: -31%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +19%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +58%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +46%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +16%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -91%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +16%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +32%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +14%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -71%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -73%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -35%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -67%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -54%
  • ↓ dappPageLoad/firstPaint: -33%
  • ↓ dappPageLoad/firstContentfulPaint: -33%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +580 Bytes 0.00%
✅ ui 19.42 MiB +207 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.77 MiB +792 Bytes 0.00%
✅ zip 23.86 MiB +259 Bytes 0.00%

@metamask-ci

metamask-ci Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor
Builds ready [d7f62d5]
⚡ Performance Benchmarks (Total: 🟢 10 pass · 🟡 0 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42562947754 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -33%
  • ↓ loadNewAccount/fcp: -18%
  • ↑ loadNewAccount/lcp: +702%
  • ↑ loadNewAccount/cls: +294%
  • ↑ confirmTx/longTaskTotalDuration: +10%
  • ↑ confirmTx/longTaskMaxDuration: +22%
  • ↑ confirmTx/tbt: +19%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -18%
  • ↑ confirmTx/lcp: +720%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +34%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +36%
  • ↑ bridgeUserActions/tbt: +37%
  • ↓ bridgeUserActions/inp: -19%
  • ↓ bridgeUserActions/fcp: -16%
  • ↑ bridgeUserActions/lcp: +727%
  • ↑ bridgeUserActions/cls: +611%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -10%
  • ↓ loadNewAccount/fcp: -51%
  • ↑ loadNewAccount/lcp: +1014%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -61%
  • ↑ confirmTx/lcp: +1033%
  • ↑ bridgeUserActions/bridge_load_page: +174%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +55%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +26%
  • ↑ bridgeUserActions/inp: +25%
  • ↓ bridgeUserActions/fcp: -51%
  • ↑ bridgeUserActions/lcp: +1013%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +85%
  • ↑ startupStandardHome/load: +119%
  • ↑ startupStandardHome/domContentLoaded: +120%
  • ↑ startupStandardHome/domInteractive: +22%
  • ↓ startupStandardHome/firstPaint: -55%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +118%
  • ↑ startupStandardHome/setupStore: +127%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +117%
  • ↑ startupStandardHome/longTaskMaxDuration: +121%
  • ↑ startupStandardHome/tbt: +140%
  • ↓ startupStandardHome/inp: -11%
  • ↓ startupStandardHome/fcp: -51%
  • ↑ startupStandardHome/lcp: +121%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/domInteractive: -39%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/fcp: -34%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -13%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +18%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -17%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +22%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +41%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +27%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -72%
  • ↓ onboardingNewWallet/longTaskCount: -23%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -64%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -13%
  • ↓ onboardingNewWallet/tbt: -91%
  • ↓ onboardingNewWallet/total: -67%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -61%
  • ↓ dappPageLoad/domContentLoaded: -20%
  • ↓ dappPageLoad/firstPaint: -47%
  • ↓ dappPageLoad/firstContentfulPaint: -47%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.26 MiB +580 Bytes 0.00%
✅ ui 19.42 MiB +207 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB 0 Bytes 0.00%
✅ content scripts 3.23 MiB 0 Bytes 0.00%
✅ unzipped 79.77 MiB +792 Bytes 0.00%
✅ zip 23.86 MiB +246 Bytes 0.00%

@sonarqubecloud

sonarqubecloud Bot commented Nov 9, 2026

Copy link
Copy Markdown

@MajorLift

Copy link
Copy Markdown
Contributor

Since distributed tracing with backend spans is in the works, one requested change for OTel propagation: Let's replace context with a traceparent string.

 export type SerializedTraceMetadata = {
   /**
-   * The originating UI span's serialized context.
+   * W3C `traceparent` of the originating UI span.
    */
-  context: SerializedTraceContext;
+  traceparent: string;

Why traceparent:

  • W3C Trace Context is OpenTelemetry's default propagation format (OTEL_PROPAGATORS defaults to tracecontext,baggage), so a traceparent passes to any W3C or OpenTelemetry propagator without translation. _traceId/_spanId mirror private fields on Sentry's span class.
  • traceparent carries the sampled flag. _traceId/_spanId drop it, so the background marks every continued UI trace as sampled, including traces the UI sampled out.
  • This isn't a destructive change. On this hop context only ever holds _traceId and _spanId (getSerializedTraceContext), and a traceparent carries both. Anything more the background needs later can sit beside it in _trace, as spanName and messengerAction do.

@mcmire

mcmire commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

@MajorLift Okay. Is it possible to make the change you requested in a future PR? I have a PR #47254 which this PR is blocking.

@MajorLift MajorLift left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few PRs fixing sentry trace code, but it looks like merging this as is should be fine. I'll handle the requested follow-up here: #43199

@mcmire
mcmire added this pull request to the merge queue Nov 9, 2026
Merged via the queue into main with commit 05e7f15 Nov 9, 2026
140 checks passed
@mcmire
mcmire deleted the fix-sentry-tracing-with-messenger-call branch November 9, 2026 17:12
@metamask-ci metamask-ci Bot mentioned this pull request Nov 13, 2026
10 of 18 tasks
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026

This branch was successfully deployed

1 active (outdated) and 1 inactive deployments
pr-comment — d7f62d5c Deployed Nov 9, 2026 by mcmire via Publish prerelease / Publish prerelease #173407
segment-schema — 8923a414 Deployed Oct 30, 2026 by mcmire via propose #1971
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-13.58.0 Issue or pull request that will be included in release 13.58.0 size-M team-core-platform Core Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants