Skip to content

feat: host-backed OHLCV pagination for older bars - #47753

Merged
sahar-fehri merged 55 commits into
mainfrom
feat/advanced-charts-pagination
Nov 12, 2026
Merged

sahar-fehri merged 55 commits into
mainfrom
feat/advanced-charts-pagination

Conversation

@sahar-fehri

@sahar-fehri sahar-fehri commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Description

Pagination PR (3/3, top of the stack) for the Token Details Page advanced charts work. Stacked on #47751 (chart UI), which is stacked on #47749 (foundation).

Adds host-backed ("RN-backed") pagination of older OHLCV bars so the chart can load more history as the user scrolls back in time, without granting the sandboxed chart iframe any network access:

  • The initial bulk data (SET_OHLCV_DATA) now carries an rnBackedPagination: { enabled: true } flag, telling the engine to request older bars from the host rather than fetching them itself.
  • When the user scrolls to the edge of loaded data, the iframe posts a FETCH_OLDER_BARS_REQUEST (with requestId, seriesGeneration, symbol/resolution/window). The host (advanced-chart-iframe.tsx) fetches the next older page from the Price API by cursor and replies with FETCH_OLDER_BARS_RESPONSE; the engine echo-guards on seriesGeneration, dedupes, and prepends the bars.
  • useOHLCVChart gains cursor-aware paging (fetchOHLCVPage + a stable fetchOlderBars), surfaced through useAdvancedChartData and wired down via advanced-chart-section.
  • Paging terminates cleanly when the API reports no more data (one cheap terminal round-trip, no wasted fetch).

All changes are confined to the 8 chart files already introduced in #47751. Still gated behind the AdvancedCharts remote feature flag.

Base branch: feat/advanced-charts-ui (#47751).

Changelog

CHANGELOG entry: Added loading of older historical data when scrolling back on the token details page chart.

Manual testing steps

  1. Enable the AdvancedCharts remote feature flag, then build and run the extension.
  2. Unlock the wallet and open a token details page for an asset with a long price history.
  3. With the candlestick chart shown, scroll/drag the chart back in time toward the oldest loaded candle.
  4. Verify older candles load and prepend as you keep scrolling back (the chart extends further into the past).
  5. Keep scrolling until history is exhausted and confirm it stops gracefully (no errors, no infinite spinner, no duplicated candles).
  6. Switch interval/token and repeat to confirm paging restarts correctly for the new series.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches OHLCV fetch/pagination and iframe messaging; mistakes could show wrong history or mishandle series switches, but changes stay behind Advanced Charts and include thorough tests.

Overview
Adds host-backed pagination so users can scroll the token-details candlestick chart further into the past without letting the sandboxed chart iframe perform network requests (blocked by CSP).

Data layer: useOHLCVChart now pages via fetchOHLCVPage (cursor + hasNext from the Price API) and exposes a stable fetchOlderBars that advances the cursor, short-circuits when history is exhausted, and drops stale pages if the asset/interval/currency series changes mid-flight. useAdvancedChartData passes this through to AdvancedChartSection and AdvancedChartIframe.

Iframe bridge: Full SET_OHLCV_DATA payloads include rnBackedPagination: { enabled: true }. When the engine sends FETCH_OLDER_BARS_REQUEST, the host invokes fetchOlderBars and replies with FETCH_OLDER_BARS_RESPONSE (echoing requestId / seriesGeneration, or noData on error/missing callback).

Tests cover the new postMessage contract, cursor paging, and wiring mocks across section/data hooks.

Reviewed by Cursor Bugbot for commit f79ea21. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci

metamask-ci Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor
Builds ready [b37650e]
⚡ Performance Benchmarks (Total: 🟢 4 pass · 🟡 5 warn · 🔴 4 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42648067317 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -18%
  • ↑ loadNewAccount/fcp: +13%
  • ↑ loadNewAccount/lcp: +1013%
  • ↑ loadNewAccount/cls: +297%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +53%
  • ↑ confirmTx/longTaskMaxDuration: +54%
  • ↑ confirmTx/tbt: +69%
  • ↓ confirmTx/inp: -21%
  • ↑ confirmTx/fcp: +11%
  • ↑ confirmTx/lcp: +1020%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +100%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +78%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +101%
  • ↑ bridgeUserActions/longTaskMaxDuration: +48%
  • ↑ bridgeUserActions/tbt: +203%
  • ↑ bridgeUserActions/total: +20%
  • ↑ bridgeUserActions/inp: +10%
  • ↑ bridgeUserActions/lcp: +954%
  • ↑ bridgeUserActions/cls: +577%
  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↓ loadNewAccount/inp: -25%
  • ↑ loadNewAccount/fcp: +24%
  • ↑ loadNewAccount/lcp: +1267%
  • ↑ confirmTx/confirm_tx: +12%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/total: +12%
  • ↑ confirmTx/fcp: +27%
  • ↑ confirmTx/lcp: +1353%
  • ↑ bridgeUserActions/bridge_load_page: +261%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +111%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +63%
  • ↑ bridgeUserActions/inp: +69%
  • ↓ bridgeUserActions/fcp: -31%
  • ↑ bridgeUserActions/lcp: +1342%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 loadNewAccount/FCP: p75 2.1s
  • 🟡 confirmTx/FCP: p75 2.2s
  • 🟡 bridgeUserActions/LCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +79%
  • ↑ startupStandardHome/load: +110%
  • ↑ startupStandardHome/domContentLoaded: +111%
  • ↑ startupStandardHome/domInteractive: +26%
  • ↓ startupStandardHome/firstPaint: -43%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +109%
  • ↑ startupStandardHome/setupStore: +121%
  • ↑ startupStandardHome/numNetworkReqs: +11%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +107%
  • ↑ startupStandardHome/longTaskMaxDuration: +120%
  • ↑ startupStandardHome/tbt: +130%
  • ↓ startupStandardHome/fcp: -47%
  • ↑ startupStandardHome/lcp: +139%
  • ↓ startupStandardHome/cls: -72%
  • ↑ startupStandardHome/load: +11%
  • ↑ startupStandardHome/domInteractive: +45%
  • ↑ startupStandardHome/backgroundConnect: +19%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/loadScripts: +10%
  • ↑ startupStandardHome/setupStore: +19%
  • ↑ startupStandardHome/fcp: +49%
  • ↑ startupStandardHome/lcp: +14%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +20%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +39%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +51%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +31%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -82%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -94%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -88%
  • ↓ onboardingImportWallet/tbt: -98%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -11%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -25%
  • ↓ onboardingNewWallet/createPwToRecoveryScreen: -12%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -37%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -78%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -74%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -49%
  • ↓ dappPageLoad/firstPaint: -28%
  • ↓ dappPageLoad/firstContentfulPaint: -28%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
🚨 background 15.25 MiB +10.8 KiB +0.07%
🚨 ui 19.48 MiB +40.71 KiB +0.20%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +139 Bytes 0.00%
✅ content scripts 3.23 MiB +278 Bytes +0.01%
🚨 unzipped 79.93 MiB +52.64 KiB +0.06%
🚨 zip 23.98 MiB +16.2 KiB +0.07%

@sahar-fehri
sahar-fehri force-pushed the feat/advanced-charts-pagination branch from b37650e to 34de087 Compare November 9, 2026 16:07
@sahar-fehri
sahar-fehri marked this pull request as ready for review November 9, 2026 16:08

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@metamask-ci

metamask-ci Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor
Builds ready [34de087]
⚡ Performance Benchmarks (Total: 🟢 4 pass · 🟡 7 warn · 🔴 2 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42651535298 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↑ loadNewAccount/lcp: +972%
  • ↑ loadNewAccount/cls: +297%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +62%
  • ↑ confirmTx/longTaskMaxDuration: +62%
  • ↑ confirmTx/tbt: +85%
  • ↑ confirmTx/lcp: +1003%
  • ↑ bridgeUserActions/bridge_load_page: +119%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +89%
  • ↑ bridgeUserActions/longTaskCount: +82%
  • ↑ bridgeUserActions/longTaskTotalDuration: +127%
  • ↑ bridgeUserActions/longTaskMaxDuration: +40%
  • ↑ bridgeUserActions/tbt: +196%
  • ↑ bridgeUserActions/total: +25%
  • ↑ bridgeUserActions/inp: +18%
  • ↑ bridgeUserActions/lcp: +984%
  • ↑ bridgeUserActions/cls: +387%
  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↓ loadNewAccount/inp: -18%
  • ↑ loadNewAccount/fcp: +21%
  • ↑ loadNewAccount/lcp: +1319%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -13%
  • ↑ confirmTx/fcp: +26%
  • ↑ confirmTx/lcp: +1410%
  • ↑ bridgeUserActions/bridge_load_page: +212%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +117%
  • ↑ bridgeUserActions/bridge_search_token: +24%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +59%
  • ↑ bridgeUserActions/inp: +62%
  • ↑ bridgeUserActions/fcp: +20%
  • ↑ bridgeUserActions/lcp: +1325%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 loadNewAccount/FCP: p75 2.1s
  • 🟡 loadNewAccount/LCP: p75 2.5s
  • 🟡 confirmTx/FCP: p75 2.2s
  • 🟡 confirmTx/LCP: p75 2.6s
  • 🟡 bridgeUserActions/FCP: p75 2.1s
  • 🟡 bridgeUserActions/LCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +36%
  • ↑ startupStandardHome/load: +59%
  • ↑ startupStandardHome/domContentLoaded: +59%
  • ↓ startupStandardHome/firstPaint: -40%
  • ↓ startupStandardHome/backgroundConnect: -22%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +58%
  • ↑ startupStandardHome/setupStore: +75%
  • ↑ startupStandardHome/longTaskTotalDuration: +54%
  • ↑ startupStandardHome/longTaskMaxDuration: +84%
  • ↑ startupStandardHome/tbt: +70%
  • ↓ startupStandardHome/inp: -24%
  • ↑ startupStandardHome/fcp: +54%
  • ↑ startupStandardHome/lcp: +593%
  • ↓ startupStandardHome/cls: -72%
  • ↑ startupStandardHome/backgroundConnect: +16%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/lcp: +10%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +21%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +38%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +59%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +19%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -91%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -73%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +12%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -14%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -78%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -74%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -48%
  • ↓ dappPageLoad/firstPaint: -28%
  • ↓ dappPageLoad/firstContentfulPaint: -28%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
🚨 background 15.25 MiB +10.8 KiB +0.07%
🚨 ui 19.48 MiB +40.74 KiB +0.20%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +139 Bytes 0.00%
✅ content scripts 3.23 MiB +278 Bytes +0.01%
🚨 unzipped 79.93 MiB +52.68 KiB +0.06%
🚨 zip 23.98 MiB +16.21 KiB +0.07%

@metamask-ci

metamask-ci Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor
Builds ready [bf41a7c]
⚡ Performance Benchmarks (Total: 🟢 9 pass · 🟡 1 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43189681394 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/inp: -18%
  • ↓ loadNewAccount/fcp: -16%
  • ↑ loadNewAccount/lcp: +727%
  • ↑ loadNewAccount/cls: +294%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +32%
  • ↑ confirmTx/longTaskMaxDuration: +30%
  • ↑ confirmTx/tbt: +38%
  • ↓ confirmTx/inp: -29%
  • ↓ confirmTx/fcp: -14%
  • ↑ confirmTx/lcp: +763%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +56%
  • ↓ bridgeUserActions/longTaskTotalDuration: -12%
  • ↓ bridgeUserActions/longTaskMaxDuration: -12%
  • ↓ bridgeUserActions/tbt: -15%
  • ↓ bridgeUserActions/inp: -12%
  • ↓ bridgeUserActions/fcp: -17%
  • ↑ bridgeUserActions/lcp: +724%
  • ↑ bridgeUserActions/cls: +634%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -10%
  • ↑ loadNewAccount/fcp: +17%
  • ↑ loadNewAccount/lcp: +1253%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -13%
  • ↓ confirmTx/fcp: -31%
  • ↑ confirmTx/lcp: +1310%
  • ↑ bridgeUserActions/bridge_load_page: +224%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +130%
  • ↑ bridgeUserActions/bridge_search_token: +27%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +62%
  • ↑ bridgeUserActions/inp: +54%
  • ↑ bridgeUserActions/fcp: +23%
  • ↑ bridgeUserActions/lcp: +1280%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.0s
  • 🟡 bridgeUserActions/FCP: p75 2.1s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +89%
  • ↑ startupStandardHome/load: +122%
  • ↑ startupStandardHome/domContentLoaded: +123%
  • ↑ startupStandardHome/domInteractive: +25%
  • ↓ startupStandardHome/firstPaint: -55%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +122%
  • ↑ startupStandardHome/setupStore: +140%
  • ↑ startupStandardHome/numNetworkReqs: +11%
  • ↑ startupStandardHome/longTaskCount: +79%
  • ↑ startupStandardHome/longTaskTotalDuration: +124%
  • ↑ startupStandardHome/longTaskMaxDuration: +132%
  • ↑ startupStandardHome/tbt: +144%
  • ↓ startupStandardHome/inp: -11%
  • ↓ startupStandardHome/fcp: -50%
  • ↑ startupStandardHome/lcp: +124%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -16%
  • ↓ startupStandardHome/load: -10%
  • ↓ startupStandardHome/domContentLoaded: -13%
  • ↑ startupStandardHome/domInteractive: +28%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -11%
  • ↑ startupStandardHome/fcp: +25%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -20%
  • ↓ onboardingImportWallet/confirmSrpToPwForm: -21%
  • ↓ onboardingImportWallet/pwFormToMetricsScreen: -13%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -41%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -86%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +24%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +15%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +10%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -73%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -69%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -60%
  • ↓ dappPageLoad/domContentLoaded: -19%
  • ↓ dappPageLoad/firstPaint: -47%
  • ↓ dappPageLoad/firstContentfulPaint: -47%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.22 MiB +806 Bytes +0.01%
🚨 ui 19.54 MiB +43.04 KiB +0.22%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +76 Bytes 0.00%
✅ content scripts 3.22 MiB +152 Bytes 0.00%
🚨 unzipped 79.97 MiB +45.56 KiB +0.06%
🚨 zip 24.03 MiB +15.21 KiB +0.06%

@Prithpal-Sooriya
Prithpal-Sooriya removed request for a team November 12, 2026 11:17
juanmigdr
juanmigdr previously approved these changes Nov 12, 2026

@juanmigdr juanmigdr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, LGTM!

salimtb
salimtb previously approved these changes Nov 12, 2026
Base automatically changed from feat/advanced-charts-ui to main November 12, 2026 12:12
dawnseeker8
dawnseeker8 previously approved these changes Nov 12, 2026

@dawnseeker8 dawnseeker8 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metamask-ci

metamask-ci Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor
Builds ready [f79ea21]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43225948347 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/inp: -33%
  • ↓ loadNewAccount/fcp: -16%
  • ↑ loadNewAccount/lcp: +723%
  • ↑ loadNewAccount/cls: +485%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +32%
  • ↑ confirmTx/longTaskMaxDuration: +21%
  • ↑ confirmTx/tbt: +34%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -18%
  • ↑ confirmTx/lcp: +725%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +27%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +30%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +46%
  • ↑ bridgeUserActions/tbt: +63%
  • ↓ bridgeUserActions/inp: -12%
  • ↓ bridgeUserActions/fcp: -10%
  • ↑ bridgeUserActions/lcp: +786%
  • ↑ bridgeUserActions/cls: +387%
  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↑ loadNewAccount/fcp: +19%
  • ↑ loadNewAccount/lcp: +1283%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -13%
  • ↑ confirmTx/fcp: +23%
  • ↑ confirmTx/lcp: +1352%
  • ↑ bridgeUserActions/bridge_load_page: +234%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +127%
  • ↑ bridgeUserActions/bridge_search_token: +69%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +92%
  • ↑ bridgeUserActions/inp: +54%
  • ↑ bridgeUserActions/fcp: +22%
  • ↑ bridgeUserActions/lcp: +1287%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.1s
  • 🟡 confirmTx/FCP: p75 2.1s
  • 🟡 bridgeUserActions/FCP: p75 2.1s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +98%
  • ↑ startupStandardHome/load: +133%
  • ↑ startupStandardHome/domContentLoaded: +134%
  • ↑ startupStandardHome/domInteractive: +28%
  • ↓ startupStandardHome/firstPaint: -48%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +132%
  • ↑ startupStandardHome/setupStore: +147%
  • ↑ startupStandardHome/longTaskCount: +79%
  • ↑ startupStandardHome/longTaskTotalDuration: +135%
  • ↑ startupStandardHome/longTaskMaxDuration: +145%
  • ↑ startupStandardHome/tbt: +159%
  • ↓ startupStandardHome/fcp: -46%
  • ↑ startupStandardHome/lcp: +141%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +16%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +27%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +32%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +25%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -91%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -82%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -95%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -90%
  • ↓ onboardingImportWallet/tbt: -99%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -11%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -32%
  • ↓ onboardingNewWallet/createPwToRecoveryScreen: -10%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -13%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -51%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -77%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -73%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -49%
  • ↓ dappPageLoad/firstPaint: -33%
  • ↓ dappPageLoad/firstContentfulPaint: -33%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.23 MiB +115 Bytes 0.00%
🚨 ui 19.51 MiB +1.46 KiB +0.01%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB 0 Bytes 0.00%
✅ content scripts 3.2 MiB 0 Bytes 0.00%
🚨 unzipped 79.93 MiB +1.58 KiB 0.00%
✅ zip 24.02 MiB +554 Bytes 0.00%

@sonarqubecloud

Copy link
Copy Markdown

@dawnseeker8 dawnseeker8 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sahar-fehri
sahar-fehri added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit b4fbb14 Nov 12, 2026
140 checks passed
@sahar-fehri
sahar-fehri deleted the feat/advanced-charts-pagination branch November 12, 2026 14:25
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 12, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026

This branch was previously deployed

1 inactive deployment
pr-comment — f79ea215 Deployed Nov 12, 2026 by sahar-fehri via Publish prerelease / Publish prerelease #174312
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.58.0 Issue or pull request that will be included in release 13.58.0 size-L team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants