Skip to content

feat: add chart-type preference, OHLCV service wiring - #47749

Merged
sahar-fehri merged 3 commits into
mainfrom
feat/advanced-charts-foundation
Nov 11, 2026
Merged

sahar-fehri merged 3 commits into
mainfrom
feat/advanced-charts-foundation

Conversation

@sahar-fehri

@sahar-fehri sahar-fehri commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Description

Foundation PR (1/5) for the Token Details Page (TDP) advanced charts work. This splits the original #47737 into five reviewable, stacked PRs:

  1. feat: add chart-type preference, OHLCV service wiring #47749 (this PR) — background/state foundation
  2. feat: advanced candlestick chart UI on the token details page #47751 — chart UI
  3. feat: host-backed OHLCV pagination for older bars #47753 — host-backed OHLCV pagination
  4. feat: color the line chart by range direction behind a theming flag #47771 — chart theming (line/candle colors driven by design tokens)
  5. feat: instrument advanced chart interactions and empty state #47772 — chart analytics/instrumentation (interaction + empty-state events)

This PR contains no user-facing UI on its own; the advanced chart is rendered in the UI PR (#47751) and stays behind the AdvancedCharts remote feature flag. Landing it first keeps the CODEOWNER-reviewed surface (background controller wiring, fixtures, privacy/state-logs) small and isolated.

What it includes:

  • Chart-type preference on PreferencesController (plus shared/types/preferences.ts and shared/lib/selectors/preferences.ts selector) so the TDP can persist the user's candle/line choice.
  • OHLCV service wiring into the background: the @metamask/core-backend OHLCV service and its messenger are registered via app/scripts/messenger-client-init/* and metamask-controller.js.
  • Fixtures & state snapshots (default-fixture.json, onboarding-fixture.json, metrics state snapshots, state-logs.json) updated to reflect the new controller state.

Base branch: main.

Changelog

CHANGELOG entry: null

Manual testing steps

Since this PR adds no visible UI, testing is a no-regression smoke check:

  1. Build and run the extension.
  2. Complete onboarding / unlock an existing wallet.
  3. Confirm the wallet loads normally (home, asset list, settings) with no errors in the background or UI console.
  4. Open a token details page and confirm the existing (legacy) price chart still renders as before.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches persisted preferences, background service initialization, and LavaMoat policies; new OHLCV service may open backend connectivity when later UI/flags enable it, but this PR alone adds no visible surface.

Overview
Adds background/state foundation for Token Details Page advanced charts (no user-facing UI in this PR).

Chart preferences — PreferencesController and Preferences types now persist tdpChartType, tdpChartInterval, and tdpChartIndicators, with shared defaults in shared/constants/preferences and new selectors (getTdpChartType, getTdpChartInterval, getTdpChartIndicators) so controller defaults and UI fallbacks stay aligned. Controller tests, fixtures, metrics snapshots, and state-logs schemas are updated for the new fields.

OHLCV streaming — Registers @metamask/core-backend OHLCVService in the background via OHLCVServiceInit, a restricted getOHLCVServiceMessenger (core allow-lists), and metamask-controller / messenger factory wiring. LavaMoat webpack policies grant AbortController and async-mutex to core-backend for this dependency path.

Reviewed by Cursor Bugbot for commit 7f6d7d4. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the size-M label Nov 9, 2026
@metamask-ci

metamask-ci Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

🫰 @MetaMask/core-platform (1 files, +2 -0)
  • 📁 app/
    • 📁 scripts/
      • 📄 metamask-controller.js +2 -0

👨‍🔧 @MetaMask/extension-platform (2 files, +5 -0)
  • 📁 app/
    • 📁 scripts/
      • 📄 metamask-controller.js +2 -0
  • 📁 test/
    • 📁 e2e/
      • 📁 fixtures/
        • 📄 onboarding-fixture.json +3 -0

🕵️ @MetaMask/extension-privacy-reviewers (1 files, +3 -0)
  • 📁 test/
    • 📁 e2e/
      • 📁 tests/
        • 📁 settings/
          • 📄 state-logs.json +3 -0

📜 @MetaMask/policy-reviewers (8 files, +16 -0)
  • 📁 lavamoat/
    • 📁 webpack/
      • 📁 mv2/
        • 📁 beta/
          • 📄 policy.json +2 -0
        • 📁 experimental/
          • 📄 policy.json +2 -0
        • 📁 flask/
          • 📄 policy.json +2 -0
        • 📁 main/
          • 📄 policy.json +2 -0
      • 📁 mv3/
        • 📁 beta/
          • 📄 policy.json +2 -0
        • 📁 experimental/
          • 📄 policy.json +2 -0
        • 📁 flask/
          • 📄 policy.json +2 -0
        • 📁 main/
          • 📄 policy.json +2 -0

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.


🧪 @MetaMask/qa (2 files, +6 -0)
  • 📁 test/
    • 📁 e2e/
      • 📁 fixtures/
        • 📄 onboarding-fixture.json +3 -0
      • 📁 tests/
        • 📁 settings/
          • 📄 state-logs.json +3 -0

@sahar-fehri sahar-fehri changed the title feat(asset-chart): add chart-type preference, OHLCV service wiring, a… feat: add chart-type preference, OHLCV service wiring Nov 9, 2026
@sahar-fehri
sahar-fehri added this pull request to stack #47752 November 9, 2026 15:33
@sahar-fehri

Copy link
Copy Markdown
Contributor Author

@metamaskbot update-policies

@metamask-ci

metamask-ci Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Policies updated.
👀 Please review the diff for suspicious new powers.

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.
🧠 Learn how to read policy diffs: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

👀 lavamoat/webpack/mv2/beta/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes
👀 lavamoat/webpack/mv2/experimental/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes
👀 lavamoat/webpack/mv2/flask/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes
👀 lavamoat/webpack/mv3/beta/policy.json changes differ from lavamoat/webpack/mv3/main/policy.json changes
👀 lavamoat/webpack/mv3/experimental/policy.json changes differ from lavamoat/webpack/mv3/main/policy.json changes
👀 lavamoat/webpack/mv3/flask/policy.json changes differ from lavamoat/webpack/mv3/main/policy.json changes

@sahar-fehri
sahar-fehri force-pushed the feat/advanced-charts-foundation branch from 1154fa7 to 65c0f08 Compare November 9, 2026 15:46
@sahar-fehri
sahar-fehri marked this pull request as ready for review November 9, 2026 15:50
@sahar-fehri
sahar-fehri requested review from a team as code owners November 9, 2026 15:50

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 65c0f08. Configure here.

@metamask-ci

metamask-ci Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor
Builds ready [65c0f08]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 3 warn · 🔴 4 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42648067842 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -18%
  • ↑ loadNewAccount/lcp: +943%
  • ↑ loadNewAccount/cls: +596%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +48%
  • ↑ confirmTx/longTaskMaxDuration: +44%
  • ↑ confirmTx/tbt: +67%
  • ↓ confirmTx/inp: -21%
  • ↑ confirmTx/lcp: +957%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +101%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +47%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +77%
  • ↑ bridgeUserActions/longTaskMaxDuration: +29%
  • ↑ bridgeUserActions/tbt: +142%
  • ↑ bridgeUserActions/total: +18%
  • ↑ bridgeUserActions/inp: +10%
  • ↑ bridgeUserActions/lcp: +932%
  • ↑ bridgeUserActions/cls: +634%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -25%
  • ↓ loadNewAccount/fcp: -30%
  • ↑ loadNewAccount/lcp: +1963%
  • ↑ confirmTx/confirm_tx: +11%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/total: +11%
  • ↓ confirmTx/inp: -13%
  • ↓ confirmTx/fcp: -28%
  • ↑ confirmTx/lcp: +1403%
  • ↑ bridgeUserActions/bridge_load_page: +224%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +130%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +34%
  • ↑ bridgeUserActions/inp: +62%
  • ↓ bridgeUserActions/fcp: -30%
  • ↑ bridgeUserActions/lcp: +1318%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.8s
  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 1.8s
  • 🟡 loadNewAccount/LCP: p75 3.6s
  • 🟡 confirmTx/LCP: p75 2.6s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +47%
  • ↑ startupStandardHome/load: +72%
  • ↑ startupStandardHome/domContentLoaded: +73%
  • ↓ startupStandardHome/firstPaint: -55%
  • ↓ startupStandardHome/backgroundConnect: -15%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +71%
  • ↑ startupStandardHome/setupStore: +75%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +69%
  • ↑ startupStandardHome/longTaskMaxDuration: +79%
  • ↑ startupStandardHome/tbt: +84%
  • ↓ startupStandardHome/inp: -18%
  • ↓ startupStandardHome/fcp: -55%
  • ↑ startupStandardHome/lcp: +101%
  • ↓ startupStandardHome/cls: -72%
  • ↑ startupStandardHome/domInteractive: +46%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/fcp: +48%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +11%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +24%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +32%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +18%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -73%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -12%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -29%
  • ↓ onboardingNewWallet/createPwToRecoveryScreen: -13%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -42%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -76%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -73%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -50%
  • ↓ dappPageLoad/firstPaint: -33%
  • ↓ dappPageLoad/firstContentfulPaint: -33%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
🚨 background 15.25 MiB +10.43 KiB +0.07%
✅ ui 19.44 MiB +197 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +70 Bytes 0.00%
✅ content scripts 3.23 MiB +140 Bytes 0.00%
🚨 unzipped 79.89 MiB +10.83 KiB +0.01%
🚨 zip 23.97 MiB +2.16 KiB +0.01%

@metamask-ci

metamask-ci Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor
Builds ready [29f07c1]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 5 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42651535318 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↓ loadNewAccount/inp: -25%
  • ↑ loadNewAccount/lcp: +954%
  • ↑ loadNewAccount/cls: +297%
  • ↑ confirmTx/longTaskCount: +67%
  • ↑ confirmTx/longTaskTotalDuration: +76%
  • ↑ confirmTx/longTaskMaxDuration: +48%
  • ↑ confirmTx/tbt: +85%
  • ↓ confirmTx/inp: -13%
  • ↑ confirmTx/fcp: +11%
  • ↑ confirmTx/lcp: +1013%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +161%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +54%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +71%
  • ↑ bridgeUserActions/tbt: +30%
  • ↑ bridgeUserActions/total: +22%
  • ↑ bridgeUserActions/inp: +10%
  • ↑ bridgeUserActions/lcp: +943%
  • ↑ bridgeUserActions/cls: +634%
  • ↑ loadNewAccount/load_new_account: +184%
  • ↑ loadNewAccount/total: +184%
  • ↓ loadNewAccount/inp: -10%
  • ↓ loadNewAccount/fcp: -34%
  • ↑ loadNewAccount/lcp: +1292%
  • ↑ confirmTx/confirm_tx: +11%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/total: +11%
  • ↑ confirmTx/fcp: +31%
  • ↑ confirmTx/lcp: +1363%
  • ↑ bridgeUserActions/bridge_load_page: +257%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +148%
  • ↑ bridgeUserActions/bridge_search_token: +36%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +68%
  • ↑ bridgeUserActions/inp: +62%
  • ↑ bridgeUserActions/fcp: +23%
  • ↑ bridgeUserActions/lcp: +1319%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.8s
  • 🟡 confirmTx/FCP: p75 2.3s
  • 🟡 confirmTx/LCP: p75 2.5s
  • 🟡 bridgeUserActions/FCP: p75 2.1s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +87%
  • ↑ startupStandardHome/load: +121%
  • ↑ startupStandardHome/domContentLoaded: +123%
  • ↑ startupStandardHome/domInteractive: +28%
  • ↓ startupStandardHome/firstPaint: -55%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +121%
  • ↑ startupStandardHome/setupStore: +140%
  • ↑ startupStandardHome/longTaskCount: +79%
  • ↑ startupStandardHome/longTaskTotalDuration: +119%
  • ↑ startupStandardHome/longTaskMaxDuration: +125%
  • ↑ startupStandardHome/tbt: +141%
  • ↓ startupStandardHome/fcp: -50%
  • ↑ startupStandardHome/lcp: +124%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -26%
  • ↓ startupStandardHome/load: -20%
  • ↓ startupStandardHome/domContentLoaded: -23%
  • ↓ startupStandardHome/domInteractive: -16%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -21%
  • ↓ startupStandardHome/setupStore: -30%
  • ↑ startupStandardHome/inp: +50%
  • ↓ startupStandardHome/lcp: -18%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +12%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -14%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +31%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +16%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -12%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -72%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -68%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -49%
  • ↓ dappPageLoad/firstPaint: -28%
  • ↓ dappPageLoad/firstContentfulPaint: -28%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
🚨 background 15.25 MiB +10.43 KiB +0.07%
✅ ui 19.44 MiB +197 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +70 Bytes 0.00%
✅ content scripts 3.23 MiB +140 Bytes 0.00%
🚨 unzipped 79.88 MiB +10.83 KiB +0.01%
🚨 zip 23.97 MiB +2.16 KiB +0.01%

Comment thread lavamoat/webpack/mv2/beta/policy.json Resolved

@Prithpal-Sooriya Prithpal-Sooriya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Policy Files LGTM

@metamask-ci

metamask-ci Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor
Builds ready [c5f9d5e]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43004266481 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +179%
  • ↑ loadNewAccount/total: +179%
  • ↓ loadNewAccount/inp: -55%
  • ↓ loadNewAccount/fcp: -35%
  • ↑ loadNewAccount/lcp: +537%
  • ↑ loadNewAccount/cls: +294%
  • ↑ confirmTx/longTaskCount: +33%
  • ↓ confirmTx/longTaskTotalDuration: -12%
  • ↓ confirmTx/tbt: -18%
  • ↓ confirmTx/inp: -44%
  • ↓ confirmTx/fcp: -38%
  • ↑ confirmTx/lcp: +522%
  • ↓ bridgeUserActions/bridge_load_page: -19%
  • ↓ bridgeUserActions/bridge_load_asset_picker: -26%
  • ↓ bridgeUserActions/bridge_search_token: -12%
  • ↓ bridgeUserActions/longTaskTotalDuration: -36%
  • ↓ bridgeUserActions/longTaskMaxDuration: -43%
  • ↓ bridgeUserActions/tbt: -82%
  • ↓ bridgeUserActions/total: -14%
  • ↓ bridgeUserActions/inp: -41%
  • ↓ bridgeUserActions/fcp: -37%
  • ↑ bridgeUserActions/lcp: +519%
  • ↑ bridgeUserActions/cls: +634%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -10%
  • ↑ loadNewAccount/fcp: +21%
  • ↑ loadNewAccount/lcp: +1272%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/fcp: +25%
  • ↑ confirmTx/lcp: +1325%
  • ↑ bridgeUserActions/bridge_load_page: +249%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +163%
  • ↑ bridgeUserActions/bridge_search_token: +29%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +61%
  • ↑ bridgeUserActions/inp: +128%
  • ↑ bridgeUserActions/fcp: +17%
  • ↑ bridgeUserActions/lcp: +1367%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.1s
  • 🟡 confirmTx/FCP: p75 2.1s
  • 🟡 bridgeUserActions/INP: p75 248ms
  • 🟡 bridgeUserActions/FCP: p75 2.0s
  • 🟡 bridgeUserActions/LCP: p75 2.6s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +26%
  • ↑ startupStandardHome/load: +48%
  • ↑ startupStandardHome/domContentLoaded: +48%
  • ↓ startupStandardHome/firstPaint: -38%
  • ↓ startupStandardHome/backgroundConnect: -21%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -64%
  • ↑ startupStandardHome/loadScripts: +47%
  • ↑ startupStandardHome/setupStore: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +43%
  • ↑ startupStandardHome/longTaskMaxDuration: +68%
  • ↑ startupStandardHome/tbt: +54%
  • ↓ startupStandardHome/inp: -24%
  • ↑ startupStandardHome/fcp: +43%
  • ↑ startupStandardHome/lcp: +540%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -31%
  • ↓ startupStandardHome/load: -25%
  • ↓ startupStandardHome/domContentLoaded: -27%
  • ↓ startupStandardHome/backgroundConnect: -15%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -25%
  • ↓ startupStandardHome/setupStore: -24%
  • ↓ startupStandardHome/lcp: -23%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +24%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +27%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +36%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +17%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -18%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -11%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -40%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -78%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -74%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -60%
  • ↓ dappPageLoad/domContentLoaded: -18%
  • ↓ dappPageLoad/firstPaint: -42%
  • ↓ dappPageLoad/firstContentfulPaint: -42%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
🚨 background 15.22 MiB +10.14 KiB +0.07%
✅ ui 19.48 MiB +261 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +70 Bytes 0.00%
✅ content scripts 3.22 MiB +140 Bytes 0.00%
🚨 unzipped 79.91 MiB +10.61 KiB +0.01%
🚨 zip 24.01 MiB +2.26 KiB +0.01%

@metamask-ci

metamask-ci Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor
Builds ready [30b47dc] [reused from c5f9d5e]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43007334175 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +179%
  • ↑ loadNewAccount/total: +179%
  • ↓ loadNewAccount/inp: -55%
  • ↓ loadNewAccount/fcp: -35%
  • ↑ loadNewAccount/lcp: +537%
  • ↑ loadNewAccount/cls: +294%
  • ↑ confirmTx/longTaskCount: +33%
  • ↓ confirmTx/longTaskTotalDuration: -12%
  • ↓ confirmTx/tbt: -18%
  • ↓ confirmTx/inp: -44%
  • ↓ confirmTx/fcp: -38%
  • ↑ confirmTx/lcp: +522%
  • ↓ bridgeUserActions/bridge_load_page: -19%
  • ↓ bridgeUserActions/bridge_load_asset_picker: -26%
  • ↓ bridgeUserActions/bridge_search_token: -12%
  • ↓ bridgeUserActions/longTaskTotalDuration: -36%
  • ↓ bridgeUserActions/longTaskMaxDuration: -43%
  • ↓ bridgeUserActions/tbt: -82%
  • ↓ bridgeUserActions/total: -14%
  • ↓ bridgeUserActions/inp: -41%
  • ↓ bridgeUserActions/fcp: -37%
  • ↑ bridgeUserActions/lcp: +519%
  • ↑ bridgeUserActions/cls: +634%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -10%
  • ↑ loadNewAccount/fcp: +21%
  • ↑ loadNewAccount/lcp: +1272%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/fcp: +25%
  • ↑ confirmTx/lcp: +1325%
  • ↑ bridgeUserActions/bridge_load_page: +249%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +163%
  • ↑ bridgeUserActions/bridge_search_token: +29%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +61%
  • ↑ bridgeUserActions/inp: +128%
  • ↑ bridgeUserActions/fcp: +17%
  • ↑ bridgeUserActions/lcp: +1367%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.1s
  • 🟡 confirmTx/FCP: p75 2.1s
  • 🟡 bridgeUserActions/INP: p75 248ms
  • 🟡 bridgeUserActions/FCP: p75 2.0s
  • 🟡 bridgeUserActions/LCP: p75 2.6s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +26%
  • ↑ startupStandardHome/load: +48%
  • ↑ startupStandardHome/domContentLoaded: +48%
  • ↓ startupStandardHome/firstPaint: -38%
  • ↓ startupStandardHome/backgroundConnect: -21%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -64%
  • ↑ startupStandardHome/loadScripts: +47%
  • ↑ startupStandardHome/setupStore: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +43%
  • ↑ startupStandardHome/longTaskMaxDuration: +68%
  • ↑ startupStandardHome/tbt: +54%
  • ↓ startupStandardHome/inp: -24%
  • ↑ startupStandardHome/fcp: +43%
  • ↑ startupStandardHome/lcp: +540%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -31%
  • ↓ startupStandardHome/load: -25%
  • ↓ startupStandardHome/domContentLoaded: -27%
  • ↓ startupStandardHome/backgroundConnect: -15%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -25%
  • ↓ startupStandardHome/setupStore: -24%
  • ↓ startupStandardHome/lcp: -23%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +24%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +27%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +36%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +17%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↓ onboardingNewWallet/srpButtonToPwForm: -18%
  • ↓ onboardingNewWallet/skipBackupToMetricsScreen: -11%
  • ↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -40%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -78%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -74%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -60%
  • ↓ dappPageLoad/domContentLoaded: -18%
  • ↓ dappPageLoad/firstPaint: -42%
  • ↓ dappPageLoad/firstContentfulPaint: -42%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
🚨 background 15.22 MiB +10.14 KiB +0.07%
✅ ui 19.48 MiB +261 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +70 Bytes 0.00%
✅ content scripts 3.22 MiB +140 Bytes 0.00%
🚨 unzipped 79.91 MiB +10.61 KiB +0.01%
🚨 zip 24.01 MiB +2.26 KiB +0.01%

@metamask-ci

metamask-ci Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor
Builds ready [7f6d7d4]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 3 warn · 🔴 2 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43038349716 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +180%
  • ↑ loadNewAccount/total: +180%
  • ↓ loadNewAccount/inp: -33%
  • ↓ loadNewAccount/fcp: -19%
  • ↑ loadNewAccount/lcp: +693%
  • ↑ loadNewAccount/cls: +297%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +19%
  • ↑ confirmTx/longTaskMaxDuration: +17%
  • ↑ confirmTx/tbt: +19%
  • ↓ confirmTx/inp: -44%
  • ↓ confirmTx/fcp: -17%
  • ↑ confirmTx/lcp: +732%
  • ↑ bridgeUserActions/bridge_load_page: +31%
  • ↓ bridgeUserActions/longTaskTotalDuration: -21%
  • ↓ bridgeUserActions/longTaskMaxDuration: -26%
  • ↓ bridgeUserActions/tbt: -38%
  • ↓ bridgeUserActions/inp: -19%
  • ↓ bridgeUserActions/fcp: -17%
  • ↑ bridgeUserActions/lcp: +720%
  • ↑ bridgeUserActions/cls: +634%
  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↓ loadNewAccount/inp: -18%
  • ↑ loadNewAccount/fcp: +26%
  • ↑ loadNewAccount/lcp: +1283%
  • ↑ confirmTx/confirm_tx: +10%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↑ confirmTx/total: +10%
  • ↓ confirmTx/inp: -13%
  • ↑ confirmTx/fcp: +23%
  • ↑ confirmTx/lcp: +1273%
  • ↑ bridgeUserActions/bridge_load_page: +304%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +145%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +47%
  • ↑ bridgeUserActions/inp: +54%
  • ↓ bridgeUserActions/fcp: -37%
  • ↑ bridgeUserActions/lcp: +1288%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 2.2s
  • 🟡 confirmTx/FCP: p75 2.1s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +93%
  • ↑ startupStandardHome/load: +129%
  • ↑ startupStandardHome/domContentLoaded: +130%
  • ↑ startupStandardHome/domInteractive: +32%
  • ↓ startupStandardHome/firstPaint: -45%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +128%
  • ↑ startupStandardHome/setupStore: +134%
  • ↑ startupStandardHome/numNetworkReqs: +11%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +127%
  • ↑ startupStandardHome/longTaskMaxDuration: +135%
  • ↑ startupStandardHome/tbt: +151%
  • ↓ startupStandardHome/fcp: -47%
  • ↑ startupStandardHome/lcp: +136%
  • ↓ startupStandardHome/cls: -72%
  • ↑ startupStandardHome/backgroundConnect: +13%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
  • ↑ startupStandardHome/lcp: +11%
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -29%
  • ↓ onboardingImportWallet/confirmSrpToPwForm: -22%
  • ↓ onboardingImportWallet/pwFormToMetricsScreen: -16%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -44%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -86%
  • ↓ onboardingNewWallet/createWalletToSocialScreen: -11%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +19%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +20%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +12%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -82%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -75%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -40%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -77%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -60%
  • ↓ dappPageLoad/domContentLoaded: -19%
  • ↓ dappPageLoad/firstPaint: -47%
  • ↓ dappPageLoad/firstContentfulPaint: -47%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
🚨 background 15.22 MiB +10.14 KiB +0.07%
✅ ui 19.48 MiB +261 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +70 Bytes 0.00%
✅ content scripts 3.22 MiB +140 Bytes 0.00%
🚨 unzipped 79.91 MiB +10.61 KiB +0.01%
🚨 zip 24.01 MiB +2.25 KiB +0.01%

@sonarqubecloud

Copy link
Copy Markdown

@sahar-fehri
sahar-fehri enabled stacked auto-merge November 11, 2026 15:02
@sahar-fehri
sahar-fehri added this pull request to the merge queue Nov 11, 2026
Merged via the queue into main with commit 16a605f Nov 11, 2026
288 of 298 checks passed
@sahar-fehri
sahar-fehri deleted the feat/advanced-charts-foundation branch November 11, 2026 15:41
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 11, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026

This branch was previously deployed

1 inactive deployment
pr-comment — 7f6d7d4e Deployed Nov 11, 2026 by sahar-fehri via Publish prerelease / Publish prerelease #174084
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.58.0 Issue or pull request that will be included in release 13.58.0 size-M team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants