Skip to content

feat: color the line chart by range direction behind a theming flag - #47771

Merged
sahar-fehri merged 1 commit into
mainfrom
feat/advanced-charts-theming
Nov 12, 2026
Merged

sahar-fehri merged 1 commit into
mainfrom
feat/advanced-charts-theming

Conversation

@sahar-fehri

@sahar-fehri sahar-fehri commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Description

The Token Details Page line chart is always drawn in green. This PR adds
optional directional colouring for that line chart only: the line is green when
the selected range is up and red when it is down, so the chart agrees with the
percent-change figure in the header.

It introduces no new colours — it reuses the existing design-system tokens:
the same green (--color-success-default) the line already used, and the same
red (--color-error-default) the percent-change header already uses. The
direction is computed at the range level (range open vs. latest price), not from
the hovered point, so the colour stays stable as the pointer moves.

The behaviour is gated behind a new remote feature flag
(tokenDetailsAdvancedChartsTheming / LaunchDarkly token-details-advanced-charts-theming).
When the flag is off, the line is always green exactly as before. Candlestick
mode is unchanged
— it already renders green/red candles.

Manual testing steps

  1. Enable the advanced charts flag and the new tokenDetailsAdvancedChartsTheming flag (via .manifest-overrides.json remote flag overrides).
  2. Open a token's details page and stay in line-chart mode.
  3. Select a time range over which the asset is up for the range — verify the line is green.
  4. Select a time range over which the asset is down for the range — verify the line is red (the same red shown in the percent-change header).
  5. Hover across the chart — verify the line colour does not flip while hovering; it stays the range's direction.
  6. Turn the theming flag off — verify the line is always green regardless of direction, matching the previous behaviour.
  7. Switch to candlestick mode — verify it is unchanged.

Changelog

CHANGELOG entry: null

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
UI-only chart styling gated by a remote feature flag; default behavior unchanged when the flag is off.

Overview
Adds optional directional line coloring on the Token Details advanced line chart: when remote flag tokenDetailsAdvancedChartsTheming is on, the line uses --color-success-default for an up range and --color-error-default for a down range, based on range open vs live/current price (not hover). With the flag off, behavior stays always green.

Wires the flag through TOKEN_DETAILS_ADVANCED_CHARTS_THEMING_FLAG, getIsAdvancedChartsThemingEnabled, and the known flag registry. AdvancedChartSection passes lineColorVar into AssetChartBody, which resolves that CSS variable for Chart.js borderColor. Candle mode is unchanged.

Tests cover flag on/off, up/down/unknown range, hover stability, and chart border color resolution.

Reviewed by Cursor Bugbot for commit 1064da1. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the size-M label Nov 9, 2026
@sahar-fehri
sahar-fehri added this pull request to stack #47752 November 9, 2026 21:37
@sahar-fehri sahar-fehri changed the title feat: color advanced line chart by range direction behind theming flag feat: color the line chart by range direction behind a theming flag Nov 9, 2026
@sahar-fehri
sahar-fehri marked this pull request as ready for review November 9, 2026 21:44
@metamask-ci

metamask-ci Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor
Builds ready [cdfab57]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 3 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 42704256739 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +184%
  • ↑ loadNewAccount/total: +184%
  • ↓ loadNewAccount/inp: -18%
  • ↑ loadNewAccount/lcp: +879%
  • ↑ loadNewAccount/cls: +596%
  • ↑ confirmTx/longTaskCount: +67%
  • ↑ confirmTx/longTaskTotalDuration: +59%
  • ↑ confirmTx/longTaskMaxDuration: +46%
  • ↑ confirmTx/tbt: +54%
  • ↑ confirmTx/lcp: +917%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +109%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +16%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +31%
  • ↑ bridgeUserActions/tbt: +25%
  • ↑ bridgeUserActions/total: +13%
  • ↑ bridgeUserActions/lcp: +884%
  • ↑ bridgeUserActions/cls: +634%
  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↑ loadNewAccount/inp: +12%
  • ↓ loadNewAccount/fcp: -33%
  • ↑ loadNewAccount/lcp: +1253%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -13%
  • ↑ confirmTx/fcp: +22%
  • ↑ confirmTx/lcp: +1340%
  • ↑ bridgeUserActions/bridge_load_page: +215%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +152%
  • ↑ bridgeUserActions/bridge_search_token: +32%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +69%
  • ↑ bridgeUserActions/inp: +54%
  • ↑ bridgeUserActions/fcp: +21%
  • ↑ bridgeUserActions/lcp: +1328%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 confirmTx/FCP: p75 2.1s
  • 🟡 bridgeUserActions/FCP: p75 2.1s
  • 🟡 bridgeUserActions/LCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +87%
  • ↑ startupStandardHome/load: +122%
  • ↑ startupStandardHome/domContentLoaded: +123%
  • ↑ startupStandardHome/domInteractive: +21%
  • ↓ startupStandardHome/firstPaint: -55%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +121%
  • ↑ startupStandardHome/setupStore: +134%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +121%
  • ↑ startupStandardHome/longTaskMaxDuration: +122%
  • ↑ startupStandardHome/tbt: +142%
  • ↓ startupStandardHome/inp: -11%
  • ↓ startupStandardHome/fcp: -49%
  • ↑ startupStandardHome/lcp: +129%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -22%
  • ↓ startupStandardHome/load: -16%
  • ↓ startupStandardHome/domContentLoaded: -18%
  • ↓ startupStandardHome/domInteractive: -11%
  • ↓ startupStandardHome/backgroundConnect: -12%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -17%
  • ↓ startupStandardHome/setupStore: -19%
  • ↓ startupStandardHome/lcp: -14%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +15%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +60%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +34%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +18%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -82%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -95%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -91%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +30%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +18%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -81%
  • ↓ onboardingNewWallet/longTaskCount: -100%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -100%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -100%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -76%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -49%
  • ↓ dappPageLoad/firstPaint: -28%
  • ↓ dappPageLoad/firstContentfulPaint: -28%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
🚨 background 15.25 MiB +11.1 KiB +0.07%
🚨 ui 19.48 MiB +42.58 KiB +0.21%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +139 Bytes 0.00%
✅ content scripts 3.23 MiB +278 Bytes +0.01%
🚨 unzipped 79.93 MiB +55.44 KiB +0.07%
🚨 zip 23.98 MiB +16.99 KiB +0.07%

LabinatorSolutions pushed a commit to LabinatorSolutions/metamask-extension that referenced this pull request Nov 11, 2026
## **Description**

Foundation PR (1/5) for the Token Details Page (TDP) advanced charts
work. This splits the original MetaMask#47737 into five reviewable, stacked PRs:

1. **MetaMask#47749 (this PR)** — background/state foundation
2. MetaMask#47751 — chart UI
3. MetaMask#47753 — host-backed OHLCV pagination
4. MetaMask#47771 — chart theming (line/candle colors driven by design tokens)
5. MetaMask#47772 — chart analytics/instrumentation (interaction + empty-state
events)

This PR contains **no user-facing UI on its own**; the advanced chart is
rendered in the UI PR (MetaMask#47751) and stays behind the `AdvancedCharts`
remote feature flag. Landing it first keeps the CODEOWNER-reviewed
surface (background controller wiring, fixtures, privacy/state-logs)
small and isolated.

What it includes:

- **Chart-type preference** on `PreferencesController` (plus
`shared/types/preferences.ts` and `shared/lib/selectors/preferences.ts`
selector) so the TDP can persist the user's candle/line choice.
- **OHLCV service wiring** into the background: the
`@metamask/core-backend` OHLCV service and its messenger are registered
via `app/scripts/messenger-client-init/*` and `metamask-controller.js`.
- **Fixtures & state snapshots** (`default-fixture.json`,
`onboarding-fixture.json`, metrics state snapshots, `state-logs.json`)
updated to reflect the new controller state.

Base branch: `main`.

## **Changelog**

CHANGELOG entry: null

<!--
## **Related issues**

Fixes:
-->

## **Manual testing steps**

Since this PR adds no visible UI, testing is a no-regression smoke
check:

1. Build and run the extension.
2. Complete onboarding / unlock an existing wallet.
3. Confirm the wallet loads normally (home, asset list, settings) with
no errors in the background or UI console.
4. Open a token details page and confirm the existing (legacy) price
chart still renders as before.

<!--
## **Screenshots/Recordings**

### **Before**

### **After**
-->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Touches persisted preferences, background service initialization, and
LavaMoat policies; new OHLCV service may open backend connectivity when
later UI/flags enable it, but this PR alone adds no visible surface.
> 
> **Overview**
> Adds **background/state foundation** for Token Details Page advanced
charts (no user-facing UI in this PR).
> 
> **Chart preferences** — `PreferencesController` and `Preferences`
types now persist `tdpChartType`, `tdpChartInterval`, and
`tdpChartIndicators`, with shared defaults in
`shared/constants/preferences` and new selectors (`getTdpChartType`,
`getTdpChartInterval`, `getTdpChartIndicators`) so controller defaults
and UI fallbacks stay aligned. Controller tests, fixtures, metrics
snapshots, and state-logs schemas are updated for the new fields.
> 
> **OHLCV streaming** — Registers `@metamask/core-backend`
`OHLCVService` in the background via `OHLCVServiceInit`, a restricted
`getOHLCVServiceMessenger` (core allow-lists), and `metamask-controller`
/ messenger factory wiring. LavaMoat webpack policies grant
`AbortController` and `async-mutex` to `core-backend` for this
dependency path.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
7f6d7d4. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
@metamask-ci

metamask-ci Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor
Builds ready [273801d]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 4 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43112106870 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +182%
  • ↑ loadNewAccount/total: +182%
  • ↓ loadNewAccount/inp: -18%
  • ↑ loadNewAccount/lcp: +931%
  • ↑ loadNewAccount/cls: +607%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +71%
  • ↑ confirmTx/longTaskMaxDuration: +55%
  • ↑ confirmTx/tbt: +93%
  • ↑ confirmTx/lcp: +968%
  • ↑ bridgeUserActions/bridge_load_page: +176%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +137%
  • ↑ bridgeUserActions/longTaskCount: +82%
  • ↑ bridgeUserActions/longTaskTotalDuration: +111%
  • ↑ bridgeUserActions/longTaskMaxDuration: +35%
  • ↑ bridgeUserActions/tbt: +94%
  • ↑ bridgeUserActions/total: +38%
  • ↑ bridgeUserActions/inp: +32%
  • ↑ bridgeUserActions/lcp: +970%
  • ↑ bridgeUserActions/cls: +387%
  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↓ loadNewAccount/inp: -25%
  • ↑ loadNewAccount/fcp: +27%
  • ↑ loadNewAccount/lcp: +1276%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -21%
  • ↓ confirmTx/fcp: -35%
  • ↑ confirmTx/lcp: +1334%
  • ↑ bridgeUserActions/bridge_load_page: +209%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +108%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +34%
  • ↑ bridgeUserActions/inp: +62%
  • ↑ bridgeUserActions/fcp: +27%
  • ↑ bridgeUserActions/lcp: +1331%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.8s
  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
  • 🟡 loadNewAccount/FCP: p75 2.2s
  • 🟡 bridgeUserActions/FCP: p75 2.2s
  • 🟡 bridgeUserActions/LCP: p75 2.5s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +99%
  • ↑ startupStandardHome/load: +134%
  • ↑ startupStandardHome/domContentLoaded: +135%
  • ↑ startupStandardHome/domInteractive: +32%
  • ↓ startupStandardHome/firstPaint: -50%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +133%
  • ↑ startupStandardHome/setupStore: +95%
  • ↑ startupStandardHome/numNetworkReqs: +11%
  • ↑ startupStandardHome/longTaskCount: +79%
  • ↑ startupStandardHome/longTaskTotalDuration: +134%
  • ↑ startupStandardHome/longTaskMaxDuration: +145%
  • ↑ startupStandardHome/tbt: +157%
  • ↓ startupStandardHome/fcp: -47%
  • ↑ startupStandardHome/lcp: +136%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/uiStartup: -36%
  • ↓ startupStandardHome/load: -30%
  • ↓ startupStandardHome/domContentLoaded: -32%
  • ↓ startupStandardHome/domInteractive: -53%
  • ↓ startupStandardHome/backgroundConnect: -25%
  • ↓ startupStandardHome/firstReactRender: -99%
  • ↓ startupStandardHome/initialActions: -50%
  • ↓ startupStandardHome/loadScripts: -30%
  • ↓ startupStandardHome/fcp: -33%
  • ↓ startupStandardHome/lcp: -28%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +11%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +24%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +36%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +19%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -82%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -94%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -90%
  • ↓ onboardingImportWallet/tbt: -99%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +16%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +49%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +22%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +18%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -71%
  • ↓ onboardingNewWallet/longTaskCount: -23%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -41%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -28%
  • ↓ onboardingNewWallet/tbt: -76%
  • ↓ onboardingNewWallet/total: -67%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -50%
  • ↓ dappPageLoad/firstPaint: -33%
  • ↓ dappPageLoad/firstContentfulPaint: -33%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.22 MiB +806 Bytes +0.01%
🚨 ui 19.54 MiB +41.13 KiB +0.21%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +76 Bytes 0.00%
✅ content scripts 3.22 MiB +152 Bytes 0.00%
🚨 unzipped 79.97 MiB +43.65 KiB +0.05%
🚨 zip 24.03 MiB +14.32 KiB +0.06%

@metamask-ci

metamask-ci Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor
Builds ready [0b8dfaf]
⚡ Performance Benchmarks (Total: 🟢 8 pass · 🟡 2 warn · 🔴 3 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43190448874 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 3 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↓ loadNewAccount/inp: -33%
  • ↓ loadNewAccount/fcp: -19%
  • ↑ loadNewAccount/lcp: +693%
  • ↑ loadNewAccount/cls: +297%
  • ↑ confirmTx/longTaskMaxDuration: +17%
  • ↑ confirmTx/tbt: +16%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -14%
  • ↑ confirmTx/lcp: +763%
  • ↓ confirmTx/cls: -14%
  • ↑ bridgeUserActions/bridge_load_page: +12%
  • ↓ bridgeUserActions/longTaskTotalDuration: -19%
  • ↓ bridgeUserActions/longTaskMaxDuration: -22%
  • ↓ bridgeUserActions/tbt: -32%
  • ↓ bridgeUserActions/inp: -19%
  • ↓ bridgeUserActions/fcp: -18%
  • ↑ bridgeUserActions/lcp: +713%
  • ↑ bridgeUserActions/cls: +506%
  • ↑ loadNewAccount/load_new_account: +181%
  • ↑ loadNewAccount/total: +181%
  • ↑ loadNewAccount/inp: +12%
  • ↓ loadNewAccount/fcp: -67%
  • ↑ loadNewAccount/lcp: +846%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -37%
  • ↓ confirmTx/fcp: -73%
  • ↑ confirmTx/lcp: +1038%
  • ↑ bridgeUserActions/bridge_load_page: +92%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +43%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↓ bridgeUserActions/fcp: -70%
  • ↑ bridgeUserActions/lcp: +870%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +18%
  • ↑ startupStandardHome/load: +39%
  • ↑ startupStandardHome/domContentLoaded: +39%
  • ↓ startupStandardHome/domInteractive: -13%
  • ↓ startupStandardHome/firstPaint: -45%
  • ↓ startupStandardHome/backgroundConnect: -28%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -64%
  • ↑ startupStandardHome/loadScripts: +37%
  • ↑ startupStandardHome/setupStore: +36%
  • ↑ startupStandardHome/longTaskTotalDuration: +31%
  • ↑ startupStandardHome/longTaskMaxDuration: +50%
  • ↑ startupStandardHome/tbt: +40%
  • ↓ startupStandardHome/inp: -30%
  • ↑ startupStandardHome/fcp: +28%
  • ↑ startupStandardHome/lcp: +475%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↓ onboardingImportWallet/srpButtonToSrpForm: -14%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +23%
  • ↓ onboardingImportWallet/metricsToWalletReadyScreen: -10%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -100%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -100%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -100%
  • ↓ onboardingImportWallet/tbt: -100%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +38%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +27%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +12%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -74%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -75%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -40%
  • ↓ onboardingNewWallet/tbt: -100%
  • ↓ onboardingNewWallet/total: -70%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -49%
  • ↓ dappPageLoad/firstPaint: -28%
  • ↓ dappPageLoad/firstContentfulPaint: -28%
Bundle Size Diffs [🚨 Warning! Bundle size has increased!]
Status Bundle Total Diff Change
✅ background 15.22 MiB +806 Bytes +0.01%
🚨 ui 19.54 MiB +43.55 KiB +0.22%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB +76 Bytes 0.00%
✅ content scripts 3.22 MiB +152 Bytes 0.00%
🚨 unzipped 79.97 MiB +46.06 KiB +0.06%
🚨 zip 24.03 MiB +15.37 KiB +0.06%

Base automatically changed from feat/advanced-charts-pagination to main November 12, 2026 14:25
@metamask-ci

metamask-ci Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor
Builds ready [1064da1]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 3 warn · 🔴 4 fail)

Baseline (latest main): f693520 | Date: 11/3/2026 | Pipeline: 43236987817 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 load_new_account(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 4 failures)

Interaction Benchmarks · Samples: 5 🔴 2
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🔴 [CI log]
🔴 load_new_account
🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↑ loadNewAccount/lcp: +949%
  • ↑ loadNewAccount/cls: +297%
  • ↑ confirmTx/longTaskCount: +33%
  • ↑ confirmTx/longTaskTotalDuration: +59%
  • ↑ confirmTx/longTaskMaxDuration: +66%
  • ↑ confirmTx/tbt: +78%
  • ↑ confirmTx/lcp: +992%
  • ↑ bridgeUserActions/bridge_load_page: +123%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +82%
  • ↑ bridgeUserActions/longTaskCount: +36%
  • ↑ bridgeUserActions/longTaskTotalDuration: +40%
  • ↑ bridgeUserActions/tbt: +48%
  • ↑ bridgeUserActions/total: +25%
  • ↑ bridgeUserActions/lcp: +979%
  • ↑ bridgeUserActions/cls: +387%
  • ↑ loadNewAccount/load_new_account: +183%
  • ↑ loadNewAccount/total: +183%
  • ↓ loadNewAccount/inp: -25%
  • ↓ loadNewAccount/fcp: -29%
  • ↑ loadNewAccount/lcp: +1058%
  • ↓ confirmTx/longTaskCount: -100%
  • ↓ confirmTx/longTaskTotalDuration: -100%
  • ↓ confirmTx/longTaskMaxDuration: -100%
  • ↓ confirmTx/tbt: -100%
  • ↓ confirmTx/inp: -13%
  • ↓ confirmTx/fcp: -55%
  • ↑ confirmTx/lcp: +1118%
  • ↑ bridgeUserActions/bridge_load_page: +274%
  • ↑ bridgeUserActions/bridge_load_asset_picker: +101%
  • ↑ bridgeUserActions/bridge_search_token: +52%
  • ↓ bridgeUserActions/longTaskCount: -100%
  • ↓ bridgeUserActions/longTaskTotalDuration: -100%
  • ↓ bridgeUserActions/longTaskMaxDuration: -100%
  • ↓ bridgeUserActions/tbt: -100%
  • ↑ bridgeUserActions/total: +77%
  • ↑ bridgeUserActions/inp: +47%
  • ↑ bridgeUserActions/lcp: +1213%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts

📈 Results compared to the previous 5 runs on main

  • ↑ startupStandardHome/uiStartup: +75%
  • ↑ startupStandardHome/load: +106%
  • ↑ startupStandardHome/domContentLoaded: +107%
  • ↑ startupStandardHome/domInteractive: +28%
  • ↓ startupStandardHome/firstPaint: -55%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -29%
  • ↑ startupStandardHome/loadScripts: +105%
  • ↑ startupStandardHome/setupStore: +95%
  • ↑ startupStandardHome/longTaskCount: +43%
  • ↑ startupStandardHome/longTaskTotalDuration: +107%
  • ↑ startupStandardHome/longTaskMaxDuration: +115%
  • ↑ startupStandardHome/tbt: +125%
  • ↓ startupStandardHome/fcp: -52%
  • ↑ startupStandardHome/lcp: +113%
  • ↓ startupStandardHome/cls: -72%
  • ↓ startupStandardHome/firstReactRender: -98%
  • ↓ startupStandardHome/initialActions: -50%
User Journey Benchmarks · Samples: 5 · mock API 🔴 2
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total

📈 Results compared to the previous 5 runs on main

  • ↑ onboardingImportWallet/srpButtonToSrpForm: +25%
  • ↑ onboardingImportWallet/confirmSrpToPwForm: +41%
  • ↑ onboardingImportWallet/pwFormToMetricsScreen: +59%
  • ↑ onboardingImportWallet/metricsToWalletReadyScreen: +32%
  • ↓ onboardingImportWallet/doneButtonToHomeScreen: -92%
  • ↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -74%
  • ↓ onboardingImportWallet/longTaskCount: -82%
  • ↓ onboardingImportWallet/longTaskTotalDuration: -94%
  • ↓ onboardingImportWallet/longTaskMaxDuration: -88%
  • ↓ onboardingImportWallet/tbt: -98%
  • ↓ onboardingImportWallet/total: -85%
  • ↑ onboardingNewWallet/srpButtonToPwForm: +19%
  • ↑ onboardingNewWallet/createPwToRecoveryScreen: +35%
  • ↑ onboardingNewWallet/skipBackupToMetricsScreen: +33%
  • ↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +19%
  • ↓ onboardingNewWallet/doneButtonToAssetList: -68%
  • ↓ onboardingNewWallet/longTaskCount: -62%
  • ↓ onboardingNewWallet/longTaskTotalDuration: -73%
  • ↓ onboardingNewWallet/longTaskMaxDuration: -35%
  • ↓ onboardingNewWallet/tbt: -99%
  • ↓ onboardingNewWallet/total: -65%
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • ↓ dappPageLoad/pageLoadTime: -67%
  • ↓ dappPageLoad/domContentLoaded: -33%
  • ↓ dappPageLoad/firstPaint: -47%
  • ↓ dappPageLoad/firstContentfulPaint: -47%
Bundle Size Diffs
Status Bundle Total Diff Change
✅ background 15.23 MiB +115 Bytes 0.00%
✅ ui 19.52 MiB +586 Bytes 0.00%
✅ common 0 Bytes 0 Bytes 0.00%
✅ other 4.46 MiB 0 Bytes 0.00%
✅ content scripts 3.2 MiB 0 Bytes 0.00%
✅ unzipped 79.94 MiB +706 Bytes 0.00%
✅ zip 24.02 MiB +228 Bytes 0.00%

@sonarqubecloud

Copy link
Copy Markdown

@sahar-fehri
sahar-fehri added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit 84d9038 Nov 12, 2026
140 checks passed
@sahar-fehri
sahar-fehri deleted the feat/advanced-charts-theming branch November 12, 2026 15:29
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 12, 2026
@metamaskbot metamaskbot added the release-13.58.0 Issue or pull request that will be included in release 13.58.0 label Nov 16, 2026

This branch was previously deployed

1 inactive deployment
pr-comment — 1064da13 Deployed Nov 12, 2026 by sahar-fehri via Publish prerelease / Publish prerelease #174344
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.58.0 Issue or pull request that will be included in release 13.58.0 size-M team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants