Skip to content

Add /constants - #1728

Closed
rickycodes wants to merge 6 commits into
developfrom
feature/add-constants
Closed

rickycodes wants to merge 6 commits into
developfrom
feature/add-constants

Conversation

@rickycodes

@rickycodes rickycodes commented Jul 28, 2020 •

Copy link
Copy Markdown
Contributor

This was based on some feedback from @estebanmino and it's true, AppConstants should be treated separately.

for the storage keys we were repeating ourselves an awful lot, so I thought it might be good to have some constants for that as well. surprisingly, there's only 15 keys related to storage.

@rickycodes
rickycodes requested a review from a team as a code owner July 28, 2020 02:43
@rickycodes
rickycodes force-pushed the feature/add-constants branch 4 times, most recently from e0cfc8d to 5c6135d Compare July 28, 2020 19:25
@rickycodes rickycodes added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 29, 2020
@rickycodes
rickycodes force-pushed the feature/add-constants branch 6 times, most recently from 44b7c1b to fe57bf3 Compare August 4, 2020 14:55

@EtDu EtDu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid

@rickycodes
rickycodes force-pushed the feature/add-constants branch 4 times, most recently from bcfb98e to 6db50dd Compare August 17, 2020 16:29
@rickycodes rickycodes removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 17, 2020
@rickycodes
rickycodes force-pushed the feature/add-constants branch from ce2c2c1 to f7da43a Compare August 19, 2020 14:54

@estebanmino estebanmino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@rickycodes

Copy link
Copy Markdown
Contributor Author

grouping this with #1797

@rickycodes rickycodes closed this Aug 26, 2020
@rickycodes
rickycodes deleted the feature/add-constants branch June 11, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants