Skip to content

Bugfixes/post v1 aug 2020 - #1797

Merged
rickycodes merged 36 commits into
developfrom
bugfix/post-v1-aug-2020
Sep 11, 2020
Merged

rickycodes merged 36 commits into
developfrom
bugfix/post-v1-aug-2020

Conversation

@rickycodes

@rickycodes rickycodes commented Aug 26, 2020 •

Copy link
Copy Markdown
Contributor

Description

This is a grouping of PRs to clean things up a bit and make review/QA a bit easier on everyone.
this PR includes the following work:

#1781 (this has been approved, this is just a code change, no functionality changed)
#1759 (this is a bugfix and needs QA)
#1728 (just some code cleanup, no functionality changed)
#1787 (add missing currencies, in particular SAI and INR needs QA)
#1800 (minor improvement to search input, needs QA)

@rickycodes
rickycodes requested a review from a team as a code owner August 26, 2020 17:01
@rickycodes rickycodes added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Aug 26, 2020
@rickycodes
rickycodes force-pushed the bugfix/post-v1-aug-2020 branch from 9218d38 to edb09c6 Compare August 26, 2020 17:13
@rickycodes rickycodes changed the title Bugfix/post v1 aug 2020 Bugfixes/post v1 aug 2020 Aug 26, 2020
@rickycodes
rickycodes force-pushed the bugfix/post-v1-aug-2020 branch from edb09c6 to 01fdc41 Compare August 26, 2020 17:19
@rickycodes rickycodes added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 26, 2020
@rickycodes
rickycodes force-pushed the bugfix/post-v1-aug-2020 branch from d28286c to c2efeed Compare August 27, 2020 18:19
@omnat omnat added the next up prioritized to be picked up next label Sep 4, 2020
@rickycodes
rickycodes force-pushed the bugfix/post-v1-aug-2020 branch from 72c5b05 to 45160b0 Compare September 8, 2020 02:38
@ibrahimtaveras00 ibrahimtaveras00 added QA in Progress QA has started on the feature. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Sep 8, 2020

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few issues mentioned to @rickycodes

@ibrahimtaveras00 ibrahimtaveras00 added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed QA in Progress QA has started on the feature. labels Sep 8, 2020
@rickycodes
rickycodes force-pushed the bugfix/post-v1-aug-2020 branch from 45160b0 to 1185478 Compare September 9, 2020 17:47
@rickycodes

Copy link
Copy Markdown
Contributor Author

@ibrahimtaveras00 this one should be good-to-go again!

@rickycodes rickycodes added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Sep 10, 2020
@rickycodes
rickycodes force-pushed the bugfix/post-v1-aug-2020 branch from 2c03662 to 6fc82f4 Compare September 10, 2020 17:51

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes look good, QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed QA testing has been completed and passed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Sep 11, 2020
@rickycodes
rickycodes merged commit 2fc20dc into develop Sep 11, 2020
@rickycodes
rickycodes deleted the bugfix/post-v1-aug-2020 branch September 11, 2020 20:26
rickycodes added a commit that referenced this pull request Jan 31, 2022
* Fix typo

* Add resetAutocompleteInputValue()

* Remove console.log()

* Use translations for steps

* Use title

* Add some missing translation strings

* Add missing es translations

* Add /constants

* Add constants for storage keys

* constants++

* Add constants for true, agreed, denied, debug

* Add const for EXPLORED

* Add constants for ENCRYPTION_LIB and ORIGINAL

* Display correct balance from state

* Document props

* Remove accounts prop

* Use ownProps to get updatedBalanceFromStore

* Add missing currencies and add `base` programatically

* Update CHANGELOG.md

* Update snapshot

* We don't actually need this

* Add constants for onboarding steps

* Update captureMessage to use storage constant

* Update CHANGELOG

* Add ANIMATION_TIMING constant

* Delay reset

* Uppercase fiat currency acronyms

* Simplify via destructuring

* Update AccountInfoCard

* Use scaling

* Remove space

* Add this.steps back in

* Scale font down

* Uppercase remaining texts

* one final upper

* Update snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

next up prioritized to be picked up next QA Passed QA testing has been completed and passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants