Skip to content

Add missing currency conversions - #1787

Closed
rickycodes wants to merge 2 commits into
developfrom
bugfix/add-missing-currencies
Closed

rickycodes wants to merge 2 commits into
developfrom
bugfix/add-missing-currencies

Conversation

@rickycodes

@rickycodes rickycodes commented Aug 19, 2020 •

Copy link
Copy Markdown
Contributor

Description

Add missing currency conversions re: #1777. I also noticed that base was the same for all of these, so I am just adding that programmatically now. Once this is merged we'll have the missing conversions:

Option in Settings:

image

Displayed as fiat:

image

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #1777

@rickycodes
rickycodes requested a review from a team as a code owner August 19, 2020 17:45
@rickycodes rickycodes changed the title Add missing currencies Add missing currencies conversions Aug 19, 2020
@rickycodes rickycodes added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Aug 19, 2020
@rickycodes rickycodes changed the title Add missing currencies conversions Add missing currency conversions Aug 19, 2020
@rickycodes
rickycodes force-pushed the bugfix/add-missing-currencies branch from 19dce21 to 7b7010c Compare August 19, 2020 18:06
@rickycodes
rickycodes force-pushed the bugfix/add-missing-currencies branch from 7b7010c to b95ede9 Compare August 19, 2020 18:06

@EtDu EtDu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fire!

@rickycodes

rickycodes commented Aug 25, 2020 •

Copy link
Copy Markdown
Contributor Author

Likely going to close this in favour of: #1797

@rickycodes

Copy link
Copy Markdown
Contributor Author

grouping this with #1787

@rickycodes rickycodes closed this Aug 26, 2020
@rickycodes
rickycodes deleted the bugfix/add-missing-currencies branch November 19, 2020 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No INR option in Currency conversion

2 participants