Repository navigation
feat(assets): subscribe candlestick streams on ohlcv.v1 - #38739
Conversation
Production now serves the ohlcv.v1 candlestick namespace, and mobile was still matching market-data.v1. Co-authored-by: Cursor <cursoragent@cursor.com>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Smart E2E Test SelectionSelected E2E tagsSmokeSwap AI Confidence: 82 E2E reasoningExpand to readThis PR switches the OHLCV subscription namespace from Functional impact areas:
Risk level: medium — The change is a single focused namespace string switch, but it affects live data streaming across multiple product areas. If the Comment/doc-only changes (types.ts files, JSDoc in index.ts) are cosmetic and don't add additional test scope. Tag dependency rules applied:
|
The published core-backend package stays as-is. Mobile charts and social prices match ohlcv.v1 themselves. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #38739 +/- ##
=======================================
Coverage 87.73% 87.73%
=======================================
Files 8030 8030
Lines 233873 233873
Branches 59287 59287
=======================================
+ Hits 205186 205195 +9
+ Misses 16265 16262 -3
+ Partials 12422 12416 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…espace-ddf-1 # Conflicts: # app/components/UI/Bridge/hooks/useLiveTokenFiatRate/index.ts
9120fbb
|



Description
Production now serves candlestick updates on
ohlcv.v1. Charts, bridge live rates, and social spot prices were still matchingmarket-data.v1.<assetId>.<interval>.<currency>, so those client channel names now useohlcv.v1.This PR also switches the
OHLCVServicesubscription namespace toohlcv.v1. It removes thesubscriptionNamespace: 'market-data.v1'pin added in #38819, soohlcv-service-init.tspasses no namespace override and the service uses core-backend 14's default ofohlcv.v1. The service subscription and the client channel matching now both useohlcv.v1. TheisLoadingtest fixture that came in from main was updated the same way.Adverse review: SHIP-WITH-CAVEATS (3/3 ship). Its two warnings (share one namespace constant across modules, and add a test that ties the service namespace to the client channel names) were declined for now: they are refactors outside this PR's scope, and every literal already matches.
Changelog
CHANGELOG entry: Switched live candlestick prices to the ohlcv.v1 stream
Related issues
Refs: https://consensyssoftware.atlassian.net/browse/ASSETS-4174
Manual testing steps
Screenshots/Recordings
N/A. The channel prefix is not visible in the UI.
Before
N/A
After
N/A
Pre-merge author checklist
Performance checks (if applicable)
For performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Medium Risk
Live chart, Bridge, and social spot pricing depend on matching the production stream namespace; a client/backend mismatch would stop real-time candles until aligned.
Overview
Production candlestick WebSocket traffic now uses
ohlcv.v1instead ofmarket-data.v1. This PR aligns the mobile client with that namespace end to end.useOHLCVRealtimebuilds and matches channels asohlcv.v1.<assetId>.<interval>.<currency>, which feeds advanced charts and Bridge live fiat rates. Social live spot prices use the same prefix when subscribing and when filteringbarUpdatedevents. Related JSDoc and test channel strings were updated to match.OHLCVServiceinitialization drops the explicitsubscriptionNamespace: 'market-data.v1'pin so the service uses core-backend’s defaultohlcv.v1, keeping subscriptions and UI channel matching in sync. The init test that asserted the old override was removed.Reviewed by Cursor Bugbot for commit 9120fbb. Bugbot is set up for automated code reviews on this repo. Configure here.