Repository navigation
chore: bump assets-controller to ^20.2.2, assets-controllers to ^113.1.1 and core-backend to ^14.0.0 - #38819
Conversation
…13.1.0 Also bump @metamask/core-backend to ^13.0.0 to match the version required by the new assets controller releases, and add the new NftDetectionController:detectNfts action to the Engine types. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
PR template — items to address before "Ready for review"Warnings — informational, address before merging:
See docs/readme/ready-for-review.md for the full Definition of Ready for Review. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Smart E2E Test SelectionSelected E2E tags: ALL AI Confidence: 100 E2E reasoningExpand to readThe PR contains several changes that justify running all smoke tests:
The hard rule seed (controller-version-update) already mandated ALL tags. The analysis confirms this is appropriate: the major core-backend version bump has broad blast radius across market data features, and the new default mock infrastructure change affects all E2E tests globally. |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…sets-controllers to ^113.1.1 Keep OHLCVService on the market-data.v1 namespace, since core-backend 14 defaults to ohlcv.v1 and client channel matching still uses market-data.v1.
|
🤖 I pushed 2 commits to move this PR to the releases from MetaMask/core#11300:
|
| // client channel matching (charts, bridge live rates, social spot prices) | ||
| // moves to `ohlcv.v1`. Remove together with that switch: | ||
| // https://github.com/MetaMask/metamask-mobile/pull/38739 | ||
| subscriptionNamespace: 'market-data.v1', |
There was a problem hiding this comment.
I'll literally remove this on the next PR - so its okay for now.
|
|
🤖 CI fix: the Appium smoke failures (SmokeConfirmations, SmokeNetworkAbstractions, SmokeStake, SmokeWalletPlatform) were cleanup errors from an unmocked |
| // tokens, so nothing extra is flagged as spam. | ||
| // e.g. https://token.api.cx.metamask.io/v2/assets?assetIds=eip155:1/erc20:0x...&includeLaunchpadData=true&includeTokenSecurityData=true | ||
| const tokenV2AssetsRegex = | ||
| /^https:\/\/token\.api\.cx\.metamask\.io\/v2\/assets\?.*$/; |
There was a problem hiding this comment.
yep intentional - we are using /v2/assets endpoint as part of our internal cleanup scripts.



Description
Bumps
@metamask/assets-controllerto^20.2.2,@metamask/assets-controllersto^113.1.1and@metamask/core-backendto^14.0.0. These are released in MetaMask/core#11300.Why: the launchpad spam check in assets-controller 20.2.x calls
apiClient.token.fetchV2Assets(...). Only core-backend 14.0.0 has that method; the 13.x line lacks it. On 13.x, the spam-token cleanup at unlock throws aTypeErrorand removes no spam tokens. assets-controller 20.2.2 requires core-backend^14.0.0, which fixes this.OHLCV handling: core-backend 14 is breaking for
OHLCVService. Its default channel namespace changes frommarket-data.v1toohlcv.v1. Mobile's clients still matchmarket-data.v1.*channel strings:useOHLCVRealtime(charts)useLiveTokenFiatRate(bridge live rates)SocialLivePricesProvider(social spot prices)To keep live updates working,
app/core/Engine/controllers/core-backend/ohlcv-service-init.tsnow passessubscriptionNamespace: 'market-data.v1', with a unit test.Ordering with #38739 (moves clients to
ohlcv.v1): that PR should merge after this one or together with it, never before. On core-backend 13 the service only emitsmarket-data.v1. When it lands, it should drop thesubscriptionNamespaceoption (or set it to'ohlcv.v1') and updateohlcv-service-init.test.ts.The lockfile changes are limited to these 3 packages.
@metamask/client-utils3.1.1 is not bumped because the fix doesn't need it. The existing core-backend 11/13 copies used by client-utils, social-controllers and transaction-controller are unchanged frommain.Changelog
CHANGELOG entry: Fixed spam token cleanup on unlock, which failed to remove launchpad spam tokens
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/WPN-2427?atlOrigin=eyJpIjoiYjE1YzRlMTU3N2M1NGM2MTgzNTZmYTZkYmIxZmIzYTEiLCJwIjoiaiJ9
Manual testing steps
Screenshots/Recordings
Before
N/A (dependency bump, no UI change)
After
N/A
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Medium Risk
Touches unlock token cleanup and real-time market-data subscriptions via a major core-backend bump; behavior is intentionally pinned to the old OHLCV namespace until client migration lands.
Overview
Upgrades
@metamask/core-backendto ^14.0.0 and aligned@metamask/assets-controller/@metamask/assets-controllerspatch releases so unlock-time launchpad spam cleanup can callfetchV2Assets(missing on core-backend 13, which caused aTypeErrorand skipped spam removal).Because core-backend 14 changes
OHLCVService’s default subscription namespace toohlcv.v1,ohlcv-service-init.tsnow passessubscriptionNamespace: 'market-data.v1'so existing chart, bridge, and social live-price subscribers keep receiving updates until a follow-up PR switches clients toohlcv.v1. A unit test asserts that wiring.E2E defaults add a mock for the token API v2
/assetsrequests used by the new launchpad spam check (empty200response).Reviewed by Cursor Bugbot for commit 4109dc9. Bugbot is set up for automated code reviews on this repo. Configure here.