Repository navigation
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
mganchas
force-pushed
the
feat/deferred-render-primitive
branch
from
November 18, 2026 16:16
6cb9a08 to
2e51f5a
Compare
mganchas
force-pushed
the
perf/deferred-render-perps-market-details
branch
from
November 18, 2026 16:27
655ff77 to
b720b1e
Compare
mganchas
force-pushed
the
feat/deferred-render-primitive
branch
from
November 18, 2026 16:33
2e51f5a to
8af1716
Compare
mganchas
force-pushed
the
perf/deferred-render-perps-market-details
branch
from
November 18, 2026 16:34
b720b1e to
40079af
Compare
mganchas
marked this pull request as ready for review
November 18, 2026 16:38
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 40079af. Configure here.
mganchas
force-pushed
the
perf/deferred-render-perps-market-details
branch
from
November 18, 2026 17:13
40079af to
f55a182
Compare
Hold the statistics, trades, related and social sections out of the opening transition with the existing useScreenTransitionComplete hook.
mganchas
force-pushed
the
perf/deferred-render-perps-market-details
branch
from
November 18, 2026 18:57
f55a182 to
2bdf0f5
Compare
mganchas
force-pushed
the
feat/deferred-render-primitive
branch
from
November 18, 2026 18:57
d7a6a1f to
00fe69f
Compare
mganchas
changed the base branch from
feat/deferred-render-primitive
to
main
November 18, 2026 18:58
5 of 7 tasks
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
What
Holds the sections that dominate
PerpsMarketDetailsView's opening commit (statistics card, recent trades, "more" section, and the lower block with position lists plus the social or market-insights lists) out of the push transition.The gate is the existing
useScreenTransitionComplete()hook, called once with no arguments. No new hook or wrapper is added. Header, chart and primary actions stay eager.Evidence
Earlier Reassure measurement (10 runs, local, not a CI gate) with a custom gate with the same release point: opening commit 39.08 ms → 26.97 ms (social path 46.1 → 27.5 ms). A TestFlight build using the plain hook was tested on a real device and the transition was fast.
Test layer placement
PerpsMarketDetailsView.test.tsxmocksuseScreenTransitionComplete(defaulttrue) and adds one test for the held-back state.Changelog
CHANGELOG entry: null
Related issues
Refs: #38039
Manual testing steps
Screenshots/Recordings
N/A — no visual change; deferred sections render one frame after the opening transition instead of during it. Opening-commit measurements in the description.
Before
N/A
After
N/A
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist