Repository navigation
Conversation
PR template — items to address before "Ready for review"Warnings — informational, address before merging:
See docs/readme/ready-for-review.md for the full Definition of Ready for Review. |
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
025699f to
b2a1ab2
Compare
Smart E2E Test SelectionSelected E2E tags: ALL AI Confidence: 100 E2E reasoningExpand to readI narrowed the seed from ALL to two tags. The seed's global-infrastructure rule matched on the path, but this hook is not globally mounted. It is also not part of Engine, the store, or the app startup path. The change adds an opt-in DeferredRender component. It also adds a context, new trace enums, and options for the existing hook ( |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6cb9a08. Configure here.
6cb9a08 to
2e51f5a
Compare
2e51f5a to
8af1716
Compare
…ferring heavy sections Document when to gate a heavy below-the-fold section on the existing useScreenTransitionComplete hook instead of writing a new deferral hook.
d7a6a1f to
00fe69f
Compare
|




Description
What
Docs only. Agents (and people) keep reaching for a new deferral hook when a heavy section janks a push transition, but
useScreenTransitionCompletealready exists inapp/components/hooks/(added in #34575 to open the keyboard after a push) and does the job.This PR adds the guidance for when and how to use it:
docs/performance/anti-patterns.md: a short "Deferring a heavy section until the push transition ends" section (snippet, when to do it, when not to, test tip), linked from "Eager / redundant work on mount".AGENTS.md: one Quick Reference line pointing agents at that section.No code changes. An earlier revision of this PR added a
useDeferredRenderhook and a<DeferredRender>wrapper. A TestFlight build that used the plainuseScreenTransitionComplete()on Perps, TokenDetails and Top traders was just as fast on a real device, so the extra primitive was dropped. The screen adoptions now consume the existing hook: #40028, #40026, #40022, #40025.Changelog
CHANGELOG entry: null
Related issues
Refs: N/A (docs only)
Manual testing steps
N/A. Documentation only.
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist