Repository navigation
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
6cb9a08 to
2e51f5a
Compare
402d05e to
02f1ad6
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 02f1ad6. Configure here.
2e51f5a to
8af1716
Compare
112a927 to
84f63eb
Compare
|
Hold the earnings, activity and potential-earnings sections out of the opening transition with the existing useScreenTransitionComplete hook.
84f63eb to
8faf23d
Compare
d7a6a1f to
00fe69f
Compare
PR template — items to address before "Ready for review"Warnings — informational, address before merging:
See docs/readme/ready-for-review.md for the full Definition of Ready for Review. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning MetaMask internal reviewing guidelines:
|




Description
What
Holds the three sections that dominate
MoneyHomeView's opening commit (earnings, activity, potential earnings) out of the push transition, so the transition renders before they mount.The gate is the existing
useScreenTransitionComplete()hook (app/components/hooks/useScreenTransitionComplete.ts), called with no arguments. No new hook or wrapper is added. Header, balance summary and action row stay eager.Evidence
Earlier measurement with the local Reassure harness (10 runs, not a CI gate), using a custom gate with the same release point: opening commit 23.10 ms eager → 8.78 ms held. A TestFlight build using the plain hook was checked on a real device for Perps, TokenDetails and Top traders. Money was not part of that check yet.
Test layer placement
MoneyHomeView.test.tsxmocksuseScreenTransitionComplete(defaulttrue) and adds one test for the held-back state. Component-view tests are unchanged.Changelog
CHANGELOG entry: null
Related issues
Refs: #38039
Manual testing steps
Screenshots/Recordings
Before
N/A — no visual change; only mount timing of the heavy sections changes.
After
N/A — no visual change; only mount timing of the heavy sections changes.
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Testing done:
yarn jest app/components/UI/Money/Views/MoneyHomeView/MoneyHomeView.test.tsx— 208/208 pass;yarn test:view:one app/components/UI/Money/Views/MoneyHomeView/MoneyHomeView.view.test.tsx— 4/4 pass.