Repository navigation
Conversation
Teaches the opt-in DeferredRender primitive from metamask-mobile (PR MetaMask/metamask-mobile#38039): when to hold heavy below-the-fold sections out of a screen's opening transition, the transition vs paint mode choice, the one-gate-per-screen rule, and the local Reassure eager/held/flush measurement recipe with reference numbers from the first five adoptions.
The DeferredRender primitive now builds on the existing useScreenTransitionComplete hook instead of a separate useDeferredRender, so the skill names that hook, explains when to use the bare boolean versus the gate, and notes the release span only fires with a screenId.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
New
deferred-renderskill underdomains/performance/skills/(installs asmms-deferred-render).Teaches the opt-in DeferredRender primitive landing in metamask-mobile (MetaMask/metamask-mobile#38039): hold heavy below-the-fold sections out of a screen's opening transition so the screen paints its header/chart/tabs first and the expensive rows mount one frame after the transition.
Content
useScreenTransitionComplete/<DeferredRender>, modes,fallbackMs,screenId, Sentry span) with pointers to the origin PR and in-repo READMEisPushedScreenintegration pattern with the five real reference integrations (MoneyHomeView, PerpsMarketDetailsView + social tabs, TokenDetails, SocialV0View, SocialV1View)runs: 10, the eager-mock trick for screens without an arm switch, and the Jest caveats (react-native-screensmock, real-timer fallback)findBy*, TestFlight check on a real iPhone)Validation
yarn audit:skills: 0 errors, and the new skill adds no warnings (95 skills checked).Marked
maturity: experimentaluntil the primitive PR merges.