Skip to content

chore: remove rn-nodeify step from setup script - #9403

Closed
legobeat wants to merge 5 commits into
mainfrom
chore-remove-nodeify-install
Closed

legobeat wants to merge 5 commits into
mainfrom
chore-remove-nodeify-install

Conversation

@legobeat

@legobeat legobeat commented Apr 25, 2024 •

Copy link
Copy Markdown
Contributor

Description

Alternative to #9396.

This completely removes the rn-nodeify step from yarn setup.

Related issues

Manual testing steps

Build & run mobile app

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added dependencies Pull requests that update a dependency file team-application-security Application security team labels Apr 25, 2024
@legobeat
legobeat force-pushed the chore-remove-nodeify-install branch 4 times, most recently from d8318f2 to 8e58a1f Compare April 29, 2024 10:44
@legobeat
legobeat force-pushed the chore-remove-nodeify-install branch 2 times, most recently from 61351b9 to f702b90 Compare May 2, 2024 22:48
@legobeat
legobeat force-pushed the chore-remove-nodeify-install branch from f702b90 to 851d62f Compare May 23, 2024 04:44
@legobeat
legobeat force-pushed the chore-remove-nodeify-install branch from 851d62f to a2c80cf Compare May 23, 2024 04:58
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions

github-actions Bot commented May 23, 2024 •

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a2c80cf
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6f8f8d6f-0464-4a67-9982-581dba085ebb

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions Bot added the stale Issues that have not had activity in the last 90 days label Aug 21, 2024
@github-actions

Copy link
Copy Markdown
Contributor

This PR was closed because there has been no follow up activity in 7 days. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file stale Issues that have not had activity in the last 90 days team-application-security Application security team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant