Repository navigation
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
There was a problem hiding this comment.
Leaving this comment in place as the current approach could still be improved.
not typosquatting; network access ok |
f551240 to
665e089
Compare
|
this is so that any patches applied to rn-nodeify or any of its dependencies get applied proeprly.
These were added by rn-nodeify but not visible in lockfile because it used npm instead yarn to do so. This adds the changes made by rn-nodeify to source-control and the installed packages as dependencies.
8f3c42a to
effabf7
Compare
|
|
This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions. |
|
This PR was closed because there has been no follow up activity in 7 days. Thank you for your contributions. |




Description
This is the current behavior AIUI:
yarn setupcallsrn-nodeify --install crypto,buffer,react-native-randombytes,vm,stream,http,https,os,url,net,fs --hacknpm install.yarn.lockdue to the usage of npm instead of yarn.The changes in this PR:
--yarnflag is added to the invocation ofrn-nodeify, so that any packages added are also made present in lockfile.rn-nodeifyhave been added asdependenciesand the changes made to the manifest applied.rn-nodeifyis now run afterpatch-packageinstead of before, in order to have any patches made torn-nodeifyor any of its dependencies be effective.yarn setupwill exit with error ifrn-nodeifyintroduces any new dependencies not already declared.Out of scope
rn-nodeifyseems unmaintained and haven't seen updates in years. We could just remove the install part entirely once this has been committed. Also saving for a follow-up.Related issues
Manual testing steps
yarn setupScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist