Skip to content

fix: Use npm for dependencies - #9387

Closed
legobeat wants to merge 13 commits into
mainfrom
use-npm-deps-2
Closed

legobeat wants to merge 13 commits into
mainfrom
use-npm-deps-2

Conversation

@legobeat

@legobeat legobeat commented Apr 23, 2024 •

Copy link
Copy Markdown
Contributor

Description

#5324 revisited and rebased on main.

Related issues

Broken out

Blocked by

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@legobeat legobeat added dependencies Pull requests that update a dependency file team-application-security Application security team labels Apr 23, 2024
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat
legobeat requested a review from rickycodes April 23, 2024 23:45
@legobeat legobeat changed the title Use npm for dependencies ReDux fix: Use npm for dependencies Apr 23, 2024
@socket-security

socket-security Bot commented Apr 23, 2024 •

Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/react-native-aes-crypto@1.2.1 None 0 43.9 kB gudahtt
npm/@metamask/react-native-search-api@1.0.1 None 0 30.9 kB gudahtt
npm/@metamask/react-native-tcp@4.0.0 None +2 242 kB gudahtt
npm/base64-js@1.3.1 None 0 9.18 kB feross

🚮 Removed packages: npm/react-native-aes-crypto-forked@1.2.1, npm/react-native-search-api@1.0.1

View full report↗︎

@legobeat
legobeat force-pushed the use-npm-deps-2 branch 5 times, most recently from 58fa1cc to 7443fdd Compare April 25, 2024 00:00
@github-actions

github-actions Bot commented Apr 25, 2024 •

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2f35198db5bd0139ed0bd9e7073a8ee0f7f35927
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a389f746-ddd8-480c-895a-5dec1e97ef4b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@socket-security

socket-security Bot commented Apr 25, 2024 •

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@github-actions

github-actions Bot commented Aug 2, 2024

Copy link
Copy Markdown
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions Bot added the stale Issues that have not had activity in the last 90 days label Aug 2, 2024
@legobeat

legobeat commented Aug 2, 2024

Copy link
Copy Markdown
Contributor Author

bump

@github-actions github-actions Bot removed the stale Issues that have not had activity in the last 90 days label Aug 2, 2024
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions Bot added the stale Issues that have not had activity in the last 90 days label Oct 31, 2024
@github-actions

github-actions Bot commented Nov 7, 2024

Copy link
Copy Markdown
Contributor

This PR was closed because there has been no follow up activity in 7 days. Thank you for your contributions.

@github-actions github-actions Bot closed this Nov 7, 2024
Jwhiles added a commit that referenced this pull request Jul 23, 2026
Bump @metamask/money-account-upgrade-controller and
@metamask/chomp-api-service to the 8b1e39b preview builds, which add
GET-first address association (core #9387) plus terminal classification
of confirmed cross-profile 409 conflicts, and delegate the new
ChompApiService:getAssociatedAddresses action to the upgrade
controller's messenger.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Jwhiles added a commit that referenced this pull request Jul 23, 2026
Bump @metamask/money-account-upgrade-controller and
@metamask/chomp-api-service to the 8b1e39b preview builds, which add
GET-first address association (core #9387) plus terminal classification
of confirmed cross-profile 409 conflicts, and delegate the new
ChompApiService:getAssociatedAddresses action to the upgrade
controller's messenger.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file stale Issues that have not had activity in the last 90 days team-application-security Application security team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants