Skip to content

fix: migrate from patched @exodus/react-native-payments to @metamask/react-native-payments - #9483

Merged
legobeat merged 11 commits into
mainfrom
deps-react-native-payments
May 2, 2024
Merged

legobeat merged 11 commits into
mainfrom
deps-react-native-payments

Conversation

@legobeat

@legobeat legobeat commented May 1, 2024 •

Copy link
Copy Markdown
Contributor

Description

Instead of pulling in @exodus/react-native-payments from a git-commit and then patching it (!(?)), this migrates to a published version of the package under the name @metamask/react-native-payments with the same effect.

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented May 1, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added dependencies Pull requests that update a dependency file team-application-security Application security team labels May 1, 2024
@socket-security

socket-security Bot commented May 1, 2024 •

Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/react-native-payments@2.0.0 None +1 175 kB lgbot

🚮 Removed packages: npm/@exodus/react-native-payments@1.5.0

View full report↗︎

@legobeat
legobeat force-pushed the deps-react-native-payments branch 2 times, most recently from 0e7a217 to e4ff7b3 Compare May 1, 2024 00:37
@github-actions

github-actions Bot commented May 1, 2024 •

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e4ff7b3a0ce6c9d2c64cf3b3f20561cb4050a8ea
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c06dad47-17fc-4e1d-b70c-ae8ebd8309e0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat
legobeat marked this pull request as ready for review May 1, 2024 00:51
@legobeat
legobeat requested a review from a team as a code owner May 1, 2024 00:51
@legobeat
legobeat requested a review from a team May 1, 2024 00:51
@legobeat
legobeat requested a review from a team as a code owner May 1, 2024 00:51
@legobeat
legobeat requested review from Cal-L, Gudahtt and rickycodes May 1, 2024 00:52
@legobeat
legobeat force-pushed the deps-react-native-payments branch from e4ff7b3 to 99ce5e1 Compare May 2, 2024 00:02
@socket-security

socket-security Bot commented May 2, 2024 •

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/react-native-payments@2.0.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@legobeat

legobeat commented May 2, 2024

Copy link
Copy Markdown
Contributor Author
@SocketSecurity ignore npm/@metamask/react-native-payments@2.0.0

new author ok

@github-actions

github-actions Bot commented May 2, 2024 •

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 99ce5e1e43673e3c8c77275544cad9a3996a4ee7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/92afb02a-39eb-4ab9-8f15-457e850829c6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat
legobeat force-pushed the deps-react-native-payments branch from 99ce5e1 to f31cc43 Compare May 2, 2024 01:02
@github-actions

github-actions Bot commented May 2, 2024 •

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f31cc435fa9a194d93a24f8f7d89cf9b36af0c0d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/894fd194-c26e-4f07-af99-5a1f5e3615b4

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

rickycodes
rickycodes previously approved these changes May 2, 2024
@legobeat
legobeat force-pushed the deps-react-native-payments branch from f31cc43 to 3f60523 Compare May 2, 2024 08:13
@Gudahtt

Gudahtt commented May 2, 2024

Copy link
Copy Markdown
Member

I noticed that there were still references to the old package in Podfile.lock. The lock file had changes after a local install on macOS as well. I have pushed those changes in 2083232

@github-actions

github-actions Bot commented May 2, 2024 •

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2083232
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d2c0bf6a-f0fb-4408-a140-a205ff4b767c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from platform perspective. @wachunei Could someone from your team take a look at this PR since I believe payments is used by on-ramping

@sonarqubecloud

sonarqubecloud Bot commented May 2, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wachunei

wachunei commented May 2, 2024

Copy link
Copy Markdown
Member

If the changes from 1.5 -> 2 were the patches only then we are good to go, LGTM

@legobeat
legobeat merged commit 7359233 into main May 2, 2024
@legobeat
legobeat deleted the deps-react-native-payments branch May 2, 2024 20:23
@github-actions github-actions Bot locked and limited conversation to collaborators May 2, 2024
@metamaskbot metamaskbot added the release-7.23.0 Issue or pull request that will be included in release 7.23.0 label May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file release-7.23.0 Issue or pull request that will be included in release 7.23.0 team-application-security Application security team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants