Repository navigation
fix: migrate from patched @exodus/react-native-payments to @metamask/react-native-payments - #9483
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@exodus/react-native-payments@1.5.0 |
0e7a217 to
e4ff7b3
Compare
|
e4ff7b3 to
99ce5e1
Compare
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
new author ok |
|
99ce5e1 to
f31cc43
Compare
|
these changes were upstreamed in @metamask/react-native-payments^2.0.0
f31cc43 to
3f60523
Compare
|
I noticed that there were still references to the old package in |
|
|
|
If the changes from 1.5 -> 2 were the patches only then we are good to go, LGTM |




Description
Instead of pulling in
@exodus/react-native-paymentsfrom a git-commit and then patching it (!(?)), this migrates to a published version of the package under the name@metamask/react-native-paymentswith the same effect.Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist