Repository navigation
docs(testing): add lint-enforced CV anti-pattern checklist - #231
Merged
Merged
Conversation
Teach agents the short form of the component-view flake rules ESLint rejects on *.view.test.tsx, and require yarn eslint before finishing. Co-authored-by: racitores <racitores@users.noreply.github.com>
Keep main's changelog entries and add the component-view lint checklist line. Co-authored-by: racitores <racitores@users.noreply.github.com>
racitores
enabled auto-merge (squash)
November 18, 2026 10:54
javiergarciavera
approved these changes
Nov 18, 2026
cursor Bot
pushed a commit
that referenced
this pull request
Nov 18, 2026
Folds the post-branch merges into the curated 0.4.0 changelog per review: #258/#262 (mm-harness 0.96.33) into the recipe entry, #260/#261 into the perps-review-pr entry, #264 rule pack and #231 CV lint checklist as new entries, drops the inaccurate analytics-move BREAKING entry, and links Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com> #207 on the tsc-blindspots entry.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a short Rules (enforced by lint) checklist to
testing/mobile-testingso agents writing component-view tests (*.view.test.tsx) stop copying the flaky patterns.skills#217 is merged. It already holds the diagnosis: Golden Rules, the self-review checklist, and the Diagnosing Failures table. This PR does not restate that. Each lint rule is one line of why, a bad/good snippet, and a name-citation back to the existing rule.
metamask-mobile#38995 is also merged. Arbitrary
jest.mockwas already an ESLint error. That PR added the fake-timer ban. The rest of this list is the ESLint PR in progress on*.view.test.tsx.Checklist
jest.mockfind*insidewaitForclearAllMockswithoutmockResetAgents run
yarn eslint <file>on every new or edited CV test before finishing. A green Jest run does not cover these. Golden Rule 25 and self-review row 26 say the same thing. The write path in the decision tree and inwriting-tests.mdpoints at the checklist first.Type of Change
Checklist
Testing
Docs only. No frontmatter or maturity change.
yarn lint(changelog validation) passes.yarn audit:skillsreports 0 errors. Themobile-testingwarnings predate this PR.yarn testreports 0 failures.