Repository navigation
feat(perps-review-pr): generate a machine-readable rule pack - #264
Merged
Merged
Conversation
The generator writes references/pack.json beside the checklist: one entry per criterion family with its anchor, reference file, areas, class and status, and each rule with its cause. A family from a client file names that client, so a hosted review of one client never expects another client's rows. A direct invocation does not read the pack.
abretonc7s
marked this pull request as ready for review
November 18, 2026 14:48
abretonc7s
enabled auto-merge (squash)
November 18, 2026 14:49
juanmigdr
reviewed
Nov 18, 2026
juanmigdr
left a comment
Member
There was a problem hiding this comment.
VERDICT: COMMENT
COMMIT: beb7412
references/pack.json is exactly the generator's output for this head: 50 families and 157 rules, every field consistent with the references and owned-paths.json, and each family linked by exactly one step of every checklist that carries it. One metadata gap against the pack contract, plus one wording nit.
| Severity | file:line | Problem | Ask |
|---|---|---|---|
| domains/perps/skills/perps-review-pr/scripts/materialize-review.mjs:209 | No family uses the contract's always area, so the blocking-checks family is path-gated. On a diff that matches no owned path the selector may return every family unselected — including mobile-controller-integration-mocks, whose own rule is "Controller bump treated as lockfile-only". |
Emit { "always": true } for blocking-review-checks (client families must keep globs, since always takes no clients), decide where the cross-client parity trigger lives, then re-measure selection. |
|
| Nit | domains/perps/skills/perps-review-pr/scripts/materialize-review.mjs:194 | The message fires for a client that has no families of its own, because every shared family calls ownedPaths for all four clients. |
Reword to "which the pack needs paths for". |
Details for agents
| Status | Item | Evidence or gap | Ask |
|---|---|---|---|
| Farmslot selector behaviour | The pack contract's "Shipped so far" lists the decoders, declaration and freeze, but not the selectors or the per-family review children, so the live effect of the missing always marker could not be observed. |
Confirm the marker before this pack runs at level 3. | |
Canonical library at f8b9642 |
The committed pack was verified byte-for-byte against the head's own generated inputs (references/*.md, owned-paths.json, review-sources.json revision); matching the recipe library itself needs --check with that repository, which was not readable here. |
Run --check with the library before release. |
➖ 157 Perps rules and 2 conformity steps not applicable to this diff; full ledger in the run artifacts: artifacts/review-ledger.md.
abretonc7s
disabled auto-merge
November 18, 2026 15:02
…ule pack
The blocking review checks apply to every diff, so the pack marks that
family { always: true } instead of gating it on the clients' code
paths. The owned-paths error now says the pack needs the client's
paths, since shared families need every client's.
cursor Bot
pushed a commit
that referenced
this pull request
Nov 18, 2026
Folds the post-branch merges into the curated 0.4.0 changelog per review: #258/#262 (mm-harness 0.96.33) into the recipe entry, #260/#261 into the perps-review-pr entry, #264 rule pack and #231 CV lint checklist as new entries, drops the inaccurate analytics-move BREAKING entry, and links Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com> #207 on the tsc-blindspots entry.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
perps-review-prgainsreferences/pack.json, a rule pack a machine can read. The generator builds it from the same families it already turns into the checklist and references. It follows ADR-0073 Amendment 1 (MetaMask/decisions#320).The pack lists each criterion family with:
Each rule is listed with its cause. That is
pre-0073until an edit records the real one.A family from a client file names that client in
clients. A hosted review of one client then never expects another client's rows in its checklist.The generator now refuses two families that share an anchor across files, and a client that has families but no owned paths.
The pack is inert for anyone using the skill directly. The checklist, the overlays and the references are unchanged, and a direct invocation does not read
pack.json. Farmslot reads it once a project declares it, to freeze and validate the pack with the skill.Generated output
f8b9642.Tests
test/perps-review-generation.test.mjsfailed before the generator change and pass after it:yarn testpasses, exceptsource-sync-concurrency, which times out under local host load and is untouched here.yarn lint:changelogpasses.