Skip to content

Client search filters on the whole request object, not the search term #50

Closed

Description

@brinehart

File: core/csharp/MicroZen.Api/Services/ClientsGrpcService.cs:24-25

What this is: The name filter in GetManyClients.

Problem: EF.Functions.ILike(c.Name, $"%{request}%") interpolates request — the entire request message's ToString() — instead of request.SearchTerm. Every search matches nothing (or matches on a garbage string).

Fix: Use $"%{request.SearchTerm}%".

If we skip it: Client search is broken and always returns empty.

Activity

  1. added
    Must FixBug, security, data loss, or breaks at expected load
    on Oct 24, 2026
  2. brinehart commented on Nov 2, 2026

    @brinehart
    CollaboratorAuthor

    Resolved by PR #88 (merged into main as commit 3aaf7e0 via epic PR #81). Fix: GetManyClients filters on request.SearchTerm with a provider-agnostic case-insensitive predicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Must FixBug, security, data loss, or breaks at expected load

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions