[ilkecan]

• create a custom updateScript to manually do yarn-berry-fetcher missing-hashes which is not handled by nix-update
• set meta.changelog
• version update: https://github.com/mifi/lossless-cut/releases/tag/v3.69.0

Note

I am hoping we can get rid of the manual updateScript for this package (and some others) if Mic92/nix-update#640 is merged.

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.
• Follows the automation/AI policy.

---

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 541784
Commit: 3c3785c5ca40a6889f0775b8062df53c774c4d43

---

x86_64-linux

✅ 1 package built:

• losslesscut

[shelvacu]

Why ignore errors (|| true)?

[ilkecan]

I created that file from copying pieces from other ones. Currently on nixpkgs there are 5 update.sh that include both yarn-berry-fetcher missing-hashes & nix-update strings and among them 4 of them use || true at the end of nix-update. So I happened to pick one of those.

Now that you raise this up, I don't know whether that has a real purpose or happened to become the majority due to cargo culting. And the reason I didn't dissect the script in detail was because I feel like having to generate missing-hashes.json manually between 2 nix-update invocations was unfortunate and was hoping this could also be delegated to nix-update. So I was considering this script as temporary (Mic92/nix-update#640), which I should probably mention in the PR description.

In any case, I can remove those if you prefer it that way.

[shelvacu]

I much prefer it that way. In general, but also in this particular case if this command fails, then the src (probably) hasn't been updated and yarn-berry-fetcher will end up running on the old source.

[shelvacu]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 541784
Commit: b9d2b5c59d266a2c8bd8eff927015f463ebd0021

---

x86_64-linux

✅ 1 package built:

• losslesscut

[ShamrockLee]

This PR slipped out of my radar. Sorry for late reply.

[ShamrockLee]

Could you update this PR and make it work after PR ##555729

• yarn-berry: 4.14.1 -> 4.18.0 #555729

[ilkecan]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 541784
Commit: 9a3fe0ea6407bfd8b70fedf8d8eb236db965718e

---

x86_64-linux

✅ 1 package built:

• losslesscut

[nixpkgs-review-gha]

❌ nixpkgs-review result

Generated using nixpkgs-review-gha (b0ab82d)

Command: nixpkgs-review pr 541784
Commit: 9a3fe0ea6407bfd8b70fedf8d8eb236db965718e (subsequent changes)
Merge: 765fbf2b547d83299d9c1a564531f54242ab8531

Triggered by @ShamrockLee (44064051)
Logs: https://github.com/ShamrockLee/nixpkgs-review-gha/actions/runs/37805801042/attempts/1

---

x86_64-linux

✅ 1 package built:

• losslesscut

---

aarch64-linux

✅ 1 package built:

• losslesscut

---

aarch64-darwin (sandbox = relaxed)

❌ 1 package failed to build:

• losslesscut

[ilkecan]

It seems aarch64-darwin build for this package has never been successful: https://hydra.nixos.org/job/nixpkgs/unstable/losslesscut.aarch64-darwin

I can set meta.platforms = lib.platforms.linux; in another commit if you prefer?

[shelvacu]

I think you're supposed to do broken = stdenv.isDarwin; instead, because darwin is supported by losslesscut upstream, it's just the nix build that's broken

[shelvacu]

marking darwin broken would be nice but not a blocker

[nixpkgs-ci]

Backport failed for release-26.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-26.05
git worktree add -d .worktree/backport-541784-to-release-26.05 origin/release-26.05
cd .worktree/backport-541784-to-release-26.05
git switch --create backport-541784-to-release-26.05
git cherry-pick -x b4d510f2f5ee0c1da180e86ced452ab030e9af2a 9a3fe0ea6407bfd8b70fedf8d8eb236db965718e 6731ab8681619682fbc5f9ac6d99fb800a7c1661