[DimitarNestorov]

Things done

Closes #542343 (see https://github.com/NixOS/nixpkgs/pull/555729/changes#diff-acc055fd13bfb3b6051219bc66b0f1e1241eb18f1fc21c01f65bcf3ad6323891)
Closes #524710

Unblocks #554800 #553627

• Added lockfileVersion to yarn-berry so that it can be referenced by other derivations when modifying lockfiles. The value is confirmed in checkPhase so when upstream updates it again Yarn will fail to build.
• Using YARN_LOCKFILE_VERSION_PLACEHOLDER within dependant's patch files to prevent the need to modify them when upstream bumps the lockfile version again
• Apply dependant's patch files with the postFetch hook of fetchFromGitHub to prevent update scripts from breaking

---

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.
• Follows the automation/AI policy.

Build status

package	x86_64-linux	aarch64-linux	aarch64-darwin
actual-server	✅	✅	❌1
affine	✅2	✅2	✅
anki	✅	✅	❌3
aws-cdk-cli	✅	✅	✅
bitfocus-companion	✅4	✅4	N/A
cockpit-zfs	✅	✅	N/A
corepack	✅	✅	✅
dokieli	✅	✅	✅
eas-cli	✅	✅	✅
electron	⚠️5	⚠️5	N/A6
electron-fiddle	✅7	✅7	N/A
gitbeaker-cli	✅	❌8	✅
grafana	✅	✅	✅
hedgedoc	✅	✅	N/A
home-assistant-custom-lovelace-modules.advanced-camera-card	✅	✅	✅
home-assistant-custom-lovelace-modules.horizon-card	✅	✅	✅
insulator2	✅	✅	N/A
joplin-cli	✅	✅	✅
joplin-desktop	✅9	✅9	✅
koito.client	✅	✅	✅
learn6502	✅	✅	N/A
linkwarden	✅	N/A	N/A
losslesscut	✅10	✅10	❌11
mastodon	✅	✅	N/A
napi-rs-cli_3	✅	✅	✅
outline	✅	✅	N/A
peacock	✅	✅	N/A
pgadmin4	✅	✅	✅
prettier	✅	✅	✅
proton-authenticator	✅	✅	✅
python3Packages.locust.webui	✅	✅	✅
r2modman	✅12	✅12	✅
rocketchat-desktop	✅13	✅13	N/A
synapse-admin	✅	✅	✅
tilt	✅	✅	✅
uppy-companion	✅	✅	N/A
vultisig-cli	✅	✅	✅
ytmdesktop	✅14	✅14	✅

Footnotes

1. actual-server on Darwin fails on latest unstable too https://github.com/DimitarNestorov/nixpkgs-review-gha/actions/runs/33098429235 ↩

2. affine depends on Electron which takes more than 6 hours to build on Linux so I made a special derivation to confirm it builds fine with a cached version: https://github.com/DimitarNestorov/nixpkgs-review-gha/actions/runs/33062788761 ↩ ↩²

3. anki on Darwin fails on latest unstable too https://github.com/DimitarNestorov/nixpkgs-review-gha/actions/runs/33083022085/job/98555060676 ↩

4. bitfocus-companion depends on Electron which takes more than 6 hours to build on Linux so I made a special derivation to confirm it builds fine with a cached version: https://github.com/DimitarNestorov/nixpkgs-review-gha/actions/runs/33062702405 ↩ ↩²

5. electron on Linux is built from source and takes longer than 6 hours to build; without the changes in the electron folder build fails in less than 10 minutes: https://github.com/DimitarNestorov/nixpkgs-review-gha/actions/runs/33102956489/job/98625220517; with the changes we hit the GitHub Actions timeout: https://github.com/DimitarNestorov/nixpkgs-review-gha/actions/runs/33101431626 ↩ ↩²

6. electron on Darwin uses a binary distribution which doesn't depend on Yarn ↩

7. electron-fiddle depends on Electron which takes more than 6 hours to build on Linux so I made a special derivation to confirm it builds fine with a cached version: https://github.com/DimitarNestorov/nixpkgs-review-gha/actions/runs/33099485089 ↩ ↩²

8. gitbeaker-cli on aarch64-linux fails on latest unstable too https://github.com/DimitarNestorov/nixpkgs-review-gha/actions/runs/33054645174/job/98458281721 ↩

9. joplin-desktop depends on Electron which takes more than 6 hours to build on Linux so I made a special derivation to confirm it builds fine with a cached version: https://github.com/DimitarNestorov/nixpkgs-review-gha/actions/runs/33062730441 ↩ ↩²

10. losslesscut depends on Electron which takes more than 6 hours to build on Linux so I made a special derivation to confirm it builds fine with a cached version: https://github.com/DimitarNestorov/nixpkgs-review-gha/actions/runs/33062563720 ↩ ↩²

11. losslesscut on Darwin fails on latest unstable too https://github.com/DimitarNestorov/nixpkgs-review-gha/actions/runs/33104512452/job/98630649835 ↩

12. r2modman depends on Electron which takes more than 6 hours to build on Linux so I made a special derivation to confirm it builds fine with a cached version: https://github.com/DimitarNestorov/nixpkgs-review-gha/actions/runs/33062764831 ↩ ↩²

13. rocketchat-desktop depends on Electron which takes more than 6 hours to build on Linux so I made a special derivation to confirm it builds fine with a cached version: https://github.com/DimitarNestorov/nixpkgs-review-gha/actions/runs/33062539037 ↩ ↩²

14. ytmdesktop depends on Electron which takes more than 6 hours to build on Linux so I made a special derivation to confirm it builds fine with a cached version: https://github.com/DimitarNestorov/nixpkgs-review-gha/actions/runs/33062815570 ↩ ↩²

[SuperSandroBot]

❌ nixpkgs-review result

Generated using nixpkgs-review-gha (b0ab82d)

Command: nixpkgs-review pr 555729 -p home-assistant-custom-lovelace-modules.horizon-card
Commit: dd981394b79a4bf473bc92a6499e5a9de8d601a7 (subsequent changes)
Merge: 89590982a3f292951f09a1e9c894aa38b036fbef

Logs: https://github.com/SuperSandro2000/nixpkgs-review-gha/actions/runs/32660783561/attempts/1

---

x86_64-linux

❌ 1 package failed to build:

• home-assistant-custom-lovelace-modules.horizon-card

[DimitarNestorov]

❌ nixpkgs-review result

@SuperSandro2000 the PR is still a draft, I will check all dependents and run nixpkgs-review on all of them and create a table like I did in #513745

[SuperSandro2000]

I know, I just wanted to double-check my suspicion that that also broke 😂

Review dismissed automatically

[ShamrockLee]

Are previous lock file version deprecated and the hash changes inevitable?

I'm not familiar with the Node/Yarn toolchain to give an in-depth review, but an update that silently invalidate previous hashes would be frowned upon.

[DimitarNestorov]

Are previous lock file version deprecated and the hash changes inevitable?

Upstream bumped the lock file version in 4.14.0: yarnpkg/berry#7089

We briefly merged Yarn 4.14.0 which broke every package that depends on Yarn 4: #512685 (comment)

In #513745 we updated to Yarn 4.14.1 and patched every dependant to address the build failures.

Upstream bumped the lock file version in Yarn 4.15.0 again: https://github.com/yarnpkg/berry/pull/7135/changes#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2deR5

Which caused the same mismatched version issues: #524710 (comment)

[euank]

The anki package diff LGTM, approving for the anki portion.

[hatch01]

LGTM for cockpit-zfs, build successful and test from #557236 succeed!

[pbek]

I independently built proton-authenticator from the PR head on x86_64-linux:

nix build github:NixOS/nixpkgs/d6b70ff65c3f2f51606bec61e0e6cbd62562ba49#proton-authenticator

The Yarn installation, Webpack/Tauri build, and Rust tests all completed successfully (1 passed, 0 failed). I also launched the resulting application successfully.

The changes for proton-authenticator look good to me.

I also tested the functionality of the app.

[zacharyarnaise]

Built and tested tilt, works fine!
Approving the tilt changes.

[aduh95]

LGTM for corepack

[cjshearer]

LGTM. Built and tested ytmdesktop.

[demic-dev]

I independently built proton-authenticator from the PR head on x86_64-linux:

nix build github:NixOS/nixpkgs/d6b70ff65c3f2f51606bec61e0e6cbd62562ba49#proton-authenticator

The Yarn installation, Webpack/Tauri build, and Rust tests all completed successfully (1 passed, 0 failed). I also launched the resulting application successfully.

The changes for proton-authenticator look good to me.

I also tested the functionality of the app.

I built proton-authenticator on aarch64-linux as well and it compiles and runs succesfully. LGTM

[iv-nn]

LGTM. Built and tested koito.

[Tiebe]

LGTM for bitfocus-companion!

[Mynacol]

Built and quickly tested rocketchat-desktop. Everything looks normal 👍️