Skip to content

bitfocus-companion: 4.3.4 -> 5.0.5 - #560954

Merged
nixpkgs-ci[bot] merged 1 commit into
NixOS:stagingfrom
Tiebe:bitfocus-companion-5.0.5
Sep 9, 2026
Merged

bitfocus-companion: 4.3.4 -> 5.0.5#560954
nixpkgs-ci[bot] merged 1 commit into
NixOS:stagingfrom
Tiebe:bitfocus-companion-5.0.5

Conversation

@Tiebe

@Tiebe Tiebe commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Update of bitfocus-companion to 5.0.5

https://github.com/bitfocus/companion/releases/tag/v5.0.5

Things done

@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Sep 7, 2026
@Tiebe

Tiebe commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

Into staging until #555729 is merged into master

@Tiebe Tiebe mentioned this pull request Sep 7, 2026
Merged
4 of 13 tasks
SuperSandro2000
SuperSandro2000 approved these changes Sep 8, 2026
View reviewed changes

@SuperSandro2000 SuperSandro2000 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Sep 8, 2026
@VuiMuich

VuiMuich commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

I tried to build it with nixpkgs-review but some dependencies are too heavy for may laptop to build against staging.
But seeing SuperSandro already having approved it wouldn't matter too much anyways ig.

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Sep 8, 2026
DimitarNestorov
DimitarNestorov reviewed Sep 8, 2026
View reviewed changes
Comment thread pkgs/by-name/bi/bitfocus-companion/package.nix
Comment on lines -45 to +44
version = "4.3.4";
version = "5.0.5";

This comment was marked as resolved.

Sign in to view

DimitarNestorov
DimitarNestorov approved these changes Sep 8, 2026
View reviewed changes

@DimitarNestorov DimitarNestorov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successful build when rebased against master and using a cached electron derivation: https://github.com/DimitarNestorov/nixpkgs-review-gha/actions/runs/34212679583

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Sep 8, 2026
@Tiebe

Tiebe commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

@NixOS/nixpkgs-merge-bot merge

@Tiebe

Tiebe commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

Thank you for the reviews!

@nixpkgs-ci
nixpkgs-ci Bot added this pull request to the merge queue Sep 9, 2026
@nixpkgs-ci

nixpkgs-ci Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

@Tiebe wants to merge this PR.

Requirements to merge this PR with @NixOS/nixpkgs-merge-bot merge:

  • ✅ PR targets a development branch.
  • ✅ PR touches only files of packages in pkgs/by-name/.
  • ✅ PR is at least one of:
  • ✅ PR is not a draft
  • ✅ PR is not blocked by a "changes requested" review from a committer.
  • ✅ Tiebe is a member of @NixOS/nixpkgs-maintainers.
  • ✅ Tiebe is a maintainer of all touched packages on the staging branch.

✔️ Queued for merge (#306934)

Merged via the queue into NixOS:staging with commit cb9b0c0 Sep 9, 2026
43 of 45 checks passed
@Tiebe Tiebe mentioned this pull request Sep 30, 2026
Closed
4 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes
+2 more reviewers
@VuiMuich VuiMuich VuiMuich approved these changes
@DimitarNestorov DimitarNestorov DimitarNestorov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Tiebe @VuiMuich @SuperSandro2000 @DimitarNestorov