Skip to content

Fix OpenSwiftUI View Renderer requirement impl - #875

Merged
Kyle-Ye merged 2 commits into
mainfrom
bugfix/toggle
May 27, 2026
Merged

Fix OpenSwiftUI View Renderer requirement impl#875
Kyle-Ye merged 2 commits into
mainfrom
bugfix/toggle

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented May 27, 2026

Copy link
Copy Markdown
Member

Agent Summary

This fixes two Toggle-related rendering issues in the OpenSwiftUI UIKit-backed path.

The switch now respects the transaction animation setting when updating UISwitch.isOn, so animated transactions animate the control update and disabled-animation transactions update immediately.

This also updates display-list content requirement merging for platform content. Platform-backed content now contributes an item view without forcing an inherited view boundary, matching the expected view hierarchy and avoiding misplaced platform controls.

@github-actions github-actions Bot added area: animation Animation, transitions, transactions, or timing behavior. area: rendering DisplayList, render backends, renderer hosts, drawing, and effects. impact: visual-diff Visual mismatch, screenshot diff, or rendering fidelity issue. type: bug Something is not working correctly. labels May 27, 2026
@codecov

codecov Bot commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.95%. Comparing base (20e7dc3) to head (51b73aa).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #875      +/-   ##
==========================================
- Coverage   26.97%   26.95%   -0.03%     
==========================================
  Files         678      678              
  Lines       47149    47146       -3     
==========================================
- Hits        12720    12706      -14     
- Misses      34429    34440      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye
Kyle-Ye marked this pull request as ready for review May 27, 2026 07:49
@augmentcode

augmentcode Bot commented May 27, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Fixes UIKit Toggle rendering so UISwitch state changes animate only when animations are enabled, and adjusts display-list requirement merging so platform-backed content contributes an item view without forcing an inherited view boundary.
Why: Aligns animation behavior and view hierarchy with expected SwiftUI semantics, preventing misplaced platform controls in the UIKit-backed path.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@Kyle-Ye Kyle-Ye linked an issue May 27, 2026 that may be closed by this pull request
@Kyle-Ye
Kyle-Ye merged commit be40470 into main May 27, 2026
7 checks passed
@Kyle-Ye
Kyle-Ye deleted the bugfix/toggle branch May 27, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: animation Animation, transitions, transactions, or timing behavior. area: rendering DisplayList, render backends, renderer hosts, drawing, and effects. impact: visual-diff Visual mismatch, screenshot diff, or rendering fidelity issue. type: bug Something is not working correctly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Toggle position is incorrect in OpenSwiftUI View Renderer

1 participant