Fix OpenSwiftUI View Renderer requirement impl - #875
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #875 +/- ##
==========================================
- Coverage 26.97% 26.95% -0.03%
==========================================
Files 678 678
Lines 47149 47146 -3
==========================================
- Hits 12720 12706 -14
- Misses 34429 34440 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Kyle-Ye
marked this pull request as ready for review
May 27, 2026 07:49
🤖 Augment PR SummarySummary: Fixes UIKit Toggle rendering so 🤖 Was this summary useful? React with 👍 or 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent Summary
This fixes two Toggle-related rendering issues in the OpenSwiftUI UIKit-backed path.
The switch now respects the transaction animation setting when updating
UISwitch.isOn, so animated transactions animate the control update and disabled-animation transactions update immediately.This also updates display-list content requirement merging for platform content. Platform-backed content now contributes an item view without forcing an inherited view boundary, matching the expected view hierarchy and avoiding misplaced platform controls.