Skip to content

Fix OpenSwiftUI View Renderer requirement impl #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kyle-Ye merged 2 commits into from
May 27, 2026
Merged

Fix OpenSwiftUI View Renderer requirement impl #875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
066f671
Fix toggle animation issue
Kyle-Ye May 24, 2026
51b73aa
Fix platform content view requirements
Kyle-Ye May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/OpenSwiftUI/View/Toggle/SwitchToggleStyle.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ private struct Switch: UIViewRepresentable {
let isOn = isOn
let transaction = context.transaction
Update.enqueueAction(reason: nil) { [transaction] in
uiView.setOn(isOn, animated: transaction.disablesAnimations)
uiView.setOn(isOn, animated: !transaction.disablesAnimations)
}
uiView.preferredStyle = .sliding
let newTintColor: UIColor? = if let tint {
Expand Down
9 changes: 5 additions & 4 deletions Sources/OpenSwiftUICore/Render/DisplayList/DisplayListViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,26 +91,25 @@ extension DisplayList.ViewUpdater {
static let visibleContent = MergedViewRequirements(rawValue: 1 << 2)
}

@inline(__always)
fileprivate static func merge(
_ content: DisplayList.Content,
from item: DisplayList.Item,
into state: inout State,
requirements: inout MergedViewRequirements
) {
requirements.insert(.itemView)
state.versions.properties.combine(with: item.version)
switch content.value {
case let .backdrop(effect):
appendInheritedFilters(effect.filters, version: item.version, into: &state)
case let .chameleonColor(_, filters):
appendInheritedFilters(filters, version: item.version, into: &state)
case .view, .platformView, .platformLayer:
requirements.insert(.inheritedView)
default:
break
}
requirements.insert(.itemView)
}

@inline(__always)
fileprivate static func merge(
_ effect: DisplayList.Effect,
list: DisplayList,
Expand Down Expand Up @@ -162,6 +161,7 @@ extension DisplayList.ViewUpdater {
}
}

@inline(__always)
private static func merge(
_ transform: DisplayList.Transform,
item: DisplayList.Item,
Expand All @@ -185,6 +185,7 @@ extension DisplayList.ViewUpdater {
}
}

@inline(__always)
private static func merge(
_ filter: GraphicsFilter,
list: DisplayList,
Expand Down
Loading