Skip to content

Simplify test running directions - #552

Closed
FichteFoll wants to merge 1 commit into
PyCQA:masterfrom
FichteForks:run_tests
Closed

Simplify test running directions#552
FichteFoll wants to merge 1 commit into
PyCQA:masterfrom
FichteForks:run_tests

Conversation

@FichteFoll

Copy link
Copy Markdown
Contributor

The wording was poor, imo.

Comment thread docs/developer.rst

To run the Travis CI tests, you'll have to create a build the pycodestyle
package using tox::
To run the tests, use tox::

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about "To run the tests the same way Travis CI runs them, use tox::"

I think that captures the intent of the original awkward phrasing.

@FichteFoll FichteFoll Jun 24, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, the intent is to "run tests".
Instead of running tests "the way Travis CI does", CI should be running the tests like we do.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core developers use tox. Not everyone will want to. That's the point of specifying that you're running them the way the CI runs them - if they get incongruous results, they can replicate that.

@FichteFoll FichteFoll closed this Jun 24, 2016
@sigmavirus24 sigmavirus24 reopened this Jun 24, 2016
@sigmavirus24

Copy link
Copy Markdown
Member

You closed this by accident, yes?

@FichteFoll

FichteFoll commented Jun 24, 2016

Copy link
Copy Markdown
Contributor Author

No, it was on purpose.

Since you disagree with my fundamental reasoning on why I made the change to remove "Travis CI" and I presented all my arguments already, I don't see a future for this PR. The change is so trivial, its's not worth spending more time on it, which is why I withdrew it.

Any further changes to the wording are at your discretion.

@IanLee1521 IanLee1521 added this to the 2.1 milestone Jun 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants