Skip to content

Simplify test running directions #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FichteFoll wants to merge 1 commit into from
Closed

Simplify test running directions #552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions docs/developer.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,7 @@ Then be sure to pass the tests::

When contributing to pycodestyle, please observe our `Code of Conduct`_.

To run the Travis CI tests, you'll have to create a build the pycodestyle
package using tox::
To run the tests, use tox::

@sigmavirus24 sigmavirus24 Jun 24, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about "To run the tests the same way Travis CI runs them, use tox::"

I think that captures the intent of the original awkward phrasing.

@FichteFoll FichteFoll Jun 24, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, the intent is to "run tests".
Instead of running tests "the way Travis CI does", CI should be running the tests like we do.

@sigmavirus24 sigmavirus24 Jun 24, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core developers use tox. Not everyone will want to. That's the point of specifying that you're running them the way the CI runs them - if they get incongruous results, they can replicate that.


$ pip install -r dev-requirements.txt
$ tox
Expand Down