Repository navigation
Fix installer contention and channel, host and wallet CI fixtures - #15
Merged
Merged
Conversation
LIghtJUNction
marked this pull request as ready for review
November 22, 2026 16:59
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft retains the installer contention, channel authorization and assistant-startup regressions, plus the existing wallet fixture, against
fc0af2432346e06e2bcb1f4dbc5969aca6c3f56e. Main now supplies the serializable HumanGrant transaction for metered-key confirmation, the runtime role fixtures, confirmation lock order, grant lifetimes and history importer. The earlier Web lint, Clippy, payment privilege checks and discount history fixtures are also already on main.ChannelRead covers five read endpoints. Exercise their default access with the root session, install an explicit deny, and verify the same reads then return 403 with the database unchanged.
The configured assistant requires invitation read authority. Exercise its rejection before enabling the fixture's existing web-identity grant, and assert the advertised invitation feature on successful startup. The real executable and counted loopback endpoint remain part of the test.
Two fresh Core installers contend on the existing PostgreSQL installation lock. When the configured three-second bound expired, the losing installer returned a generic storage error. Map SQLSTATE 55P03 at this one lock acquisition to the existing Conflict result. The regression holds the lock on a separate connection and confirms that the new installer created no Core schema. The original concurrent installation and drift test remains in place.
The Web test on the previous PR head failed at wallet/index.test.tsx:804. The subscription error and its sibling reset-voucher loader both appeared in the disclosure's text. This branch includes the original test commit from #14 with the same Git object and wallet test blob. It holds the voucher request through the plan error and retry, checks both request counts, checks the plan's confirmed empty state, and resolves the voucher separately.
Independent local builds passed all 16 confirmation tests, the ChannelRead policy case, each of the eight assistant startup subprocess cases, both installer contention tests, all-target Clippy, and all 48 service-boundary tests. All 12 wallet tests, Web typechecking and formatting passed. Tests use ephemeral PostgreSQL and synthetic identities. No workflow, role grant, schema, release or deployment configuration changed. The five original microkernel steps and the full Rust/database suites run in the normal pull request checks.