Skip to content

Fix installer contention and channel, host and wallet CI fixtures - #15

Merged
LIghtJUNction merged 11 commits into
mainfrom
fix/core87-retained-snapshot
Nov 22, 2026
Merged

LIghtJUNction merged 11 commits into
mainfrom
fix/core87-retained-snapshot

Conversation

@LIghtJUNction

@LIghtJUNction LIghtJUNction commented Nov 22, 2026 •

Copy link
Copy Markdown
Member

This draft retains the installer contention, channel authorization and assistant-startup regressions, plus the existing wallet fixture, against fc0af2432346e06e2bcb1f4dbc5969aca6c3f56e. Main now supplies the serializable HumanGrant transaction for metered-key confirmation, the runtime role fixtures, confirmation lock order, grant lifetimes and history importer. The earlier Web lint, Clippy, payment privilege checks and discount history fixtures are also already on main.

  • ChannelRead covers five read endpoints. Exercise their default access with the root session, install an explicit deny, and verify the same reads then return 403 with the database unchanged.

  • The configured assistant requires invitation read authority. Exercise its rejection before enabling the fixture's existing web-identity grant, and assert the advertised invitation feature on successful startup. The real executable and counted loopback endpoint remain part of the test.

  • Two fresh Core installers contend on the existing PostgreSQL installation lock. When the configured three-second bound expired, the losing installer returned a generic storage error. Map SQLSTATE 55P03 at this one lock acquisition to the existing Conflict result. The regression holds the lock on a separate connection and confirms that the new installer created no Core schema. The original concurrent installation and drift test remains in place.

  • The Web test on the previous PR head failed at wallet/index.test.tsx:804. The subscription error and its sibling reset-voucher loader both appeared in the disclosure's text. This branch includes the original test commit from #14 with the same Git object and wallet test blob. It holds the voucher request through the plan error and retry, checks both request counts, checks the plan's confirmed empty state, and resolves the voucher separately.

Independent local builds passed all 16 confirmation tests, the ChannelRead policy case, each of the eight assistant startup subprocess cases, both installer contention tests, all-target Clippy, and all 48 service-boundary tests. All 12 wallet tests, Web typechecking and formatting passed. Tests use ephemeral PostgreSQL and synthetic identities. No workflow, role grant, schema, release or deployment configuration changed. The five original microkernel steps and the full Rust/database suites run in the normal pull request checks.

@LIghtJUNction LIghtJUNction changed the title Use SQLx-owned database names in the retained history fixture Fix Core87 retained history and browser confirmation regressions Nov 22, 2026
@LIghtJUNction LIghtJUNction changed the title Fix Core87 retained history and browser confirmation regressions Fix browser confirmation, startup and installer CI regressions Nov 22, 2026
@LIghtJUNction LIghtJUNction changed the title Fix browser confirmation, startup and installer CI regressions Fix browser confirmation, startup, installer and wallet CI regressions Nov 22, 2026
@LIghtJUNction LIghtJUNction changed the title Fix browser confirmation, startup, installer and wallet CI regressions Fix installer contention and channel, host and wallet CI fixtures Nov 22, 2026
@LIghtJUNction
LIghtJUNction marked this pull request as ready for review November 22, 2026 16:59
@LIghtJUNction
LIghtJUNction merged commit a9fab47 into main Nov 22, 2026
4 of 5 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 22, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-22T17:02:51.624691Z b4c5448 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants