Repository navigation
Dismiss edit sheet only from its drag handle - #20
Merged
Tricked-dev merged 1 commit intoOct 2, 2026
Merged
Conversation
Swiping down inside the edit form scrolled leftover drag and fling deltas up to the ModalBottomSheet, which dismissed it from anywhere in the form. Consume vertical overscroll in the form so only the handle at the top can pull the sheet down.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Swiping down anywhere in the time-entry edit form dismissed the sheet. Once the form was scrolled to the top, leftover drag and fling deltas propagated to
ModalBottomSheetthrough nested scroll, which treated them as a dismiss gesture. Losing in-progress edits to an accidental swipe is easy, especially while scrolling back up.The form now consumes leftover vertical scroll and fling (
ConsumeVerticalOverscroll), so swipes inside it only scroll it. The drag handle at the top still drags and dismisses the sheet as before. Lists nested inside the form (e.g. the tag picker) are covered by the same connection. The tablet inline presentation has no swipe-to-dismiss and is unaffected.Scope and acceptance criteria
Non-goal: other sheets (template editor, calendar, statistics) keep their current behavior.
Validation
Commands and focused tests actually run:
Verification status by scope:
SheetSwipeDismissTestshows a downward swipe at the top of a scrolling form reaches the parent sheet without the guard (control) and delivers zero scroll and fling with it.Evidence and remaining gaps
Not yet exercised by hand on a device.
Safety and working tree