Repository navigation
Dismiss bottom sheets only from their drag handle - #21
Merged
Tricked-dev merged 2 commits intoOct 3, 2026
Merged
Tricked-dev merged 2 commits into
Tricked-dev merged 2 commits into
Conversation
Tricked-dev#20 fixed EditTimeEntryDialog, used by Calendar and Inbox, but the Tracking screen edits entries in its own TimeEntryFormSheet, which still let downward swipes inside the form dismiss the sheet. Apply the same ConsumeVerticalOverscroll connection there and cover it with a test.
Apply ConsumeVerticalOverscroll to the shared AppSheet and to the server, template editor and statistics drill-down sheets, so a downward swipe inside any sheet's content only scrolls it. Each sheet gets a test that fails without the change.
AKolenda
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #20.
Problem
In v0.3.1, swiping down anywhere inside a bottom sheet still closes it. #20 fixed
EditTimeEntryDialog, but only Calendar and Inbox use that. Every other sheet still closes from a downward swipe in the middle of its content, including the Tracking screen's ownTimeEntryFormSheet.Fix
Every
ModalBottomSheetin the app now closes only when dragged by its handle, like an iOS sheet. Swipes inside the content only scroll it. Each sheet's scrolling content gets theConsumeVerticalOverscrollconnection from #20:TimeEntryFormSheet, the Tracking edit/add sheet (TrackingScreen.kt)AppSheet, which covers history filters, calendar sheets, inbox settings, statistics filters and the timer bar sheetConfigScreen.kt)TemplateEditorSheetStatDrillDownSheet(aLazyColumn)Tests
spotlessCheck,lintDebug,assembleDebugandassembleDebugAndroidTestpass locally.testDebugUnitTestruns, a few tracking tests (TrackingViewModelNetworkRaceTest,TrackingViewModelRunningEntryTest,TrackingScreenJumpTest) failed intermittently. They pass when rerun alone, andTrackingScreenJumpTestpassed 3/3 both on this branch and onmaster. None of them open a sheet.