Repository navigation
Support for type annotations - #50
Merged
Merged
Conversation
volivan239
force-pushed
the
volivan239/jvm_type_annotations
branch
from
January 26, 2023 18:05
294eb49 to
bbedf7c
Compare
Contributor
Contributor
volivan239
force-pushed
the
volivan239/jvm_type_annotations
branch
from
January 26, 2023 18:34
bbedf7c to
cdda45b
Compare
volivan239
marked this pull request as draft
January 26, 2023 20:40
volivan239
force-pushed
the
volivan239/jvm_type_annotations
branch
from
January 27, 2023 22:13
264a853 to
5f804e8
Compare
volivan239
marked this pull request as ready for review
January 29, 2023 17:27
volivan239
changed the title
# Conflicts: # jacodb-api/src/main/kotlin/org/jacodb/api/JcClasspath.kt # jacodb-api/src/main/kotlin/org/jacodb/api/Types.kt # jacodb-core/src/main/jooq/org/jacodb/impl/storage/jooq/DefaultCatalog.kt # jacodb-core/src/main/jooq/org/jacodb/impl/storage/jooq/DefaultSchema.kt # jacodb-core/src/main/jooq/org/jacodb/impl/storage/jooq/indexes/Indexes.kt # jacodb-core/src/main/jooq/org/jacodb/impl/storage/jooq/tables/Annotations.kt # jacodb-core/src/main/jooq/org/jacodb/impl/storage/jooq/tables/Annotationvalues.kt # jacodb-core/src/main/jooq/org/jacodb/impl/storage/jooq/tables/Builders.kt # jacodb-core/src/main/jooq/org/jacodb/impl/storage/jooq/tables/Bytecodelocations.kt # jacodb-core/src/main/jooq/org/jacodb/impl/storage/jooq/tables/Calls.kt # jacodb-core/src/main/jooq/org/jacodb/impl/storage/jooq/tables/Classes.kt # jacodb-core/src/main/jooq/org/jacodb/impl/storage/jooq/tables/Classhierarchies.kt # jacodb-core/src/main/jooq/org/jacodb/impl/storage/jooq/tables/Classinnerclasses.kt # jacodb-core/src/main/jooq/org/jacodb/impl/storage/jooq/tables/Fields.kt # jacodb-core/src/main/jooq/org/jacodb/impl/storage/jooq/tables/Methodparameters.kt # jacodb-core/src/main/jooq/org/jacodb/impl/storage/jooq/tables/Methods.kt # jacodb-core/src/main/jooq/org/jacodb/impl/storage/jooq/tables/Outerclasses.kt # jacodb-core/src/main/jooq/org/jacodb/impl/storage/jooq/tables/Symbols.kt # jacodb-core/src/main/jooq/org/jacodb/impl/storage/jooq/tables/records/AnnotationsRecord.kt # jacodb-core/src/main/kotlin/org/jacodb/impl/JcClasspathImpl.kt # jacodb-core/src/main/kotlin/org/jacodb/impl/bytecode/JcFieldImpl.kt # jacodb-core/src/main/kotlin/org/jacodb/impl/bytecode/JcMethodImpl.kt # jacodb-core/src/main/kotlin/org/jacodb/impl/fs/ByteCodeConverter.kt # jacodb-core/src/main/kotlin/org/jacodb/impl/types/JcArrayTypeImpl.kt # jacodb-core/src/main/kotlin/org/jacodb/impl/types/JcClassTypeImpl.kt # jacodb-core/src/main/kotlin/org/jacodb/impl/types/JcGenericTypes.kt # jacodb-core/src/main/kotlin/org/jacodb/impl/types/JcTypedFieldImpl.kt # jacodb-core/src/main/kotlin/org/jacodb/impl/types/JcTypedMethodImpl.kt # jacodb-core/src/main/kotlin/org/jacodb/impl/types/JcTypedMethodParameterImpl.kt # jacodb-core/src/main/kotlin/org/jacodb/impl/types/NullabilityAnnotations.kt # jacodb-core/src/main/kotlin/org/jacodb/impl/types/signature/FieldSignature.kt # jacodb-core/src/main/kotlin/org/jacodb/impl/types/signature/JvmTypes.kt # jacodb-core/src/main/kotlin/org/jacodb/impl/types/signature/MethodSignature.kt # jacodb-core/src/main/kotlin/org/jacodb/impl/types/signature/TypeAnnotationMaintianer.kt # jacodb-core/src/main/kotlin/org/jacodb/impl/types/signature/TypeNullabilityMaintainer.kt # jacodb-core/src/main/kotlin/org/jacodb/impl/types/substition/JcSubstitutorImpl.kt # jacodb-core/src/test/kotlin/org/jacodb/testing/AnnotationsTest.kt # jacodb-core/src/test/kotlin/org/jacodb/testing/types/TypeAnnotationsTest.kt # jacodb-core/src/test/kotlin/org/jacodb/testing/types/nullability/JavaNullabilityTest.kt # jacodb-core/src/test/kotlin/org/jacodb/testing/types/nullability/KotlinJavaInteropNullabilityTest.kt # jacodb-core/src/test/kotlin/org/jacodb/testing/types/nullability/NullabilityByAnnotationsTest.kt
Collaborator
|
@volivan239 IRTest has a serious performance degradation ~30/50% in time. Let's investigate it before merge. |
Collaborator
Author
I couldn't reproduce this locally. I launched |
lehvolk
added a commit
that referenced
this pull request
Feb 28, 2023
… inside JcClassOrInterface [fix] fixed performance degradation in processing kotlin classes also relates to PR: Support for type annotations #50
Collaborator
|
There is specific test related to Kotlin code |
# Conflicts: # jacodb-core/build.gradle.kts # jacodb-core/src/main/kotlin/org/jacodb/impl/JcClasspathImpl.kt # jacodb-core/src/main/kotlin/org/jacodb/impl/bytecode/JcFieldImpl.kt # jacodb-core/src/main/kotlin/org/jacodb/impl/bytecode/JcMethodImpl.kt # jacodb-core/src/main/kotlin/org/jacodb/impl/fs/ByteCodeConverter.kt # jacodb-core/src/main/kotlin/org/jacodb/impl/types/JcClassTypeImpl.kt # jacodb-core/src/main/kotlin/org/jacodb/impl/types/JcTypeBindings.kt # jacodb-core/src/main/kotlin/org/jacodb/impl/types/signature/JvmTypes.kt # jacodb-core/src/main/kotlin/org/jacodb/impl/types/signature/MethodSignature.kt # jacodb-core/src/main/kotlin/org/jacodb/impl/types/signature/TypeNullabilityMaintainer.kt # jacodb-core/src/main/kotlin/org/jacodb/impl/types/substition/JcSubstitutorImpl.kt # jacodb-core/src/testFixtures/kotlin/org/jacodb/testing/tests/DatabaseEnvTest.kt
# Conflicts: # jacodb-core/src/main/kotlin/org/jacodb/impl/types/substition/JcSubstitutorImpl.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.